Re: checks/fields rewrite
On Sun, Mar 28, 2004 at 11:00:46AM +0200, Marc 'HE' Brockschmidt wrote:
> Frank Lichtenheld <djpig@debian.org> writes:
>
> > + #FIXME: checks for "If there is no debian_revision then hyphens are not allowed; if there is no epoch then colons are not allowed."
>
> We can't check that. If the upstream version contains a hyphen and there
> is no debian revision, the part of the upstream version is parsed as
> debian revision. That's the way apt and the others work, and there is no
> way around that problem. Same for epoch.
> One *could* warn about weird looking debian_revisions, but OTOH there
> are packages with an upstream version X.Y-1 (where the check wouldn't
> warn) and backports use really weird debian revision, so lintian would
> warn there. No, too many false positives.
Hmm, my fault
> > + #FIXME: check for "[epoch:] This is a _single_ (generally small) unsigned integer"
>
> An integer is not a single _digit_, \d+ is IMO ok.
yeah, ok
>
> > +#FIXME: split out regexes that are used more than once
> > if ($source !~ /[A-Z0-9][-+\.A-Z0-9]+ #Package name
> > \s*
> > (?:\((?:\d+:)?(?:[-\.+:A-Z0-9]+?)(?:-[\.+A-Z0-9]+)?\))?\s*$/ix) { #Version
>
> It's used once (or do you mean the first part for the package name)?
Honestly I will have to look at the code once more to answer that, will
check that later.
> > #---- Section
> > @@ -174,6 +182,7 @@
> > print "E: $pkg $type: non-us-spelling\n" if ($1 && $1 ne "non-US");
> > $section =~ s!^(non-free|contrib)/!!;
> >
> > +#FIXME: doesn't handles contrib/non-free
>
> It does, i remove the contrib/non-free prefix if it's there (see the
> line of code above your comment)
*hrmpf*, yeah, was blind
> > @@ -202,6 +212,7 @@
> >
> > my (@seen_libstdcs, @seen_tcls, @seen_tclxs, @seen_tks, @seen_tkxs, @seen_libpngs);
> >
> > +#FIXME: this check is fully broken, or better: where is the check?
>
> Don't understand what you mean. The @seen_* arrays are used *after* the
> loop.
I actually meant the line below the comment:
print "E: $pkg $type: alternates-not-allowed $field\n"
if (! grep { $_ eq $field } qw(depends pre-depends recommends suggests));
> > +#FIXME: Standards-Version is recommended, should give an error
>
> That'd be a new check, i wanted to replace the old script first.
Yeah, this was not meant as an error in your code. I just realised
it while going through it.
> I've attached a new version.
Will look at it in detail later.
Thanks,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Reply to: