[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#242345: marked as done ([checks/po-debconf] po-debconf: check for outdated templates.pot files)



Your message dated Fri, 10 Dec 2004 20:47:21 -0500
with message-id <E1CcwLx-0002qD-00@newraff.debian.org>
and subject line Bug#242345: fixed in lintian 1.23.4
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 6 Apr 2004 06:37:05 +0000
>From barbier@mp4h.org Mon Apr 05 23:37:05 2004
Return-path: <barbier@mp4h.org>
Received: from smtp-102-tuesday.nerim.net (kraid.nerim.net) [62.4.16.102] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BAkCn-0000AL-00; Mon, 05 Apr 2004 23:37:05 -0700
Received: from localhost.localdomain (sinibar.net1.nerim.net [62.4.18.43])
	by kraid.nerim.net (Postfix) with ESMTP
	id D439F41A5D; Tue,  6 Apr 2004 08:37:03 +0200 (CEST)
Received: by localhost.localdomain (Postfix, from userid 1000)
	id 8483C25B86; Tue,  6 Apr 2004 08:39:34 +0200 (CEST)
Date: Tue, 6 Apr 2004 08:39:34 +0200
From: Denis Barbier <barbier@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: po-debconf: check for outdated templates.pot files
Message-ID: <20040406063934.GA2371@imacs.polytechnique.fr>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="3MwIy2ne0vdjdPXF"
Content-Disposition: inline
X-Reportbug-Version: 2.56
User-Agent: Mutt/1.5.5.1+cvs20040105i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Scores: 1


--3MwIy2ne0vdjdPXF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: lintian
Version: 1.22.12
Severity: wishlist

Hi,

here is a patch to check whether templates.pot files are outdated wrt
debconf templates files.  A similar test appeared in lintian 1.22.9,
but I asked for its removal in 1.22.11 when the po-debconf stuff was
rewritten, because I did not like how this test was performed and I
(wrongly) thought that this problem won't occur anymore after some
changes in the po-debconf package.
This new test is much better, so I am quite confident that I won't 
ask for its removal soon ;)

Denis

--3MwIy2ne0vdjdPXF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="po-debconf.patch"

Index: po-debconf
===================================================================
--- po-debconf	(revision 122)
+++ po-debconf	(working copy)
@@ -55,6 +55,7 @@
 #   Exit if package does not seem to use po-debconf
 -d "debfiles/po" or exit(0);
 
+my $missing_files = 0;
 if (-f "debfiles/po/POTFILES.in") {
 	open(POTFILES,"debfiles/po/POTFILES.in")
 		or fail("Can't open debfiles/po/POTFILES.in.");
@@ -63,15 +64,18 @@
 		s/.*\]\s*//;
 		#  Cannot check files which are not under debian/
 		next if m,^\.\./,;
-		print "W: $pkg $type: missing-file-from-potfiles-in $_\n"
-			 unless -f "debfiles/$_";
+		next if -f "debfiles/$_";
+		print "W: $pkg $type: missing-file-from-potfiles-in $_\n";
+		$missing_files = 1;
 	}
 	close(POTFILES);
 } else {
 	print "W: $pkg $type: missing-potfiles-in\n";
+	$missing_files = 1;
 }
 if (! -f "debfiles/po/templates.pot") {
 	print "W: $pkg $type: missing-templates-pot\n";
+	$missing_files = 1;
 }
 
 opendir(DEBIAN, 'debfiles/po')
@@ -80,6 +84,17 @@
     print "N: Warning: msgfmt (package gettext) not available, not\n";
     print "N: going to check *.po syntax\n";
 }
+if (-x "/usr/bin/msgcmp" && -x "/usr/share/intltool-debian/intltool-update" ) {
+	if ($missing_files == 0) {
+		system("cd debfiles/po && /usr/share/intltool-debian/intltool-update --gettext-package=test --pot");
+		system("/usr/bin/msgcmp debfiles/po/test.pot debfiles/po/templates.pot >/dev/null 2>&1") == 0
+                	or print "W: $pkg $type: newer-debconf-templates\n";
+	}
+} else {
+	print "N: Warning: msgcmp (package gettext) or intltool-update\n";
+	print "N: (package intltool-debian) not available, not going to\n";
+	print "N: check if PO files are outdated\n";
+}
 while (defined(my $file=readdir(DEBIAN))) {
         next unless $file =~ m/\.po$/;
         local ($/) = "\n\n";
Index: po-debconf.desc
===================================================================
--- po-debconf.desc	(revision 122)
+++ po-debconf.desc	(working copy)
@@ -37,3 +37,12 @@
 Type: warning
 Info: Some errors are found in PO files and their content will be
  discarded.  Run 'msgfmt' to see error messages.
+
+Tag: newer-debconf-templates
+Type: warning
+Info: Some debconf templates files have been updated, but PO files do
+ not reflect these changes.
+ .
+ You should run debconf-updatepo whenever debconf templates files are
+ changed so that translators can be warned that their files are
+ outdated.

--3MwIy2ne0vdjdPXF--

---------------------------------------
Received: (at 242345-close) by bugs.debian.org; 11 Dec 2004 01:49:04 +0000
>From katie@ftp-master.debian.org Fri Dec 10 17:49:04 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CcwNc-00055p-00; Fri, 10 Dec 2004 17:49:04 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CcwLx-0002qD-00; Fri, 10 Dec 2004 20:47:21 -0500
From: Frank Lichtenheld <djpig@debian.org>
To: 242345-close@bugs.debian.org
X-Katie: $Revision: 1.54 $
Subject: Bug#242345: fixed in lintian 1.23.4
Message-Id: <E1CcwLx-0002qD-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Fri, 10 Dec 2004 20:47:21 -0500
Delivered-To: 242345-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Source: lintian
Source-Version: 1.23.4

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_1.23.4.dsc
  to pool/main/l/lintian/lintian_1.23.4.dsc
lintian_1.23.4.tar.gz
  to pool/main/l/lintian/lintian_1.23.4.tar.gz
lintian_1.23.4_all.deb
  to pool/main/l/lintian/lintian_1.23.4_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 242345@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frank Lichtenheld <djpig@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon,  6 Dec 2004 01:41:21 +0100
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.4
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Frank Lichtenheld <djpig@debian.org>
Description: 
 lintian    - Debian package checker
Closes: 242345 257904 258815 261890 276504 276945 277393 278513 280080 282030
Changes: 
 lintian (1.23.4) unstable; urgency=low
 .
   The "A little pause from the sarge release work" release.
 .
   * checks/changelog-file:
     + [FL] file has apparently changed its output format for
       symlinks sometime in the past. This broke symlink detection.
       (Closes: #276504)
   * checks/deb-format, unpack/unpack-binpkg-l1, unpack/unpack-binpkg-l2:
     + [CW] Fix binary package data member extraction to work with arbitrary
       compression algorithms instead of hardcoding data.tar.gz.
   * checks/debconf{,.desc}:
     + [FL] The SETTITLE command was introduced in debconf version
       1.3.22. Check the depends for that (Closes: #261890)
     + [FL] Warn about incorrect usage of commas in translated Choices
       fields. Patch by Denis Barbier after a suggestion by Andreas
       Metzler (Closes: #282030)
   * checks/debhelper:
     + [FL] Update list of debhelper scripts that modify maintainer
       scripts
   * checks/menu-format.desc:
     + [FL] Adjust references to the menu documentation. Noted by
       Jack Moffitt (Closes: #277393)
   * checks/po-debconf{,.desc}:
     + [FL] Check for outdated .pot files when using po-debconf.
       This requires a new dependency on intltool-debian. Patch
       by Denis Barbier with corrections by JvW (Closes: #242345)
   * checks/scripts{,.desc}:
     + [FL] Fix copy-and-paste error in description
       of wrong-path-for-gnuplot (Closes: #276945)
       Thanks to Lionel Elie Mamane for reporting.
     + [FL] Add tclsh8.3 to list of valid interpreters as it is used
       in at least one package. (Closes: #280080)
     + [FL] Issue wrong-path-for-{ruby,python} even if the path contained
       a version number. Change the description of the tag to reflect that.
       (Closes: #257904)
 .
   * frontend/lintian-info:
     + [FL] Overrides start with O:, not with 0:, d'oh!
       (Closes: #258815)
 .
   * lib/Tags.pm:
     + [FL] Add missing "use Util;", noted by Robert Luberda
       (Closes: #278513)
 .
   * testset/debconf/*,testset/tags.debconf:
     + [FL] New test package for debconf and udeb tests
   * testset/diffs:
     + [JvW] Remove the shipped ELF binary, can be compiled at test-time
   * testset/runtests:
     + [FL] Make checks of udeb packages possible
Files: 
 58413a8540cbdec3f0c6d1bdf5501541 738 devel optional lintian_1.23.4.dsc
 f6b09204ca78fe503ce4ee588b8b908e 253336 devel optional lintian_1.23.4.tar.gz
 a40e0a1afa3cf21ba24bd512e6b0de63 219554 devel optional lintian_1.23.4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBukoyQbn06FtxPfARAgd6AJ9TRss/obp20vvmojZGSuahV9DOaACfbdJ4
B6zRrHlHrYfqox7AkjpEyJM=
=Zp4f
-----END PGP SIGNATURE-----



Reply to: