Re: [PATCH 00/04] Load keyspan firmware with hotplug
- To: Marcel Holtmann <marcel@holtmann.org>
- Cc: Dmitry Torokhov <dtor_core@ameritech.net>, Jan Harkes <jaharkes@cs.cmu.edu>, Greg KH <greg@kroah.com>, Sven Luther <sven.luther@wanadoo.fr>, Michael Poole <mdpoole@troilus.org>, debian-legal@lists.debian.org, debian-kernel@lists.debian.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
- Subject: Re: [PATCH 00/04] Load keyspan firmware with hotplug
- From: Jan Harkes <jaharkes@cs.cmu.edu>
- Date: Tue, 5 Apr 2005 07:45:43 -0400
- Message-id: <[🔎] 20050405114543.GG10171@delft.aura.cs.cmu.edu>
- Mail-followup-to: Marcel Holtmann <marcel@holtmann.org>, Dmitry Torokhov <dtor_core@ameritech.net>, Jan Harkes <jaharkes@cs.cmu.edu>, Greg KH <greg@kroah.com>, Sven Luther <sven.luther@wanadoo.fr>, Michael Poole <mdpoole@troilus.org>, debian-legal@lists.debian.org, debian-kernel@lists.debian.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
- In-reply-to: <[🔎] 1112692926.8263.125.camel@pegasus>
- References: <[🔎] 20050404100929.GA23921@pegasos> <[🔎] 20050404191745.GB12141@kroah.com> <[🔎] 20050405042329.GA10171@delft.aura.cs.cmu.edu> <[🔎] 200504042351.22099.dtor_core@ameritech.net> <[🔎] 1112692926.8263.125.camel@pegasus>
On Tue, Apr 05, 2005 at 11:22:06AM +0200, Marcel Holtmann wrote:
> I agree with Dmitry on this point. The IHEX parser should not be inside
> firmware_class.c. What about using keyspan_ihex.[ch] for it?
That's what I had originally, actually called firmware_ihex.ko, since
the IHEX format parser is not in any way keyspan specific and there are
several usb-serial converters that seem to use the same IHEX->.h trick
which could trivially be modified to use this loader.
But the compiled parser fairly small (< 2KB) and adding it to the
existing module didn't effectively add any size to the firmware_class
module since things are rounded to a page boundary anyways.
Jan
Reply to: