[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#748207: Function declaration without parameter type list shadows risk of stack underflow



Package: nabi
Version: 1.0.0-2
Severity: wishlist
Usertags: goto-cc

During an analysis of all packages using our research compiler tool-chain (using
tools from the cbmc package) the following error was found:

The declaration of nabi_log_get_level in debug.h

http://sources.debian.net/src/nabi/1.0.0-2/src/debug.h?hl=22#L22

shadows the fact that nabi_log_get_level actually requires an argument:

http://sources.debian.net/src/nabi/1.0.0-2/src/debug.c?hl=33#L33

Yet none is provided with any of the calls to nabi_log_get_level.

As, however, the argument isn't used code might execute correctly at present.
To avoid the risk of undefined behaviour, the definition should be fixed.

Best,
Michael

Attachment: pgp8aJ7bk9nU4.pgp
Description: PGP signature


Reply to: