[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Review of new English templates for scrcpy



On Fri, Aug 16, 2024 at 5:42 PM Justin B Rye <justin.byam.rye@gmail.com> wrote:
>
> Yangfl wrote:
> > I've added the attached new template to scrcpy. Please let me know if
> > you see issues in it and send us the corrections.
>
> Asking apt about the package scrcpy I find it's a tool for doing
> things with Android devices, though it's unclear exactly what
> (transferring files? resetting the clock? it could be anything).  The
> man page seems to be talking about encoding videos... but wait!
> Wikipedia gives a much clearer explanation.  Apparently scrcpy
> ("SCReen CoPY") is a screen mirroring tool (like a remote-desktop for
> a smartphone) that requires the Android device to be in a special
> debugging mode.  Okay...
>
> > Template: scrcpy/update_server
> > Type: boolean
> > Default: true
> > _Description: Auto update scrcpy server?
> >  Please specify whether you want to download scrcpy server from the Internet
> >  automatically, now and on every upgrade.
>
> I don't understand.  Where would I download new upgraded versions of
> scrcpy and scrcpy-server from if *not* the Internet?  Doesn't it go
> through the normal software repository system?  If not, why not?
>
> >  .
> >  scrcpy cannot work without the server binary.
>
> Well, that's okay, because it has a hard dependency on scrcpy-server.
> There's some kind of major element of missing context here.  Is it
> perhaps talking about software that needs to be installed onto the
> Android device via the Debian machine?

Ok, there is a major transition undergoing: scrcpy is moving to
contrib and scrcpy-server removing due to inability to build within
debian's android toolchain. So there is no scrcpy-server anymore.
Users have to use "scrcpy-server" binary directly from upstream now.

> >  .
> >  If you choose "Yes", installer will download and install the server binary now,
> >  and update it along with `scrcpy' upgrade. You have to have a decent toolkit to
> >  do that, e.g. `wget', `curl', `ca-certificates', etc.
>
> If it needs them, shouldn't it depend on them?  Or does it mean they
> need to be installed on the Android device?  (Wget *and* curl?)

They definitely need a downloader if they want the installer to
download the binary for them. I prefer not to make them hard
dependencies since users may want to use different methods to fetch
the server (via a custom network proxy for example). In these cases,
preselected downloaders may not be that useful.

> >  .
> >  If you choose "No", you will need to update the server yourself, located at
> >  `/usr/share/scrcpy/scrcpy-server'. A convenient script
> >  `/usr/libexec/scrcpy-update-server' is provided to do that. While scrcpy might
> >  work with an outdated server, you might encounter wired problems without
> >  getting any hint.
>
> Isn't the script for updating a Debian package meant to live in
> /var/lib/dpkg/info/packagename.{pre,post}inst?  If on the other hand
> I'm going to be running a non-Debian-packaged version, shouldn't it go
> in /usr/local?

The script for apt upgrading is still postinst. Commands for
downloading and cksumming are extracted into a seperate libexec script
so that they can be reused if users decide not to install it during
apt upgrading. I see msttcorefonts also installs 3rd binaries into
/usr/share.

> This all needs a lot more explanation.  I might be able to make you a
> clearer package description incorporating information from the
> Wikipedia entry, but for this template I'd need some extra hints.
>
> (There are also some English problems, like the misspelling "wired"
> for "weird", but they can wait until the content's sorted out.)
>
> >  .
> >  You can change your choice later with `sudo dpkg-reconfigure scrcpy'.
>
> Well, I understand this bit, so I can get right to the stage where I
> nitpick the punctuation.  Single quotes at both ends might make sense
> if you're emphasising that it's a verbatim string; backticks at both
> ends imply you're talking about the output of a sommandline.  But this
> is just a quoted command, so it should probably be double-quoted:
> "sudo dpkg-reconfigure scrcpy".
> --
> JBR     with qualifications in linguistics, experience as a Debian
>         sysadmin, and probably no clue about this particular package


Reply to: