Re: Review request: debconf templates for mrtg
Eriberto wrote:
> Thank you Justin for this very useful help. I will make all changes
> needed soon.
Hang on, I've just spotted a couple of errors in the second template:
+ By default MRTG writes all graph in the directory /var/www/html/mrtg/.
That should be "graphs".
+ However, this directory doesn't currently exist. The directory should be
+ owned by the user 'mrtg' user and group 'www-data', with recommended
Repeated "user" (also in the previous template).
+ permissions of 0750.
Revised diff attached
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- mrtg.templates.orig 2023-07-13 13:01:05.083477432 +0100
+++ mrtg.templates 2023-07-14 06:26:18.606623493 +0100
@@ -2,43 +2,40 @@
Type: boolean
Default: true
_Description: Move /etc/mrtg.cfg to /etc/mrtg/mrtg.cfg?
- Older versions of the MRTG on Debian had the /etc/mrtg.cfg configuration
- file. Currently, this file is located in /etc/mrtg/ directory, but there
- is a /etc/mrtg.cfg.
+ Older versions of MRTG on Debian had the configuration file /etc/mrtg.cfg.
+ This file should now be located in the directory /etc/mrtg/.
Template: mrtg/fix_permissions
Type: boolean
Default: true
_Description: Fix owner, group and permissions for /var/www/html/mrtg?
- By default MRTG writes all graphics in /var/www/html/mrtg/ directory. This
- directory is present at this moment, but it is insecure. Is needed to make
- this directory owned by 'mrtg' user and 'www-data' group. The recommended
- permission is 0750.
+ By default MRTG writes all graphs in the directory /var/www/html/mrtg/. This
+ directory currently exists, but it is insecure. The directory should be
+ owned by the user 'mrtg' and group 'www-data', with recommended permissions
+ of 0750.
Template: mrtg/create_www
Type: boolean
Default: true
_Description: Create /var/www/html/mrtg?
- By default MRTG writes all graphics in /var/www/html/mrtg/ directory. However,
- at this moment, this directory doesn't exist. Is also needed to make this
- directory owned by 'mrtg' user and 'www-data' group. The recommended
- permission is 0750.
+ By default MRTG writes all graphs in the directory /var/www/html/mrtg/.
+ However, this directory doesn't currently exist. The directory should be
+ owned by the user 'mrtg' and group 'www-data', with recommended permissions
+ of 0750.
.
- Alternatively, you can use another path for generated graphics. Note that
+ Alternatively, you can use another path for generated graphs. Note that
keeping this directory empty when using another path is not a problem.
Template: mrtg/remove_cron
Type: boolean
Default: true
_Description: Remove old and conflicting file /etc/cron.d/mrtg?
- MRTG no longer needs to use cron because it is starting on Debian via
- systemd/init.d scripts.
+ MRTG no longer needs to use cron because it is started via systemd
+ (or init.d scripts).
.
- Was found a file called /etc/cron.d/mrtg, that was installed from an old
- version of the MRTG. If kept, this file will make a duplicate work because
- MRTG now runs as a daemon, coordinated by systemd/init.d. Consequently, is
- strongly recommended to remove the cron file.
+ A file /etc/cron.d/mrtg exists, left behind by an old version of MRTG.
+ If kept, this file will cause duplicate work because MRTG now runs as a
+ daemon. It is therefore strongly recommended to remove the cron file.
.
- If this cron job is needed, consider to rename the file /etc/cron.d/mrtg
- (e.g. from /etc/cron.d/mrtg to /etc/cron.d/mrtg-custom) to avoid future
- warnings.
+ If this cron job is needed, consider renaming the file (e.g. from
+ /etc/cron.d/mrtg to /etc/cron.d/mrtg-custom) to avoid future warnings.
Reply to: