[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#980903: debhelper: doc-base doc-id deduplication does not work as documented with multiple "dh_installdocs -p<pkg>" calls; causes /usr/share/doc-base/<doc-id> to be installed multiple times



Hi Justin,

thanks for your prompt reply,

Justin B Rye wrote:
> > I've now added one paragraph to the POD of dh_installdocs:
> > 
> >   Please be aware that this deduplication currently only works if
> >   B<dh_installdocs> is called only once during the package build as
> >   deduplication is done in memory only. Especially calling
> >   B<dh_installdocs -p>I<package> in combination with using
> >   F<debian/>I<package>F<.doc-base.*> files can lead to uninstallable
> >   packages. See L<https://bugs.debian.org/980903> for details.
[…]
> It's grammatical and I believe it says what you need it to say,

Thanks!

> but I'd be happier with it if it had fewer uses of "only" per
> sentence...

Hehe, good point.

>     Please be aware that this deduplication is currently done in memory
>     only, so it requires B<dh_installdocs> to be called no more than
>     once during the package build. Calling B<dh_installdocs -p>I<package>
>     in combination with using F<debian/>I<package>F<.doc-base.*> files
>     can lead to uninstallable packages. See
>     L<https://bugs.debian.org/980903> for details.
> 
> (Is it still accurate with the "currently" relocated like this, or
> does it need to be before "requires"?)

My gut feeling says it's needed in both places. Would that be too
much? Would "so for now it requires" be an acceptable alternative to
using "currently" twice?

Context: I've prepared a patch which will hopefully fix this in the
future, but it's likely too invasive for bullseye. So this text will
be in there only until #980903 will be fixed properly.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: