Re: Please review knot-resolver debconf template
Santiago Ruano Rincón wrote:
> I am planning to add the attached template to knot-resolver. Could you
> please take a look at it?
Sure!
Okay, the good news is that I can expect anybody who has installed
knot-resolver to already know the technical background better than I
do, so I really do only need to check the English here.
> Template: knot-resolver/upgrade-buster-to-bullseye
> Type: note
> _Description: Upgrading from Knot Resolver < 5.x
> Knot Resolver configuration file requires manual upgrade.
> .
> Up to Knot Resolver 4.x, network interface bindings and service
> start were done by default via systemd sockets. These systemd sockets
> are no longer supported, and upgrading from a 3.x version (as in Debian
> Buster) requires manual action to (re)enable the service.
> .
> Please, refer to kresd.systemd(7) and to the
No need for a comma. (This is one of those odd uses of "please" where
we aren't begging for a favour, we're giving a helpful suggestion.)
> /usr/share/doc/knot-resolver/upgrading.html file (from
> knot-resolver-doc). An online version of the latter is available at
> https://knot-resolver.readthedocs.io/en/stable/upgrading.html#x-to-5-x
That URL would be rather annoying to have to note down, but
fortunately it's the first hit for "knot resolver upgrade" anyway.
> .
> For convenience, a suggested networking configuration can be found at
> the file: /var/lib/knot-resolver/.upgrade-4-to-5/kresd.conf.net
"At the file" is a bit odd here; I'd expect "in the file" (and then it
hardly needs a colon).
(Is that really a dotfile directory? Presumably it's new in the
incoming version?)
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- knot-resolver.templates.old 2020-07-29 13:08:55.733685141 +0100
+++ knot-resolver.templates.new 2020-07-29 13:10:23.175155212 +0100
@@ -8,10 +8,10 @@
are no longer supported, and upgrading from a 3.x version (as in Debian
Buster) requires manual action to (re)enable the service.
.
- Please, refer to kresd.systemd(7) and to the
+ Please refer to kresd.systemd(7) and to the
/usr/share/doc/knot-resolver/upgrading.html file (from
knot-resolver-doc). An online version of the latter is available at
https://knot-resolver.readthedocs.io/en/stable/upgrading.html#x-to-5-x
.
- For convenience, a suggested networking configuration can be found at
- the file: /var/lib/knot-resolver/.upgrade-4-to-5/kresd.conf.net
+ For convenience, a suggested networking configuration can be found in
+ the file /var/lib/knot-resolver/.upgrade-4-to-5/kresd.conf.net
Template: knot-resolver/upgrade-buster-to-bullseye
Type: note
_Description: Upgrading from Knot Resolver < 5.x
Knot Resolver configuration file requires manual upgrade.
.
Up to Knot Resolver 4.x, network interface bindings and service
start were done by default via systemd sockets. These systemd sockets
are no longer supported, and upgrading from a 3.x version (as in Debian
Buster) requires manual action to (re)enable the service.
.
Please refer to kresd.systemd(7) and to the
/usr/share/doc/knot-resolver/upgrading.html file (from
knot-resolver-doc). An online version of the latter is available at
https://knot-resolver.readthedocs.io/en/stable/upgrading.html#x-to-5-x
.
For convenience, a suggested networking configuration can be found in
the file /var/lib/knot-resolver/.upgrade-4-to-5/kresd.conf.net
Reply to: