[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: release-notes: small fixes to whats-new.dbk



Andrei POPESCU wrote:
> Of course it helps if I actually attache the patch :)

They look good to me, but I also see one other change to add:

> @@ -390,7 +390,7 @@ code.
>      &debian; &releasename; has <literal>AppArmor</literal> enabled per
>      default. <literal>AppArmor</literal> is a mandatory access control
>      framework that allows to restrict programs' capabilities like read,
                      ^^^^^^^^^
> -    write and execute permissions on files or mount, ptrace and signal
> +    write and execute permissions on files, or mount, ptrace and signal
>      permissions by defining per-program profiles.

You can allow actions (to occur) or allow users (to do things), but
allowing without a direct object isn't allowed.  And when we're
talking about a mechanism for *forbidding* things it's best to avoid
the word anyway!

While I'm rephrasing that I'll change everything else, too - avoid
"like" (these are examples, not an analogy), avoid implying that it
changes rwx "permissions" on files as such, shift the file access
part to simplify the grammar, and finally add "Oxford commas":

     framework for restricting programs' capabilities (such as mount, ptrace,
     and signal permissions, or file read, write, and execute access) by
     defining per-program profiles.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff --git a/en/whats-new.dbk b/en/whats-new.dbk
index 3f4bff15..720b45c7 100644
--- a/en/whats-new.dbk
+++ b/en/whats-new.dbk
@@ -153,7 +153,7 @@ linkend="obsolete"/>.
 
 <para>
   Besides, buster is the first Debian release to ship with Rust based programs
-  such as Firefox, ripgrep, fd, exa, etc and a significant number of
+  such as Firefox, ripgrep, fd, exa, etc. and a significant number of
   Rust based libraries (more than 450). Buster ships with Rustc 1.32.
 </para>
 
@@ -389,9 +389,9 @@ code.
   <para>
     &debian; &releasename; has <literal>AppArmor</literal> enabled per
     default. <literal>AppArmor</literal> is a mandatory access control
-    framework that allows to restrict programs' capabilities like read,
-    write and execute permissions on files or mount, ptrace and signal
-    permissions by defining per-program profiles.
+    framework for restricting programs' capabilities (such as mount, ptrace,
+    and signal permissions, or file read, write, and execute access) by
+    defining per-program profiles.
   </para>
   <para>
     The default <systemitem role="package">apparmor</systemitem> package
@@ -435,9 +435,9 @@ code.
     <literal>iptables</literal> command line interface. The nftables-based
     variant, using the <literal>nf_tables</literal> Linux kernel
     subsystem, is the default in buster. The legacy variant uses
-    the <literal>x_tables</literal> Linux kernel subsystem. Users can use the
-    update-alternatives system to select one variant or the other.
-  </para>
+    the <literal>x_tables</literal> Linux kernel subsystem. The
+    update-alternatives system can be used to select one variant or the other.
+</para>
   <para>
     This applies to all related tools and utilities:
     <itemizedlist>
@@ -473,7 +473,7 @@ code.
     improvements</ulink>.
   </para>
   <para>
-    This movement is in line with what other major Linux distributions are
+    This change is in line with what other major Linux distributions are
     doing, such as RedHat, which now uses <literal>nftables</literal> as its <ulink
     url="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8-beta/html-single/8.0_beta_release_notes/index#networking_2";>default
     firewalling tool</ulink>.
@@ -482,7 +482,7 @@ code.
     Also, please note that all <literal>iptables</literal> binaries are now
     installed in <literal>/usr/sbin</literal> instead of
     <literal>/sbin</literal>. A compatibility symlink is in place, but will be
-    dropped after the buster release cycle, so hardcoded binary paths
+    dropped after the buster release cycle. Hardcoded paths to the binaries
     in scripts will need to be corrected and are worth avoiding.
   </para>
   <para>

Reply to: