[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please review debconf template: ubuntu-keyring



Hideki Yamane wrote: 
>  Could you help me to review new ubuntu-keyring package's debconf
>  template? Attached below, or on salsa.debian.org at
>  https://salsa.debian.org/debian/ubuntu-keyring/blob/master/debian/po/templates.pot

It would be easier if I was starting from the ,templates file, but
here are some inline comments and corrections:
 
> # SOME DESCRIPTIVE TITLE.
> # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
> # This file is distributed under the same license as the ubuntu-keyring package.
> # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
> #
> #, fuzzy
> msgid ""
> msgstr ""
> "Project-Id-Version: ubuntu-keyring\n"
> "Report-Msgid-Bugs-To: ubuntu-keyring@packages.debian.org\n"
> "POT-Creation-Date: 2019-01-02 11:22+0900\n"
> "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
> "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
> "Language-Team: LANGUAGE <LL@li.org>\n"
> "Language: \n"
> "MIME-Version: 1.0\n"
> "Content-Type: text/plain; charset=CHARSET\n"
> "Content-Transfer-Encoding: 8bit\n"
> 
> #. Type: multiselect
> #. Description
> #: ../ubuntu-keyring.templates:1001 ../ubuntu-cloud-keyring.templates:1001
> #: ../ubuntu-dbgsym-keyring.templates:1001
> msgid "Which keyring is trusted GPG key used by apt to authenticate packages?"
> msgstr ""

Asking "which X is Y?" implies there can be only one; multiselect
implies I could give multiple answers; and the pedantic answer is to
select none of them, because no keyring is an individual key!  But if
this is a synopsis for a (multi)select prompt it shouldn't be a
question anyway.  Since it's also a bit long I'll try simplifying the
problem away:

  msgid "Trusted GPG keyring for package authentication:"

> #. Type: multiselect
> #. Description
> #: ../ubuntu-keyring.templates:1001
> msgid ""
> "If you want to use Ubuntu archive as same as Debian archive in some "
> "situation (e.g. chdist from devscripts package), you should enable ubuntu-"
> "keyring-*-archive as system trusted GPG key (and also ubuntu-archive-removed-"
> "keys for obsolete Ubuntu archive)."
> msgstr ""

"As same as" is ungrammatical; you want something along the lines of

  "If you want to use the Ubuntu archive in place of the Debian archive in "
  "some situation (e.g. chdist from the devscripts package), you should "
  "enable ubuntu-keyring-*-archive as a system trusted GPG key (and also "
  "ubuntu-archive-removed-keys for the obsolete Ubuntu archive)."

(I'm also adding some definite/indefinite articles where needed.)

> #. Type: multiselect
> #. Description
> #: ../ubuntu-keyring.templates:1001 ../ubuntu-cloud-keyring.templates:1001
> #: ../ubuntu-dbgsym-keyring.templates:1001
> msgid ""
> "However, note that adding those keyring as system trusted key is not "
> "necessary in most cases (just specify appropriate keyring via options) and "
> "may be a risk for your system."
> msgstr ""

  "However, note that adding these keyrings as system trusted keys is not "
  "necessary in most cases (just specify an appropriate keyring via options) "
  "and may be a risk for your system."

Or to avoid singling out Ubuntu as untrustworthy we could just say

  "However, note that adding keyrings as system trusted keys is not "
  "necessary in most cases (just specify an appropriate keyring via options) "
  "and may be a risk for your system."
 
> #. Type: multiselect
> #. Description
> #: ../ubuntu-cloud-keyring.templates:1001
> msgid ""
> "If you want to use Ubuntu archive as same as Debian archive in some "
> "situation (e.g. chdist from devscripts package), you should enable ubuntu-"
> "keyring-*-archive as system trusted GPG key (and also ubuntu-cloud-removed-"
> "keys for obsolete Ubuntu cloud archive)."
> msgstr ""

Shouldn't this talk about the "Ubuntu cloud archive"?  Maybe:

  "If you want to use the Ubuntu cloud archive in place of the Debian archive "
  "in some situation (e.g. chdist from the devscripts package), you should "
  "enable ubuntu-keyring-*-archive as a system trusted GPG key (and also "
  "ubuntu-cloud-removed-keys for the obsolete Ubuntu cloud archive)."
 
> #. Type: multiselect
> #. Description
> #: ../ubuntu-dbgsym-keyring.templates:1001
> msgid ""
> "If you want to use Ubuntu dbgsym archive as same as Debian dbgsym archive, "
> "you should enable ubuntu-keyring-*-dbgsym as system trusted GPG key (and "
> "also ubuntu-dbgsym-removed-keys for obsolete Ubuntu dbgsym archive)."
> msgstr ""
 
  "If you want to use the Ubuntu dbgsym archive in place of the Debian archive in "
  "some situation (e.g. chdist from the devscripts package), you should "
  "enable ubuntu-keyring-*-dbgsym as a system trusted GPG key (and also "
  "ubuntu-dbgsym-removed-keys for the obsolete Ubuntu dbgsym archive)."

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package


Reply to: