[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://unattended-upgrades/{templates}



Christian PERRIER wrote:
> I don't have changes to suggest. I kinda feel that the 2nd templates
> would benefit from being omre explicit or detailed, but I don't really
> find good ways to do so except by adding a very long and clumsy
> explanation. After all, the example that is in the default value is
> more or less self-explanatory.
> 
> I leave this up for review in icase someone else from the dle team
> (understand Justin) would have suggestions to give.

> Template: unattended-upgrades/enable_auto_updates
> Type: boolean
> Default: false
> _Description: Automatically download and install stable updates?
>  Applying updates on a frequent basis is an important part of keeping
>  systems secure. By default, updates need to be applied manually using package 
>  management tools. Alternatively, you can choose to have this system 
>  automatically download and install security updates.

It seems subtly cobwebby that this talks about "stable updates" when
what it means is security.debian.org, but leaves out any mention of
stable-updates (formerly known as volatile.debian.org) or
stable-backports (formerly known as backports.debian.org), which u-u
ignores by default.

Or, wait - in fact (according to the README) it'll *also* auto-install
new package versions that have gone into a stable point release, and
those usually include quite a lot of "miscellaneous" (i.e.
non-security-related) bugfixes.  For a start base-files always gets an
updated /etc/debian_version!

On the other hand, we definitely don't want users overwhelmed with
extra technicalities.  So maybe the last line should just have
something like s/security/important/?

(It's also a bit odd that this package defaults to doing nothing.  I
was taking it for granted that's needed because it's blindly pulled in
via dependencies from synaptic or GNOME or something, but that doesn't
seem to be true - as far as I can see anyone installing this package
on Debian can be assumed to want it activated...)

> Template: unattended-upgrades/origins_pattern
> Type: string
> Default: "origin=Debian,codename=${distro_codename},label=Debian-Security";
> _Description: Origins-Pattern that packages must match to be upgraded:
>  A package will be upgraded only if its metadata values match all the supplied
>  keywords in the origin line.

Perhaps this should feature an actual "do this!" line (including the
package's name):

 + Please specify a value for the unattended-upgrades Origins-Pattern.
 + .
   A package will be upgraded only if its metadata values match all the supplied
   keywords in the origin line.

I can't see anything to change in the package description.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru unattended-upgrades-0.86.4.pristine/debian/templates unattended-upgrades-0.86.4/debian/templates
--- unattended-upgrades-0.86.4.pristine/debian/templates	2015-10-05 17:17:43.000000000 +0100
+++ unattended-upgrades-0.86.4/debian/templates	2015-10-16 11:42:56.489029167 +0100
@@ -14,11 +14,13 @@
  Applying updates on a frequent basis is an important part of keeping
  systems secure. By default, updates need to be applied manually using package 
  management tools. Alternatively, you can choose to have this system 
- automatically download and install security updates.
+ automatically download and install important updates.
 
 Template: unattended-upgrades/origins_pattern
 Type: string
 Default: "origin=Debian,codename=${distro_codename},label=Debian-Security";
 _Description: Origins-Pattern that packages must match to be upgraded:
+ Please specify a value for the unattended-upgrades Origins-Pattern.
+ .
  A package will be upgraded only if its metadata values match all the supplied
  keywords in the origin line.
Source: unattended-upgrades
Section: admin
Priority: optional
Maintainer: Michael Vogt <mvo@debian.org>
Build-Depends: debhelper (>= 7.0.50~), po-debconf
Build-Depends-Indep: python (>= 2.6.6-3~), python3-distutils-extra,
 python3-setuptools, python-dev, python3-dev, python-coverage, pep8,
 pyflakes, python-apt, python3-apt, python-mock, python3-mock,
 lsb-release, dh-systemd (>= 1.5)
Standards-Version: 3.9.3
Vcs-Git: https://github.com/mvo5/unattended-upgrades.git
XS-Testsuite: autopkgtest

Package: unattended-upgrades
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}, debconf, python3, 
 python3-apt, apt-utils, apt, ucf, lsb-release, lsb-base (>= 3.2-14),
 xz-utils
Recommends: cron | cron-daemon | anacron
Suggests: bsd-mailx, mail-transport-agent
Description: automatic installation of security upgrades
 This package can download and install security upgrades automatically
 and unattended, taking care to only install packages from the
 configured APT source, and checking for dpkg prompts about
 configuration file changes.
 .
 This script is the backend for the APT::Periodic::Unattended-Upgrade
 option.
# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# debian-l10n-english@lists.debian.org for advice.
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: unattended-upgrades/enable_auto_updates
Type: boolean
Default: false
_Description: Automatically download and install stable updates?
 Applying updates on a frequent basis is an important part of keeping
 systems secure. By default, updates need to be applied manually using package 
 management tools. Alternatively, you can choose to have this system 
 automatically download and install important updates.

Template: unattended-upgrades/origins_pattern
Type: string
Default: "origin=Debian,codename=${distro_codename},label=Debian-Security";
_Description: Origins-Pattern that packages must match to be upgraded:
 Please specify a value for the unattended-upgrades Origins-Pattern.
 .
 A package will be upgraded only if its metadata values match all the supplied
 keywords in the origin line.

Reply to: