Re: [RFR] templates://xringd/{templates}
Christian PERRIER wrote:
> Your review should be sent as an answer to this mail.
[...]
> Rationale:
> --- xringd.old/debian/templates 2015-08-20 15:20:51.741782838 +0200
> +++ xringd/debian/templates 2015-09-07 07:03:27.209880278 +0200
> @@ -1,7 +1,9 @@
> Template: xringd/modem-device
> Type: string
> Default: /dev/ttyS0
> -_Description: Device your modem is connected to:
> - Xringd needs to poll a modem, which connects to your machine via a serial
> - port. Please enter which serial port (usually /dev/ttyS[0-4]) your modem
> - is connected to.
> +_Description: Modem device:
> + Please enter the name of the device that has a modem connected.
> + .
> + Xringd needs to poll a modem, generally connected to the machine
> + through a serial port. Please enter which serial port (usually
> + /dev/ttyS[0-4]) this machine's modem is connected to.
>
> I'm not entirely happy with this proposal. The point is to avoid
> "your", as we always do, on the rationale that the peson installing
> packages is not always the machine's owner.
>
> Still, I find that my proposal is clumsy and I feel like Justin will
> be able to propose seomthing better..:-)
Is xringd capable of monitoring anything other than a serial port?
Compare the package description; when it says it "needs to poll a
modem, which connects to your machine via a serial port" (descriptive
relative clause) I suspect it might mean that it "needs to poll a
modem which connects to your machine via a serial port" (restrictive
relative clause).
Or maybe all it means by that is "not an internal winmodem"? Given
that xringd last saw upstream development in mid-1997 (and the package
was in Debian Buzz!) we can't really expect the documentation to have
been written with USB dongle connections in mind... it's conceivable
that pointing at the appropriate device file might work for those,
too. For now I'll assume it really does have to be a serial port - if
I'm wrong, the package description needs an update too.
_Description: Modem device:
Please enter the name of the device the modem is connected to.
.
Xringd needs to poll a modem attached via a serial port. Please
specify which serial port the modem uses (usually /dev/ttyS[0-4]).
Meanwhile in the package description:
> Package: xringd
> Architecture: any
> Depends: ${shlibs:Depends}, ${misc:Depends}, debianutils (>= 1.7)
> Description: extended ring daemon - monitor phone rings and take action
> xringd will monitor a serial line for RING signals and activate various
> commands when specific "ring-delay sequences" are detected.
The only thing that I wonder about here is why "RING" is capitalised.
But googling forums I see people did talk about modem devices
receiving "RING events", so who knows, maybe telephone RINGs are so
called because they're Random Interval Noise Generators.
(Checks popcon... oh, it gets one vote! So it's not dead yet...)
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
diff -ru xringd-1.20.pristine/debian/templates xringd-1.20/debian/templates
--- xringd-1.20.pristine/debian/templates 2015-08-20 15:42:11.000000000 +0100
+++ xringd-1.20/debian/templates 2015-09-07 10:43:27.059180420 +0100
@@ -1,7 +1,8 @@
Template: xringd/modem-device
Type: string
Default: /dev/ttyS0
-_Description: Device your modem is connected to:
- Xringd needs to poll a modem, which connects to your machine via a serial
- port. Please enter which serial port (usually /dev/ttyS[0-4]) your modem
- is connected to.
+_Description: Modem device:
+ Please enter the name of the device the modem is connected to.
+ .
+ Xringd needs to poll a modem attached via a serial port. Please
+ specify which serial port the modem uses (usually /dev/ttyS[0-4]).
Template: xringd/modem-device
Type: string
Default: /dev/ttyS0
_Description: Modem device:
Please enter the name of the device the modem is connected to.
.
Xringd needs to poll a modem attached via a serial port. Please
specify which serial port the modem uses (usually /dev/ttyS[0-4]).
Source: xringd
Section: comm
Priority: extra
Maintainer: Steve Kowalik <stevenk@debian.org>
Standards-Version: 3.9.5
Build-Depends: debhelper (>= 9)
Package: xringd
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debianutils (>= 1.7)
Description: extended ring daemon - monitor phone rings and take action
xringd will monitor a serial line for RING signals and activate various
commands when specific "ring-delay sequences" are detected.
Reply to: