[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#793937: [LCFC2] templates://libdvd-pkg/{templates}



Dmitry Smirnov wrote:
> The only thing which makes me feel uncomfortable about this version is
> "doing downloads" in
> 
>  This package automates the process of doing downloads of the source
>  files for ${PKGG} from videolan.org, compiling them, and installing the
>  binary packages (${PKGG_ALL}).

Hmm, "do" can often be a bit weak, if that's what you mean...
 
> I suggest re-writing as
> 
>  This package automates the process of downloading of the source files for
>  ${PKGG} from videolan.org, compiling them and installing the
>  binary deb packages (${PKGG_ALL}).

That has an excess "of (the)", and it loses the plural instances of
downloads (plural runs automatically produce plural output packages,
so you can recycle this text for other downloaders regardless of how
many packages they produce per run).  Oh, and you've lost a Harvard
comma again and put the "deb" back in after I thought we'd agreed to
take it out!

Would you be any happier with a version that just replaces "doing"
with something less weak, like "performing" or "launching"?

   This package automates the process of launching downloads of the source
   files for ${PKGG} from videolan.org, compiling them, and installing the
   binary packages (${PKGG_ALL}).

(Revised patch attached)
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru libdvd-pkg-1.3.99-1.pristine/debian/control libdvd-pkg-1.3.99-1/debian/control
--- libdvd-pkg-1.3.99-1.pristine/debian/control	2015-04-14 02:47:06.000000000 +0100
+++ libdvd-pkg-1.3.99-1/debian/control	2015-08-23 22:25:32.002037000 +0100
@@ -16,7 +16,8 @@
         ,${guest:Build-Depends}
 Recommends: ${guest:Recommends} ,libcap2-bin
 Suggests: ${guest:Suggests}
-Description: download and install software necessary to play video DVDs
- This package fetches, compiles from source code and installs library
- packages that are necessary to play all video DVDs with media
- player of your choice (like VLC, SMplayer, Totem, etc.).
+Description: DVD-Video playing library - installer
+ This package provides libraries that are needed for playing video DVDs
+ with a media player (such as VLC, SMplayer, Totem, etc.). It automates
+ the process of downloading source files, compiling them, and installing
+ the binary packages.
diff -ru libdvd-pkg-1.3.99-1.pristine/debian/templates libdvd-pkg-1.3.99-1/debian/templates
--- libdvd-pkg-1.3.99-1.pristine/debian/templates	2014-12-17 03:00:49.000000000 +0000
+++ libdvd-pkg-1.3.99-1/debian/templates	2015-08-23 22:29:10.904209938 +0100
@@ -1,60 +1,66 @@
 Template: libdvd-pkg/first-install
 Type: note
 _Description:
- This package downloads the ${PKGG} source files from videolan.org,
- compile them and install the binary deb package(s)
- [${PKGG_ALL}].
+ This package automates the process of launching downloads of the source
+ files for ${PKGG} from videolan.org, compiling them, and installing the
+ binary packages (${PKGG_ALL}).
  .
- Please remember to run "sudo dpkg-reconfigure ${PKGI}"
- to build and install guest package(s) for the first time.
+ Please run "sudo dpkg-reconfigure ${PKGI}" to launch this process for
+ the first time.
 
 Template: libdvd-pkg/title_b-i
 Type: title
-_Description: Build and install ${PKGG}${VER}
+_Description: Download, build and install ${PKGG}${VER}
 
 Template: libdvd-pkg/build
 Type: boolean
 Default: true
-_Description: Proceed with downloading and compiling ${PKGG}${VER}?
- The installation process is therefore about to download the source files
- from videolan.org, compile them, and install the binary deb package(s)
- [${PKGG_ALL}].
+_Description: Download, build, and install ${PKGG}${VER}?
+ This package automates the process of launching downloads of the source
+ files for ${PKGG} from videolan.org, compiling them, and installing the
+ binary packages (${PKGG_ALL}).
  .
  Please confirm whether you wish this to happen.
 
 Template: libdvd-pkg/title_u
 Type: title
-_Description: Upgrades available for guest package(s)
+_Description: Upgrade available for ${PKGG}
 
 Template: libdvd-pkg/upgrade
 Type: note
 _Description:
- An update to guest package(s) [${PKGG_ALL}] version ${VER} is available
- but automatic upgrade is disabled.
+ This package automates the process of launching downloads of the source
+ files for ${PKGG} from videolan.org, compiling them, and installing the
+ binary packages (${PKGG_ALL}).
  .
- Please remember to run "sudo dpkg-reconfigure ${PKGI}" to build and
- install guest package(s) or consider installing the APT post-invoke hook.
+ An update to version ${VER} is available, but automatic upgrades are
+ disabled.
+ .
+ Please run "sudo dpkg-reconfigure ${PKGI}" to launch this process
+ manually and/or activate automatic upgrades in future.
 
 Template: libdvd-pkg/post-invoke_hook-install
 Type: boolean
 Default: true
-_Description: Install APT post-invoke hook?
+_Description: Enable automatic upgrades for ${PKGG}?
  If activated, the APT post-invoke hook takes care of future automatic
- upgrades of guest package(s) on host package upgrade. When an update
- is available, the hook will attempt to download and build the package(s),
- and (if "apt-get check" reports no errors) install them with "dpkg -i".
+ upgrades of ${PKGG} (which may be triggered by new versions of
+ ${PKGI}). When updates are available, the hook will launch the
+ process of downloading the source, recompiling it, and (if "apt-get check"
+ reports no errors) using "dpkg -i" to install the new versions.
  .
- Alternatively, guest package(s) can be built by manual invocation of
- "dpkg-reconfigure ${PKGI}".
+ Alternatively, the process can be launched manually by running
+ "sudo dpkg-reconfigure ${PKGI}".
 
 Template: libdvd-pkg/post-invoke_hook-remove
 Type: boolean
 Default: false
-_Description: Remove APT post-invoke hook?
+_Description: Disable automatic upgrades for ${PKGG}?
  If activated, the APT post-invoke hook takes care of future automatic
- upgrades of guest package(s) on host package upgrade. When an update
- is available, the hook will attempt to download and build the package(s),
- and (if "apt-get check" reports no errors) install them with "dpkg -i".
+ upgrades of ${PKGG} (which may be triggered by new versions of
+ ${PKGI}). When updates are available, the hook will launch the
+ process of downloading the source, recompiling it, and (if "apt-get check"
+ reports no errors) using "dpkg -i" to install the new versions.
  .
- Alternatively, guest package(s) can be built by manual invocation of
- "dpkg-reconfigure ${PKGI}".
+ Alternatively, the process can be launched manually by running
+ "sudo dpkg-reconfigure ${PKGI}".
Template: libdvd-pkg/first-install
Type: note
_Description:
 This package automates the process of launching downloads of the source
 files for ${PKGG} from videolan.org, compiling them, and installing the
 binary packages (${PKGG_ALL}).
 .
 Please run "sudo dpkg-reconfigure ${PKGI}" to launch this process for
 the first time.

Template: libdvd-pkg/title_b-i
Type: title
_Description: Download, build and install ${PKGG}${VER}

Template: libdvd-pkg/build
Type: boolean
Default: true
_Description: Download, build, and install ${PKGG}${VER}?
 This package automates the process of launching downloads of the source
 files for ${PKGG} from videolan.org, compiling them, and installing the
 binary packages (${PKGG_ALL}).
 .
 Please confirm whether you wish this to happen.

Template: libdvd-pkg/title_u
Type: title
_Description: Upgrade available for ${PKGG}

Template: libdvd-pkg/upgrade
Type: note
_Description:
 This package automates the process of launching downloads of the source
 files for ${PKGG} from videolan.org, compiling them, and installing the
 binary packages (${PKGG_ALL}).
 .
 An update to version ${VER} is available, but automatic upgrades are
 disabled.
 .
 Please run "sudo dpkg-reconfigure ${PKGI}" to launch this process
 manually and/or activate automatic upgrades in future.

Template: libdvd-pkg/post-invoke_hook-install
Type: boolean
Default: true
_Description: Enable automatic upgrades for ${PKGG}?
 If activated, the APT post-invoke hook takes care of future automatic
 upgrades of ${PKGG} (which may be triggered by new versions of
 ${PKGI}). When updates are available, the hook will launch the
 process of downloading the source, recompiling it, and (if "apt-get check"
 reports no errors) using "dpkg -i" to install the new versions.
 .
 Alternatively, the process can be launched manually by running
 "sudo dpkg-reconfigure ${PKGI}".

Template: libdvd-pkg/post-invoke_hook-remove
Type: boolean
Default: false
_Description: Disable automatic upgrades for ${PKGG}?
 If activated, the APT post-invoke hook takes care of future automatic
 upgrades of ${PKGG} (which may be triggered by new versions of
 ${PKGI}). When updates are available, the hook will launch the
 process of downloading the source, recompiling it, and (if "apt-get check"
 reports no errors) using "dpkg -i" to install the new versions.
 .
 Alternatively, the process can be launched manually by running
 "sudo dpkg-reconfigure ${PKGI}".
Source: libdvd-pkg
Section: contrib/utils
Priority: optional
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers@lists.alioth.debian.org>
Uploaders: Dmitry Smirnov <onlyjob@debian.org>
Standards-Version: 3.9.6
Build-Depends: debhelper (>= 9)
Vcs-Browser: http://anonscm.debian.org/cgit/pkg-multimedia/libdvd-pkg.git
Vcs-Git: git://anonscm.debian.org/pkg-multimedia/libdvd-pkg.git

Package: libdvd-pkg
Architecture: all
Provides: ${guest:Provides}
Depends: ${misc:Depends} ,build-essential
        ,wget | devscripts
        ,${guest:Build-Depends}
Recommends: ${guest:Recommends} ,libcap2-bin
Suggests: ${guest:Suggests}
Description: DVD-Video playing library - installer
 This package provides libraries that are needed for playing video DVDs
 with a media player (such as VLC, SMplayer, Totem, etc.). It automates
 the process of downloading source files, compiling them, and installing
 the binary packages.

Reply to: