[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://openstreetmap-carto/{templates}

Christian PERRIER wrote:
> Rationale:
> --- openstreetmap-carto.old/debian/templates	2015-07-29 08:21:00.137809322 +0200
> +++ openstreetmap-carto/debian/templates	2015-08-08 08:26:44.035687192 +0200
> @@ -1,14 +1,18 @@
>  Template: openstreetmap-carto/fetch-data
>  Type: boolean
> +_Description: Download OpenStreetMap data files from the Internet?
> + The openstreetmap-carto stylesheet uses several data files that must
> + be downloaded from the Internet. 
> + .
> + If you choose not to do this now, it can be done manually later
> + by running the "get-shapefiles.sh" script in the /usr/share/openstreetmap-carto
>   directory.
> Split in two paragraphs for readability.
> I'm not fond of "from the web" and prefer "from the Internet"

As always, the missing element in the installer package's
documentation is "why is this an installer and not just an ordinary
package?" - an especially mysterious question when it's in main.
Should we be including warning hints such as the word "multigigabyte"?
>  Template: openstreetmap-carto/database-name
>  Type: string
>  Default: gis
> +_Description: PostgreSQL database name:
> + The openstreetmap-carto stylesheet uses a PostgreSQL database to
> + store OpenStreetMap data.
> + .
> + Please choose the name for this database.

I hope it's not just that my brain's exhausted from the last one, but
this already looks good to me.

Even the package description:

> Package: openstreetmap-carto
> Description: standard OpenStreetMap Mapnik stylesheet
>  This package provides the standard OpenStreetMap stylesheet for Mapnik, built
>  from the CartoCSS source. It also provides the necessary icons, and the script
>  to download the necessary shapefiles.
>  .
>  This package does not provide a tileserver, or perform tile rendering.

As I say, I'd be interested to know *why* the shapefiles have to be
downloaded from the Internet, but apart from that I don't actually
have any changes to suggest!
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package

Reply to: