Please find, for review, the debconf templates and packages descriptions for the publicfile-installer source package.
This review will last from Saturday, August 08, 2015 to Tuesday, August 18, 2015.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- publicfile-installer.old/debian/templates 2015-07-29 08:21:48.490182705 +0200
+++ publicfile-installer/debian/templates 2015-07-29 13:44:58.140605903 +0200
@@ -1,13 +1,16 @@
Template: publicfile-installer/build
Type: boolean
Default: false
-_Description: Do you want to get and build publicfile now?
- Choose wether publicfile should be downloaded and build now.
+_Description: Download and build publicfile now?
Matter of taste, but I usually tend to avoid "do you want <foo>"
+ Please choose wether publicfile should be downloaded and built now.
+ .
We often use "Please <foo>" so let's be consistent among packages?
If you choose not to do this now, you can perform the actions manually later,
- by running the 'get-publicfile' command (as a normal user, not root) and
+ by running the "get-publicfile" command (as an unprivileged user, not
+ as root) and
following the instructions.
The debian-l10n-english housestyle uses double quptes rather than
simple quotes.... We also tend to suggest using
privileged/unprivileged instead of "normal".
.
- If you choose to get and build now, both these actions will be performed
- as root. For security-aware sites, this might be not appropriate.
- Once the software has been build, run the 'install-publicfile' command
+ If you choose to download and build publicfile now, both these actions will be performed
+ as root. For security-aware sites, this might be not appropriate.
+ .
+ Once the software has been built, run the "install-publicfile" command
(as root) to install the package.
Be consistent with other changes.
--- publicfile-installer.old/debian/control 2015-07-29 08:21:48.490182705 +0200
+++ publicfile-installer/debian/control 2015-08-08 08:29:31.921329907 +0200
@@ -10,10 +10,10 @@
Package: publicfile-installer
Architecture: all
Depends: wget, debhelper, fakeroot, ${misc:Depends}
-Description: installer package for the publicfile http and ftp server
- Publicfile is a http and ftp server, written by Daniel J. Bernstein in
- 1999; it didn't change a lot after that. Modern features are not
- supported. However, if you're looking for a small, simple and secure
+Description: installer package for the publicfile HTTP and FTP server
+ Publicfile is an HTTP and FTP server, written by Daniel J. Bernstein in
+ 1999; it didn't change a lot after that. Modern features are not
+ supported. However, if you're looking for a small, simple and secure
webserver, which integrates with the runit and daemontools UNIX service
managers, publicfile will suit your needs.
.
Capitalize HTTP ad FTP
--
Template: publicfile-installer/build Type: boolean Default: false _Description: Download and build publicfile now? Please choose wether publicfile should be downloaded and built now. . If you choose not to do this now, you can perform the actions manually later, by running the "get-publicfile" command (as an unprivileged user, not as root) and following the instructions. . If you choose to download and build publicfile now, both these actions will be performed as root. For security-aware sites, this might be not appropriate. . Once the software has been built, run the "install-publicfile" command (as root) to install the package.
--- publicfile-installer.old/debian/templates 2015-07-29 08:21:48.490182705 +0200
+++ publicfile-installer/debian/templates 2015-07-29 13:44:58.140605903 +0200
@@ -1,13 +1,16 @@
Template: publicfile-installer/build
Type: boolean
Default: false
-_Description: Do you want to get and build publicfile now?
- Choose wether publicfile should be downloaded and build now.
+_Description: Download and build publicfile now?
+ Please choose wether publicfile should be downloaded and built now.
+ .
If you choose not to do this now, you can perform the actions manually later,
- by running the 'get-publicfile' command (as a normal user, not root) and
+ by running the "get-publicfile" command (as an unprivileged user, not
+ as root) and
following the instructions.
.
- If you choose to get and build now, both these actions will be performed
- as root. For security-aware sites, this might be not appropriate.
- Once the software has been build, run the 'install-publicfile' command
+ If you choose to download and build publicfile now, both these actions will be performed
+ as root. For security-aware sites, this might be not appropriate.
+ .
+ Once the software has been built, run the "install-publicfile" command
(as root) to install the package.
--- publicfile-installer.old/debian/control 2015-07-29 08:21:48.490182705 +0200
+++ publicfile-installer/debian/control 2015-08-08 08:29:31.921329907 +0200
@@ -10,10 +10,10 @@
Package: publicfile-installer
Architecture: all
Depends: wget, debhelper, fakeroot, ${misc:Depends}
-Description: installer package for the publicfile http and ftp server
- Publicfile is a http and ftp server, written by Daniel J. Bernstein in
- 1999; it didn't change a lot after that. Modern features are not
- supported. However, if you're looking for a small, simple and secure
+Description: installer package for the publicfile HTTP and FTP server
+ Publicfile is an HTTP and FTP server, written by Daniel J. Bernstein in
+ 1999; it didn't change a lot after that. Modern features are not
+ supported. However, if you're looking for a small, simple and secure
webserver, which integrates with the runit and daemontools UNIX service
managers, publicfile will suit your needs.
.
Source: publicfile-installer
Section: contrib/net
Priority: extra
Maintainer: Joost van Baal-Ilić <joostvb@debian.org>
Build-Depends: debhelper (>= 9), po-debconf
Standards-Version: 3.9.6
Vcs-Git: git://anonscm.debian.org/collab-maint/publicfile-installer.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/publicfile-installer.git
Package: publicfile-installer
Architecture: all
Depends: wget, debhelper, fakeroot, ${misc:Depends}
Description: installer package for the publicfile HTTP and FTP server
Publicfile is an HTTP and FTP server, written by Daniel J. Bernstein in
1999; it didn't change a lot after that. Modern features are not
supported. However, if you're looking for a small, simple and secure
webserver, which integrates with the runit and daemontools UNIX service
managers, publicfile will suit your needs.
.
This installer package downloads the publicfile .tar.gz file from
the upstream website, combines it with Debian packaging information
from the package maintainer's website; then builds a publicfile Debian
package, and installs that. When installing this installer package,
one is given the option to postpone downloading and installing
publicfile.
Attachment:
signature.asc
Description: Digital signature