[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://diaspora-installer/{templates}



Please find, for review, the debconf templates and packages descriptions for the diaspora-installer source package.

This review will last from Saturday, March 14, 2015 to Tuesday, March 24, 2015.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- diaspora-installer.old/debian/templates	2015-03-06 07:50:19.213783515 +0100
+++ diaspora-installer/debian/templates	2015-03-10 07:15:48.603862559 +0100
@@ -1,12 +1,15 @@
 Template: diaspora-installer/url
 Type: string
 Default: localhost
-_Description: hostname for your diaspora instance:
- Set the hostname of the machine you're running Diaspora on, as seen
- from the internet. This should be the domain name you want to use to
- access the pod. So if you plan to use a reverse proxy, it should be
- the hostname the proxy listens on. DO NOT CHANGE THIS AFTER INITIAL SETUP!
- If you do change the hostname, you will have to start again as the hostname
- will be hardcoded into the database.
+_Description: Host name for this instance of Diaspora:
+ Please choose the host name which should be used to access this
+ instance of Diaspora.
  .
- Examples: example.com, pod.example.com etc
+ This should be the fully qualified name needed by users in order
+ to access the pod.
+ .
+ If a reverse proxy is used, this should then be
+ the hostname used by the proxy server.
+ .
+ This host name should not be modified after the initial setup because
+ it is hardcoded in the database.

Many small changes:
- avoid "your" diaspora instance. Even in the case of Diaspora, this
is likely to be the case.....this is something we usually avoid in
debconf templates

- use the "Please <foo>" construction which is also something we
usually recommend in debconf templates

- then split in several paragraphs for readability


--- diaspora-installer.old/debian/control	2015-03-06 07:50:19.213783515 +0100
+++ diaspora-installer/debian/control	2015-03-10 07:17:01.385387610 +0100
@@ -51,9 +51,9 @@
  which is being built on Ruby on Rails, is free software and can be
  experimented with by external developers.
  .
- Learn more about diaspora at http://diasporafoundation.org
+ Learn more about Diaspora at http://diasporafoundation.org
  .
- This package helps install diaspora using rubygems.
+ This package helps to install Diaspora using rubygems.
 
 Package: diaspora-common
 Architecture: all
@@ -93,6 +93,6 @@
  which is being built on Ruby on Rails, is free software and can be
  experimented with by external developers.
  .
- Learn more about diaspora at http://diasporafoundation.org
+ Learn more about Diaspora at http://diasporafoundation.org
  .
- This package provides files common between diaspora and diaspora-installer.
+ This package provides common for the diaspora and diaspora-installer packages.

Standardise on capitalized "Diaspora".



-- 


Template: diaspora-installer/url
Type: string
Default: localhost
_Description: Host name for this instance of Diaspora:
 Please choose the host name which should be used to access this
 instance of Diaspora.
 .
 This should be the fully qualified name needed by users in order
 to access the pod.
 .
 If a reverse proxy is used, this should then be
 the hostname used by the proxy server.
 .
 This host name should not be modified after the initial setup because
 it is hardcoded in the database.
--- diaspora-installer.old/debian/templates	2015-03-06 07:50:19.213783515 +0100
+++ diaspora-installer/debian/templates	2015-03-10 07:15:48.603862559 +0100
@@ -1,12 +1,15 @@
 Template: diaspora-installer/url
 Type: string
 Default: localhost
-_Description: hostname for your diaspora instance:
- Set the hostname of the machine you're running Diaspora on, as seen
- from the internet. This should be the domain name you want to use to
- access the pod. So if you plan to use a reverse proxy, it should be
- the hostname the proxy listens on. DO NOT CHANGE THIS AFTER INITIAL SETUP!
- If you do change the hostname, you will have to start again as the hostname
- will be hardcoded into the database.
+_Description: Host name for this instance of Diaspora:
+ Please choose the host name which should be used to access this
+ instance of Diaspora.
  .
- Examples: example.com, pod.example.com etc
+ This should be the fully qualified name needed by users in order
+ to access the pod.
+ .
+ If a reverse proxy is used, this should then be
+ the hostname used by the proxy server.
+ .
+ This host name should not be modified after the initial setup because
+ it is hardcoded in the database.
--- diaspora-installer.old/debian/control	2015-03-06 07:50:19.213783515 +0100
+++ diaspora-installer/debian/control	2015-03-10 07:17:01.385387610 +0100
@@ -51,9 +51,9 @@
  which is being built on Ruby on Rails, is free software and can be
  experimented with by external developers.
  .
- Learn more about diaspora at http://diasporafoundation.org
+ Learn more about Diaspora at http://diasporafoundation.org
  .
- This package helps install diaspora using rubygems.
+ This package helps to install Diaspora using rubygems.
 
 Package: diaspora-common
 Architecture: all
@@ -93,6 +93,6 @@
  which is being built on Ruby on Rails, is free software and can be
  experimented with by external developers.
  .
- Learn more about diaspora at http://diasporafoundation.org
+ Learn more about Diaspora at http://diasporafoundation.org
  .
- This package provides files common between diaspora and diaspora-installer.
+ This package provides common for the diaspora and diaspora-installer packages.
Source: diaspora-installer
Section: ruby
Priority: optional
Maintainer: Debian Ruby Extras Maintainers <pkg-ruby-extras-maintainers@lists.alioth.debian.org>
Uploaders: Pirate Praveen <praveen@debian.org>
Build-Depends: debhelper (>= 9), gem2deb (>= 0.7.5~), po-debconf
Standards-Version: 3.9.6
Vcs-Git: git://anonscm.debian.org/pkg-ruby-extras/diaspora-installer.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/diaspora-installer.git;a=summary
Homepage: http://wiki.debian.org/Diaspora
XS-Ruby-Versions: all

Package: diaspora-installer
Architecture: all
XB-Ruby-Versions: ${ruby:Versions}
Pre-Depends: postgresql-client, dbconfig-common, adduser
Depends: ${shlibs:Depends}, ${misc:Depends}, ruby | ruby-interpreter,
 diaspora-common,
 nodejs,
 curl,
 postgresql,
 redis-server,
 sudo,
 ruby-rspec,
 bundler,
 ruby-dev,
 libpq-dev,
 build-essential,
 libssl-dev,
 libcurl4-openssl-dev,
 libxml2-dev,
 libxslt-dev,
 imagemagick,
 ghostscript,
 libmagickwand-dev,
 net-tools,
 nginx
Conflicts: diaspora
Replaces: diaspora
Description: distributed social networking service - installer
 Diaspora (currently styled diaspora* and formerly styled DIASPORA*) is a free
 personal web server that implements a distributed social networking service.
 Installations of the software form nodes (termed "pods") which make up the
 distributed Diaspora social network.
 .
 Diaspora is intended to address privacy concerns related to centralized
 social networks by allowing users set up their own server (or "pod") to
 host content; pods can then interact to share status updates, photographs,
 and other social data. It allows its users to host their data with a
 traditional web host, a cloud-based host, an ISP, or a friend. The framework,
 which is being built on Ruby on Rails, is free software and can be
 experimented with by external developers.
 .
 Learn more about Diaspora at http://diasporafoundation.org
 .
 This package helps to install Diaspora using rubygems.

Package: diaspora-common
Architecture: all
XB-Ruby-Versions: ${ruby:Versions}
Pre-Depends: postgresql-client, dbconfig-common, adduser
Depends: ${shlibs:Depends}, ${misc:Depends}, ruby | ruby-interpreter,
 nodejs,
 curl,
 postgresql,
 redis-server,
 sudo,
 ruby-rspec,
 bundler,
 ruby-dev,
 libpq-dev,
 build-essential,
 libssl-dev,
 libcurl4-openssl-dev,
 libxml2-dev,
 libxslt-dev,
 imagemagick,
 ghostscript,
 libmagickwand-dev,
 net-tools,
 nginx
Description: distributed social networking service - common files
 Diaspora (currently styled diaspora* and formerly styled DIASPORA*) is a free
 personal web server that implements a distributed social networking service.
 Installations of the software form nodes (termed "pods") which make up the
 distributed Diaspora social network.
 .
 Diaspora is intended to address privacy concerns related to centralized
 social networks by allowing users set up their own server (or "pod") to
 host content; pods can then interact to share status updates, photographs,
 and other social data. It allows its users to host their data with a
 traditional web host, a cloud-based host, an ISP, or a friend. The framework,
 which is being built on Ruby on Rails, is free software and can be
 experimented with by external developers.
 .
 Learn more about Diaspora at http://diasporafoundation.org
 .
 This package provides common for the diaspora and diaspora-installer packages.

Attachment: signature.asc
Description: Digital signature


Reply to: