[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://debian-security-support/{debian-security-support.templates}



Christian PERRIER wrote:
>> I gather this template text is echoed by runtime messages from
>> binaries in the package (since there's a messages.po with the same
>> grammar problem).  Should I give you a patch for that too?
> 
> Would be a good idea, yes. Same for the manpage.

I may be doing this wrong, but I attach a message-phrasing patch for
the Bash script itself (on the assumption that the .po file just gets
generated from it).
 
And the check-support-status.txt file, which I gather is asciidoc
source for the man page:

> CHECK-SUPPORT-STATUS(1)
> =======================
> 
> NAME
> ----
> check-support-status - check installed packages for ended security support

(Should that perhaps be "reduced security support"?)

> 
> VERSION
> -------
> Version 2014.04.06
> 
> SYNOPSIS
> --------
> Search for packages with ended or limited support:
> 
> ----
>     check-supported-status
                   XX
No, that's not what it's called!

> ----
> 
> Search for package with ended support from a manual list, report
                    ^s                       (custom?)      reporting
> each package only once:
> 
> ----
>     check-supported-status \
                   XX
>         --type ended \
>         --semaphore /path/to/semaphore \

("Semaphore" is a strange word to use for what appears to be a
status database recording things that have already been reported, but
I suspect it's already too late to change it.)

>         --list /path/to/security-support-ended
> ----
> 
> OPTIONS
> -------
> *--list* 'FILE'::
> 
> Use the given file as database which packages are no longer
                       ^the     ^of
> supported or with limited support. The file format is plain text in
               have
> columns, separated by one or more characters.

What kind of characters?  Assuming it's not just spaces, I suspect:
           separated by one or more whitespace characters.

> +
> For `--type ended`:
> +
> --
> * source package name
> * last version that package was supported

I think this is trying to say:
  * last package version that is supported

> * the date supported was ended.
                    XX          X
> * the rest: An optional text or URL with further information.

Is that "some optional text, or a URL with further information", or is
it "optionally, (nothing, or) some text with further information, or a
URL with further information"?  I'm guessing:

  * the rest: details, and/or a URL for further information.

(I don't see any reason to forbid having both, if it'll fit.)

> --
> +
> For `--type limited`:
> +
> --
> * source package name
> * the rest: An optional text or URL with further information.

Ditto.

> --
> +
> If no "--list" is provided, the script is run for both ended and
> limited support, using the lists shipped in the package.
> 
> *--dpkg* 'COMMAND'::
> 
> The command to execute instead of dpkg. Mostly for tests.
> +
> Note: This does not override the usage when called as
> "dpkg --compare-versions".
> 
> *--dpkg-query* 'COMAND'::
                  COMMAND
> 
> The command to execute instead of dpkg-query. Mostly for tests.

Wait... if this is a separate item, what non-querying, non-comparing
dpkg calls was it talking about in the previous section?  (Goes and
looks)  Apparently, only the call to "dpkg --version".  That seems a
bit futile.  Wouldn't it be simpler to have a --dpkg-version option?

> *--no-heading*::
> 
> Skips printing a headline.
> 
> *--semaphore* 'FILE'::
> 
> Use the given file to record alerts so each affected package is
> reported only once.
> +
> Default: No records, any affected package will be reported every time.
> 
> *--type* 'TYPE'::
> 
> One of the following:
> 
>    * "ended": Alert for packages where security support has ended.
>    * "limited": Alert for packages where security support is limited.
> 
> *--version, --Version, -V*::
> 
> Show the version number and exit.
> 
> BUGS
> ----

(More of a wontfix "LIMITATIONS", really)

> Using mixed distribution like half-stable, half-testing is not
> supported.

"Mixed distributions" (or perhaps "a mixed distribution").
 
[...]
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- debian-security-support-2014.05.16.pristine/check-support-status	2014-04-28 19:50:42.000000000 +0100
+++ debian-security-support-2014.05.16/check-support-status	2014-05-17 17:12:11.753387884 +0100
@@ -202,21 +202,22 @@
     case "$TYPE" in
         ended)
             gettext \
-"Security support has ended for one or more packages
+"Ended security support for one or more packages
 
-Unfortunately, security support for some packages needed to be stopped
-before the end of the regular security maintenance life cycle.
+Unfortunately, it has been necessary to end security support for some
+packages before the end of the regular security maintenance life cycle.
 
-The following packages found on your system are affected by this:"
+The following packages found on this system are affected by this:"
             echo
             ;;
         limited)
             gettext \
-"Security support is limited for one or more packages
+"Limited security support for one or more packages
 
-Unfortunately, security support for some packages had to be limited.
+Unfortunately, it has been necessary to limit security support for some
+packages.
 
-The following packages found on your system are affected by this:"
+The following packages found on this system are affected by this:"
             echo
             ;;
     esac
--- debian-security-support-2014.05.16.pristine/check-support-status.txt	2014-04-28 19:50:42.000000000 +0100
+++ debian-security-support-2014.05.16/check-support-status.txt	2014-05-17 18:27:44.276045078 +0100
@@ -15,14 +15,14 @@
 Search for packages with ended or limited support:
 
 ----
-    check-supported-status
+    check-support-status
 ----
 
-Search for package with ended support from a manual list, report
+Search for packages with ended support from a manual list, reporting
 each package only once:
 
 ----
-    check-supported-status \
+    check-support-status \
         --type ended \
         --semaphore /path/to/semaphore \
         --list /path/to/security-support-ended
@@ -32,24 +32,24 @@
 -------
 *--list* 'FILE'::
 
-Use the given file as database which packages are no longer
-supported or with limited support. The file format is plain text in
-columns, separated by one or more characters.
+Use the given file as the database of which packages are no longer
+supported or have limited support. The file format is plain text in
+columns, separated by one or more whitespace characters.
 +
 For `--type ended`:
 +
 --
 * source package name
-* last version that package was supported
-* the date supported was ended.
-* the rest: An optional text or URL with further information.
+* last package version that is supported
+* the date support was ended
+* the rest: details, and/or a URL for further information.
 --
 +
 For `--type limited`:
 +
 --
 * source package name
-* the rest: An optional text or URL with further information.
+* the rest: details, and/or a URL for further information.
 --
 +
 If no "--list" is provided, the script is run for both ended and
@@ -90,7 +90,7 @@
 
 BUGS
 ----
-Using mixed distribution like half-stable, half-testing is not
+Using mixed distributions like half-stable, half-testing is not
 supported.
 
 AUTHOR

Reply to: