[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://init-select/{templates}



Please find, for review, the debconf templates and packages descriptions for the init-select source package.

This review will last from Thursday, January 16, 2014 to Sunday, January 26, 2014.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- init-select.old/debian/templates	2014-01-07 07:55:05.777828676 +0100
+++ init-select/debian/templates	2014-01-16 18:56:18.655395345 +0100
@@ -2,13 +2,17 @@
 Type: select
 Choices: sysvinit, systemd
 Default: sysvinit
-_Description: select an init system
- Please select an init system from the following list.  If you are unsure
- what this means, please select the default.
+_Description: Init system:

Turn the short description into a "prompt"

+ Please select an init system from the list.
+ .
+ The init system is the first process started by the kernel and is in
+ charge of handling the machine boot process.

Drop "following". That's assuming that the list is always displayed
"after" the text which may be untrue for some debconf interfaces.

Add a few explanation words about what an init system is.

Drop the suggestion to pick the defaul is one is unsure.  This is
*always* what one should do..:-)

 
 Template: init-select/no-systemd
-Type: note
+Type: error

That imroves the visibility of the note and debconf will take more
actions in order to be sure that the template is displayed

 _Description: systemd package not installed
  The systemd package is not installed at present, so it cannot be selected
- as the init system.  Please execute "apt-get install systemd && 
+ as the init system.
+ .
+ Please execute "apt-get install systemd && 
  dpkg-reconfigure init-select" in order to install and configure systemd.

Split in two paragraphs for readability.

--- init-select.old/debian/control	2014-01-07 07:55:05.777828676 +0100
+++ init-select/debian/control	2014-01-16 18:58:08.234504220 +0100
@@ -15,7 +15,10 @@
 Suggests:
  systemd,
 Description: init system selection tool
- init-select makes it easy to select among the available init systems (the
- first process started when the system starts).  init-select currently only
- supports the grub bootloader, but this will be expanded to lilo and other
- bootloaders in the future.
+ The package provides a tool (init-select) that simplifies the process
+ of selecting the init system among those available.
+ .
+ The init systems is the first process started when the system starts.
+ .
+ This tool currently only supports the GRUB boot loader, but this will
+ be expanded to other boot loaders in the future.

I tried to work around the need to have a leading lowercase letter if
one starts paragraphs with the program name.

Properly spell "boot loader" in two words. Also using uppercase for
GRUB acronym.

I'd advise about not using the last paragraphs. Things will change
over time and package description tend to never be modified once
written...so that might become untrue in the future.

-- 

Template: init-select/choose
Type: select
Choices: sysvinit, systemd
Default: sysvinit
_Description: Init system:
 Please select an init system from the list.
 .
 The init system is the first process started by the kernel and is in
 charge of handling the machine boot process.

Template: init-select/no-systemd
Type: error
_Description: systemd package not installed
 The systemd package is not installed at present, so it cannot be selected
 as the init system.
 .
 Please execute "apt-get install systemd && 
 dpkg-reconfigure init-select" in order to install and configure systemd.
--- init-select.old/debian/templates	2014-01-07 07:55:05.777828676 +0100
+++ init-select/debian/templates	2014-01-16 18:56:18.655395345 +0100
@@ -2,13 +2,17 @@
 Type: select
 Choices: sysvinit, systemd
 Default: sysvinit
-_Description: select an init system
- Please select an init system from the following list.  If you are unsure
- what this means, please select the default.
+_Description: Init system:
+ Please select an init system from the list.
+ .
+ The init system is the first process started by the kernel and is in
+ charge of handling the machine boot process.
 
 Template: init-select/no-systemd
-Type: note
+Type: error
 _Description: systemd package not installed
  The systemd package is not installed at present, so it cannot be selected
- as the init system.  Please execute "apt-get install systemd && 
+ as the init system.
+ .
+ Please execute "apt-get install systemd && 
  dpkg-reconfigure init-select" in order to install and configure systemd.
--- init-select.old/debian/control	2014-01-07 07:55:05.777828676 +0100
+++ init-select/debian/control	2014-01-16 19:01:45.752675389 +0100
@@ -15,7 +15,10 @@
 Suggests:
  systemd,
 Description: init system selection tool
- init-select makes it easy to select among the available init systems (the
- first process started when the system starts).  init-select currently only
- supports the grub bootloader, but this will be expanded to lilo and other
- bootloaders in the future.
+ The package provides a tool (init-select) that simplifies the process
+ of selecting the init system among those available.
+ .
+ The init systems is the first process started when the system starts.
+ .
+ This tool currently only supports the GRUB boot loader, but this will
+ be expanded to other boot loaders in the future.
--- init-select.old/debian/changelog	2014-01-07 07:55:05.777828676 +0100
+++ init-select/debian/changelog	2014-01-07 14:26:33.523164681 +0100
@@ -1,3 +1,11 @@
+init-select (1.20140106) UNRELEASED; urgency=low
+
+  * Debconf templates and debian/control reviewed by the debian-l10n-
+    english team as part of the Smith review project. Closes: #734437
+  * [Debconf translation updates]
+
+ -- Christian Perrier <bubulle@debian.org>  Tue, 07 Jan 2014 14:26:33 +0100
+
 init-select (1.20140105) unstable; urgency=low
 
   * Initial Release.
Source: init-select
Section: utils
Priority: optional
Maintainer: Michael Gilbert <mgilbert@debian.org>
Build-Depends:
 debhelper (>= 9),
 po-debconf,
Standards-Version: 3.9.5

Package: init-select
Architecture: all
Depends:
 ${misc:Depends},
 grub2-common,
Suggests:
 systemd,
Description: init system selection tool
 The package provides a tool (init-select) that simplifies the process
 of selecting the init system among those available.
 .
 The init systems is the first process started when the system starts.
 .
 This tool currently only supports the GRUB boot loader, but this will
 be expanded to other boot loaders in the future.

Attachment: signature.asc
Description: Digital signature


Reply to: