Re: Bug#733300: [RFR] templates://kinect-audio-setup/{templates}
On Thu, 2 Jan 2014 09:29:00 +0100
Christian PERRIER <bubulle@debian.org> wrote:
> Please find, for review, the debconf templates and packages descriptions for the kinect-audio-setup source package.
>
> This review will last from Thursday, January 02, 2014 to Sunday, January 12, 2014.
>
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.
>
> Your review should be sent as an answer to this mail.
>
> When appropriate, I will send intermediate requests for review, with
> "[RFRn]" (n>=2) as a subject tag.
>
> When we will reach a consensus, I send a "Last Chance For
> Comments" mail with "[LCFC]" as a subject tag.
>
> Finally, a summary will be sent to the review bug report,
> and a mail will be sent to this list with "[BTS]" as a subject tag.
>
> Rationale:
> --- kinect-audio-setup.old/debian/templates 2013-12-28 11:39:21.915161442 +0100
> +++ kinect-audio-setup/debian/templates 2014-01-02 09:08:52.500268259 +0100
> @@ -1,17 +1,18 @@
> Template: kinect-audio-setup/accept_eula
> Type: boolean
> Default: false
> +#flag:translate!:3
Does the 3 here refer to Translation Units? How are they counted in the
Description field?
> _Description: Do you accept the Microsoft KinectForWindows EULA?
> - In order to fetch the binary firmware needed by this package you need
> - to agree to the EULA of the Microsoft KinectForWindows SDK:
> + In order to fetch the binary firmware needed by the kinect-audio-setup package, you need
> + to agree to the End User License Agreement (EULA) of the Microsoft
> + KinectForWindows Software Development Kit:
> .
> http://www.kinectforwindows.org/download/EULA.htm
>
> I always found the acronym EULA a bit cryptic, particularly to
> non-English users. So, let's give translators an opporunity to
> translate it to their language (the acronym, not the EULA text, of
> course).
>
> Same for SDK.
>
> Let's mark the URL as non-translatable.
>
ACK.
> By the way, have you noticed that this URL redirects one to the main
> Kinect page?
> The EULA seems to now be the general Microsoft Terms of Use page:
> http://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx
>
The URL has changed since I last checked, I think I will use this one:
http://www.microsoft.com/en-us/kinectforwindows/develop/sdk-eula.aspx
I will also check all the other URLs, it looks like the home page of
Kinect For Windows is now at
http://www.microsoft.com/en-us/kinectforwindows/
>
> Template: kinect-audio-setup/eula_not_accepted
> -Type: note
> +Type: error
> _Description: EULA not accepted
> - You need to accept the EULA of Microsoft KinectForWindows SDK in order
> - to fetch the binary firmware needed by this package.
> + You need to accept the End User License Agreement (EULA) of Microsoft KinectForWindows Software Development Kit in order
> + to fetch the binary firmware needed by the kinect-audio-setup package.
> .
> - You can do this later by calling:
> - dpkg-reconfigure kinect-audio-setup
> + You can do this later with "dpkg-reconfigure kinect-audio-setup".
>
> Let's make it more clear that not accepting the EULA is a "problem"
> (as the package won't be installed) by turning the template into an
> "error" one.
>
> Again, make acronyms more explicit
>
> And avoid using a hard-formatted paragraph as second paragraph but
> make it a simple sentence.
>
ACK.
> --- kinect-audio-setup.old/debian/control 2013-12-28 11:39:21.915161442 +0100
> +++ kinect-audio-setup/debian/control 2014-01-02 09:10:43.283492575 +0100
> @@ -27,10 +27,10 @@
> becomes available.
> .
> kinect-audio-setup provides tools to download the firmware off the net
> - at installation time —since the firmware is not redistributable—, and
> + at installation time (since the firmware is not redistributable), and
> it sets up udev rules to call the firmware loader when the device is
> plugged in to finally get the USB Audio Class device.
> .
Maybe also this?
- plugged in to finally get the USB Audio Class device.
+ plugged in to finally get the USB Audio Class device (UAC).
To make it clearer what the "UAC" acronym below refers to.
> - The UAC firmware is downloaded from the Microsoft Kinect SDK at
> - http://www.kinectforwindows.org, the license of the SDK can be found at
> - http://www.kinectforwindows.org/download/EULA.htm
> + The UAC firmware is downloaded from the Microsoft Kinect Software
> + Development Kit at http://www.kinectforwindows.org, the license
> + of which can be found at http://www.kinectforwindows.org/download/EULA.htm
>
> Use standard parenthesis....
>
> And again expand acronym and make a small reformulation ("licence of
> which"....is that correct English, Justin?)
>
ACK.
Thanks,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
Reply to: