[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://kinect-audio-setup/{templates}



Christian PERRIER wrote:
>  Template: kinect-audio-setup/accept_eula
>  Type: boolean
>  Default: false
> +#flag:translate!:3
>  _Description: Do you accept the Microsoft KinectForWindows EULA?
> + In order to fetch the binary firmware needed by the kinect-audio-setup package, you need
> + to agree to the End User License Agreement (EULA) of the Microsoft
> + KinectForWindows Software Development Kit:

I don't see any sign of upstream styling the product as
"KinectForWindows" (beyond the URL being alloneword); it's always
"Kinect for Windows".

It seems a shame that users need to open a browser to read this EULA
when you're already fetching stuff for them, but I suppose it's not as
if there's any hope you could cram the text into a debconf dialogue.

Foolishly, perhaps, I've tracked down and looked at the actual EULA
(http://www.microsoft.com/en-us/kinectforwindows/develop/sdk-eula.aspx).
It doesn't license using the downloaded files in order to run the
Kinect hardware under Linux; only "to design, develop, and test your 
programs that run specifically on a Microsoft Windows operating
system".  Asking end-users to agree to it seems a bit pointless.

[...]
>  Template: kinect-audio-setup/eula_not_accepted
> -Type: note
> +Type: error
>  _Description: EULA not accepted
> - You need to accept the EULA of Microsoft KinectForWindows SDK in order
> - to fetch the binary firmware needed by this package.
> + You need to accept the End User License Agreement (EULA) of Microsoft KinectForWindows Software Development Kit in order
                                                            of the Microsoft Kinect for Windows Software Development Kit

(And let's do some re-wrapping.)
							         
In the control file:

>  Description: helpers to setup audio input from the Microsoft Kinect sensor

The noun is "setup", but the verb is separable ("set it up") and
therefore written with a space as "to set up".  Or since that's
getting a bit long, we could turn it into a noun-pile as:

   Description: Microsoft Kinect audio sensor setup helpers

>   When the Kinect is first plugged in the USB port it shows up as

Why do we need to specify the port?

>   a generic USB device with a bulk endpoint; after uploading a certain

Should that be "a bulk transfer endpoint"?  And either way, is there
really any need to mention anything this technical?

>   firmware a reenumeration takes place and a USB Audio Class device
>   becomes available.

"A certain firmware" is treating a mass noun as a count noun, and
"uploading" is confusing (especially given that the only subject the
sentence has had so far is the Kinect device).

I'm not sure about this, but isn't the device stack "reenumeration"
technically a separate event from the reset that makes the device
change class?  And it should probably at least be hyphenated...

So:
    When the Kinect is first plugged in, it shows up as a generic USB device
    with a bulk endpoint; after the appropriate firmware is installed, a
    re-enumeration takes place and a USB Audio Class device becomes available.

>   kinect-audio-setup provides tools to download the firmware off the net
> + at installation time (since the firmware is not redistributable), and
>   it sets up udev rules to call the firmware loader when the device is
>   plugged in to finally get the USB Audio Class device.

Say "from the Internet" (since it won't let you fetch a copy from
http://server.local), and rearrange slightly to reduce repetition and
avoid initial lowercase:

    Since the firmware is not redistributable, kinect-audio-setup provides
    tools to download it from the Internet at installation time, and sets up
    udev rules to call the firmware loader when the device is plugged in to
    finally get the USB Audio Class device.

>   .
> + The UAC firmware is downloaded from the Microsoft Kinect Software
> + Development Kit at http://www.kinectforwindows.org, the license
> + of which can be found at http://www.kinectforwindows.org/download/EULA.htm

The main problem remaining here is the fact it isn't true.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Template: kinect-audio-setup/accept_eula
Type: boolean
Default: false
#flag:translate!:3
_Description: Do you accept the Microsoft Kinect for Windows EULA?
 In order to fetch the binary firmware needed by the kinect-audio-setup
 package, you need to agree to the End User License Agreement (EULA) of
 the Microsoft Kinect for Windows Software Development Kit:
 .
 http://www.kinectforwindows.org/download/EULA.htm

Template: kinect-audio-setup/eula_not_accepted
Type: error
_Description: EULA not accepted
 You need to accept the End User License Agreement (EULA) of the
 Microsoft Kinect for Windows Software Development Kit in order
 to fetch the binary firmware needed by the kinect-audio-setup package.
 .
 You can do this later with "dpkg-reconfigure kinect-audio-setup".
Source: kinect-audio-setup
Maintainer: Antonio Ospite <ospite@studenti.unina.it>
Section: contrib/sound
XS-Autobuild: no
Priority: extra
Build-Depends: debhelper (>= 9),
               po-debconf,
               libusb-1.0-0-dev,
               pkg-config
Standards-Version: 3.9.5
Vcs-Browser: http://git.ao2.it/kinect-audio-setup.git/
Vcs-Git: git://git.ao2.it/kinect-audio-setup.git -b debian
Homepage: http://git.ao2.it/kinect-audio-setup.git/

Package: kinect-audio-setup
Architecture: any
Depends: ${shlibs:Depends},
         ${misc:Depends},
         debconf,
         udev,
         wget,
         p7zip-full (>= 9.20)
Description: Microsoft Kinect audio sensor setup helpers
 When the Kinect is first plugged in it shows up as a generic USB device
 with a bulk-transfer endpoint; after the appropriate firmware is
 installed, a re-enumeration takes place and a USB Audio Class device
 becomes available.
 .
 Since the firmware is not redistributable, kinect-audio-setup provides
 tools to download it from the Internet at installation time, and sets up
 udev rules to call the firmware loader when the device is plugged in to
 finally get the USB Audio Class device.
 .
 The UAC firmware is downloaded from the Microsoft Kinect Software
 Development Kit at http://www.kinectforwindows.org, the license
 of which can be found at http://www.kinectforwindows.org/download/EULA.htm
diff -ru kinect-audio-setup-0.3.pristine/debian/control kinect-audio-setup-0.3/debian/control
--- kinect-audio-setup-0.3.pristine/debian/control	2013-12-06 23:45:40.000000000 +0000
+++ kinect-audio-setup-0.3/debian/control	2014-01-02 12:34:47.408810518 +0000
@@ -20,17 +20,17 @@
          udev,
          wget,
          p7zip-full (>= 9.20)
-Description: helpers to setup audio input from the Microsoft Kinect sensor
- When the Kinect is first plugged in the USB port it shows up as
- a generic USB device with a bulk endpoint; after uploading a certain
- firmware a reenumeration takes place and a USB Audio Class device
+Description: Microsoft Kinect audio sensor setup helpers
+ When the Kinect is first plugged in it shows up as a generic USB device
+ with a bulk-transfer endpoint; after the appropriate firmware is
+ installed, a re-enumeration takes place and a USB Audio Class device
  becomes available.
  .
- kinect-audio-setup provides tools to download the firmware off the net
- at installation time —since the firmware is not redistributable—, and
- it sets up udev rules to call the firmware loader when the device is
- plugged in to finally get the USB Audio Class device.
+ Since the firmware is not redistributable, kinect-audio-setup provides
+ tools to download it from the Internet at installation time, and sets up
+ udev rules to call the firmware loader when the device is plugged in to
+ finally get the USB Audio Class device.
  .
- The UAC firmware is downloaded from the Microsoft Kinect SDK at
- http://www.kinectforwindows.org, the license of the SDK can be found at
- http://www.kinectforwindows.org/download/EULA.htm
+ The UAC firmware is downloaded from the Microsoft Kinect Software
+ Development Kit at http://www.kinectforwindows.org, the license
+ of which can be found at http://www.kinectforwindows.org/download/EULA.htm
diff -ru kinect-audio-setup-0.3.pristine/debian/templates kinect-audio-setup-0.3/debian/templates
--- kinect-audio-setup-0.3.pristine/debian/templates	2013-12-06 23:45:40.000000000 +0000
+++ kinect-audio-setup-0.3/debian/templates	2014-01-02 10:27:12.535589911 +0000
@@ -1,17 +1,19 @@
 Template: kinect-audio-setup/accept_eula
 Type: boolean
 Default: false
-_Description: Do you accept the Microsoft KinectForWindows EULA?
- In order to fetch the binary firmware needed by this package you need
- to agree to the EULA of the Microsoft KinectForWindows SDK:
+#flag:translate!:3
+_Description: Do you accept the Microsoft Kinect for Windows EULA?
+ In order to fetch the binary firmware needed by the kinect-audio-setup
+ package, you need to agree to the End User License Agreement (EULA) of
+ the Microsoft Kinect for Windows Software Development Kit:
  .
  http://www.kinectforwindows.org/download/EULA.htm
 
 Template: kinect-audio-setup/eula_not_accepted
-Type: note
+Type: error
 _Description: EULA not accepted
- You need to accept the EULA of Microsoft KinectForWindows SDK in order
- to fetch the binary firmware needed by this package.
+ You need to accept the End User License Agreement (EULA) of the
+ Microsoft Kinect for Windows Software Development Kit in order
+ to fetch the binary firmware needed by the kinect-audio-setup package.
  .
- You can do this later by calling:
-   dpkg-reconfigure kinect-audio-setup
+ You can do this later with "dpkg-reconfigure kinect-audio-setup".

Reply to: