Re: Bug#752045: [RFR] templates://dictionaries-common/{dictionaries-common.templates}
On Tue, Jul 01, 2014 at 07:40:45AM +0200, Christian PERRIER wrote:
> Please find, for review, the debconf templates and packages descriptions for the dictionaries-common source package.
Hi, thanks for the review. Templates look better now.
> This review will last from Tuesday, July 01, 2014 to Friday, July 11, 2014.
>
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.
>
> Your review should be sent as an answer to this mail.
Diff is attached with some suggested minor changes, comments follow
Template: dictionaries-common/invalid_debconf_value
-_Description: Invalid configuration setting for ${value}
+_Description: Invalid configuration setting for ${question}
An invalid value has been found for a configuration setting for
- dictionaries-common. It does not correspond to any installed package
- in the system.
+ dictionaries-common. "${value}" does not correspond to any installed
+ package in the system.
${value} is the wrong setting for ${question}, I think is better as above.
That is usually caused by problems at some time during packages
- installation, where the package providing [${value}] was selected for
+ installation, where the package providing "${value}" was selected for
installation but finally not installed because of errors in other
Minor change just for consistency with other variables. I kept the old
way just to not bother translators, but this seems a good occasion to
change it.
To fix this error, reinstall (or install) the package that provides
- the missing value. Then, if you don't want this package on
+ the invalid value. Then, if you don't want this package on
your system, remove it, which will also remove its configuration
Since the word "invalid" is used in other parts of the template, it is
probably better to use here too. Actual value "${value}" has already been
shown, I do not think there is need to repeat it.
Regards,
--
Agustin
--- dictionaries-common.templates.orig 2014-07-01 12:32:04.575647866 +0200
+++ dictionaries-common.templates 2014-07-01 12:35:32.687307259 +0200
@@ -21,18 +21,18 @@
Template: dictionaries-common/invalid_debconf_value
Type: error
-_Description: Invalid configuration setting for ${value}
+_Description: Invalid configuration setting for ${question}
An invalid value has been found for a configuration setting for
- dictionaries-common. It does not correspond to any installed package
- in the system.
+ dictionaries-common. "${value}" does not correspond to any installed
+ package in the system.
.
That is usually caused by problems at some time during packages
- installation, where the package providing [${value}] was selected for
+ installation, where the package providing "${value}" was selected for
installation but finally not installed because of errors in other
packages.
.
To fix this error, reinstall (or install) the package that provides
- the missing value. Then, if you don't want this package on
+ the invalid value. Then, if you don't want this package on
your system, remove it, which will also remove its configuration
settings in the "debconf" database. A choices menu
will be shown after this message in order to leave the system in a
Reply to: