Justin B Rye wrote...
> Christian PERRIER wrote:
> >> I gather this template text is echoed by runtime messages from
> >> binaries in the package (since there's a messages.po with the same
> >> grammar problem). Should I give you a patch for that too?
> >
> > Would be a good idea, yes. Same for the manpage.
So thanks for catching a lot of typos and staff. Oh boy, I must have
been blind. Are you OK if I upload an manpage before we're done with
the rest? Let me know if this is to disruptive for the process?
> I may be doing this wrong, but I attach a message-phrasing patch for
> the Bash script itself (on the assumption that the .po file just gets
> generated from it).
It is, using a tool from the gettext suite.
> And the check-support-status.txt file, which I gather is asciidoc
> source for the man page:
It is.
> > CHECK-SUPPORT-STATUS(1)
> > =======================
> >
> > NAME
> > ----
> > check-support-status - check installed packages for ended security support
>
> (Should that perhaps be "reduced security support"?)
Remainder of an early development phase when there was only the
"ended" check. So it should be rather "check installed packages for
ended or reduced security support". But
| check-support-status - check installed packages for ended or reduced security support
| 1++++++++1+++++++++2+++++++++3+++++++++4+++++++++5+++++++++6+++++++++7+++++++++8+++++
this should fit into 80 characters if possible.
> > --semaphore /path/to/semaphore \
>
> ("Semaphore" is a strange word to use for what appears to be a
> status database recording things that have already been reported, but
> I suspect it's already too late to change it.)
Again, something that just stayed from the early days.
Will think about it. Since this option exists mostly for the test
cases and I cannot think why anybody else would want to use it ...
it's not too late yet.
> > * the rest: An optional text or URL with further information.
>
> Is that "some optional text, or a URL with further information", or is
> it "optionally, (nothing, or) some text with further information, or a
> URL with further information"? I'm guessing:
>
> * the rest: details, and/or a URL for further information.
>
> (I don't see any reason to forbid having both, if it'll fit.)
The rest is fully optional. It should be short so it fits, and by the
way it's not translatable - that's why I prefer a URL.
So your proposal is OK, except the "optional" attribute is missing.
I'd write:
| * the rest (optional): details, and/or a URL for further information.
> > If no "--list" is provided, the script is run for both ended and
> > limited support, using the lists shipped in the package.
> >
> > *--dpkg* 'COMMAND'::
> >
> > The command to execute instead of dpkg. Mostly for tests.
> > +
> > Note: This does not override the usage when called as
> > "dpkg --compare-versions".
> >
> > *--dpkg-query* 'COMAND'::
> COMMAND
> >
> > The command to execute instead of dpkg-query. Mostly for tests.
>
> Wait... if this is a separate item, what non-querying, non-comparing
> dpkg calls was it talking about in the previous section? (Goes and
> looks) Apparently, only the call to "dpkg --version". That seems a
> bit futile. Wouldn't it be simpler to have a --dpkg-version option?
There are two commands that need overloading for the test suite,
"dpkg" and "dpkg-version", but since dpkg --compare-versions should
always work as expected ... to be honest, my enthusiasm to spend much
time here is limited. Since again, I don't see why anybody else would
use that option - but I just don't want to implement options without
documentation.
> > BUGS
> > ----
>
> (More of a wontfix "LIMITATIONS", really)
Yes, it's just "BUGS" is a well-established name for that section.
> > Using mixed distribution like half-stable, half-testing is not
> > supported.
>
> "Mixed distributions" (or perhaps "a mixed distribution").
I tend to something like
| Installations with mixed distributions like half-stable, half-testing
| are not supported.
but should leave the last word to you.
> [...]
> --
> JBR with qualifications in linguistics, experience as a Debian
> sysadmin, and probably no clue about this particular package
Watch out for a follow-up, I've overeagerly killed one or two
paragraphs that needed a comment.
Christoph
Attachment:
signature.asc
Description: Digital signature