[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://igtf-policy-bundle/{templates.in}



Please find, for review, the debconf templates and packages descriptions for the igtf-policy-bundle source package.

This review will last from Tuesday, April 29, 2014 to Friday, May 09, 2014.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- igtf-policy-bundle.old/debian/templates.in	2014-04-24 08:41:06.143267631 +0200
+++ igtf-policy-bundle/debian/templates.in	2014-04-29 19:07:52.910508550 +0200
@@ -1,23 +1,27 @@
 Template: igtf-policy-@PROFILE@/install_profile
 Type: boolean
 Default: true
-_Description: Install the IGTF @PROFILE@ CAs in /etc/grid-security/certificates?
- This package installs the IGTF CAs in /etc/grid-security/certificates.
- There are two ways to deal with these certificates:
- - yes: install all, except those in the exclude list
- - no: install only CAs in the include list.
- The include/exclude lists are covered by the next question.
+_Description: Install the IGTF @PROFILE@ CA certificates in /etc/grid-security/certificates?
+ This package installs the IGTF Certification Authority certificates in /etc/grid-security/certificates.
+ .
+ If you choose this option, all certificates will be installed, except
+ those in the "exclude" list.
+ .
+ If you do not choose this option, only
+ certificates from the "include" list will be installed.
+ .
+ You will then have the opportunity to define the relevant list.

This question must be entirely rephrase, imho, for various reasons:

- debconf questions should not make reference to debconf widgets
("Yes" or "No" answers) as the exact way those are presented to users
depends on the type of interface used for debconf....and the
translation of the slang package (Yes or No may be localized...or not)

The usual way to work this around is to use the "If you choose this
option" formula as I did.

- Using multiple paragraphs improves readability. Morevoer, the
original template was using a non hardcoded "bullet" list and,
therefore, the template probably looks weird on some interfaces.

- Rephrasing the sentence mentioning the opportunity to tune lists
should also avoid reference to  the way the question will be asked.

Il also made sure that "CA" is explained at least once.
 
 Template: igtf-policy-@PROFILE@/exclude_ca
 Type: multiselect
 Choices: ${exclude_ca}
-_Description: Certificates to explicitly exclude
- Select which certificates should not be installed in
+_Description: Certificates to explicitly exclude:
+ Please select which certificates should not be installed in
  /etc/grid-security/certificates.

Select and Multiselect templates should use a colon for the synopsis.

We also standardized on "Please select" for such questions..

 
 Template: igtf-policy-@PROFILE@/include_ca
 Type: multiselect
 Choices: ${include_ca}
-_Description: Certificates to explicitly include
- Select which certificates should be installed in
+_Description: Certificates to explicitly include:
+ Please select which certificates should be installed in
  /etc/grid-security/certificates.

Ditto.

-- 



Template: igtf-policy-@PROFILE@/install_profile
Type: boolean
Default: true
_Description: Install the IGTF @PROFILE@ CA certificates in /etc/grid-security/certificates?
 This package installs the IGTF Certification Authority certificates in /etc/grid-security/certificates.
 .
 If you choose this option, all certificates will be installed, except
 those in the "exclude" list.
 .
 If you do not choose this option, only
 certificates from the "include" list will be installed.
 .
 You will then have the opportunity to define the relevant list.

Template: igtf-policy-@PROFILE@/exclude_ca
Type: multiselect
Choices: ${exclude_ca}
_Description: Certificates to explicitly exclude:
 Please select which certificates should not be installed in
 /etc/grid-security/certificates.

Template: igtf-policy-@PROFILE@/include_ca
Type: multiselect
Choices: ${include_ca}
_Description: Certificates to explicitly include:
 Please select which certificates should be installed in
 /etc/grid-security/certificates.
--- igtf-policy-bundle.old/debian/templates.in	2014-04-24 08:41:06.143267631 +0200
+++ igtf-policy-bundle/debian/templates.in	2014-04-29 19:07:52.910508550 +0200
@@ -1,23 +1,27 @@
 Template: igtf-policy-@PROFILE@/install_profile
 Type: boolean
 Default: true
-_Description: Install the IGTF @PROFILE@ CAs in /etc/grid-security/certificates?
- This package installs the IGTF CAs in /etc/grid-security/certificates.
- There are two ways to deal with these certificates:
- - yes: install all, except those in the exclude list
- - no: install only CAs in the include list.
- The include/exclude lists are covered by the next question.
+_Description: Install the IGTF @PROFILE@ CA certificates in /etc/grid-security/certificates?
+ This package installs the IGTF Certification Authority certificates in /etc/grid-security/certificates.
+ .
+ If you choose this option, all certificates will be installed, except
+ those in the "exclude" list.
+ .
+ If you do not choose this option, only
+ certificates from the "include" list will be installed.
+ .
+ You will then have the opportunity to define the relevant list.
 
 Template: igtf-policy-@PROFILE@/exclude_ca
 Type: multiselect
 Choices: ${exclude_ca}
-_Description: Certificates to explicitly exclude
- Select which certificates should not be installed in
+_Description: Certificates to explicitly exclude:
+ Please select which certificates should not be installed in
  /etc/grid-security/certificates.
 
 Template: igtf-policy-@PROFILE@/include_ca
 Type: multiselect
 Choices: ${include_ca}
-_Description: Certificates to explicitly include
- Select which certificates should be installed in
+_Description: Certificates to explicitly include:
+ Please select which certificates should be installed in
  /etc/grid-security/certificates.
Source: igtf-policy-bundle
Section: misc
Priority: extra
Maintainer: Dennis van Dok <dennisvd@nikhef.nl>
Build-Depends: debhelper (>= 8.0.0), po-debconf
Standards-Version: 3.9.5
Homepage: http://www.igtf.net/
Vcs-Git: git://git@github.com:dvandok/igtf-policy-bundle.git
Vcs-Browser: https://github.com/dvandok/igtf-policy-bundle


Package: igtf-policy-classic
Architecture: all
Depends: ${misc:Depends}
Recommends: fetch-crl, openssl
Suggests: ca-certificates
Description: IGTF classic profile for Authority Root Certificates
 The International Grid Trust Federation (IGTF) maintains a common
 trust base for the benefit of distributed science and research
 computing infrastructures by maintaining a list of trust anchors, for
 accredited authorities. The distribution contains root certificates,
 certificate revocation list (CRL) locations, contact information, and
 signing policies.
 .
 This package contains the trust anchors for the classic profile.

Package: igtf-policy-mics
Architecture: all
Depends: ${misc:Depends}
Recommends: fetch-crl, openssl
Suggests: ca-certificates
Description: IGTF MICS profile for Authority Root Certificates
 The International Grid Trust Federation (IGTF) maintains a common
 trust base for the benefit of distributed science and research
 computing infrastructures by maintaining a list of trust anchors, for
 accredited authorities. The distribution contains root certificates,
 certificate revocation list (CRL) locations, contact information, and
 signing policies.
 .
 This package contains the trust anchors for the MICS (Member Integrated
 Credential Services) profile.

Package: igtf-policy-slcs
Architecture: all
Depends: ${misc:Depends}
Recommends: fetch-crl, openssl
Suggests: ca-certificates
Description: IGTF SLCS profile for Authority Root Certificates
 The International Grid Trust Federation (IGTF) maintains a common
 trust base for the benefit of distributed science and research
 computing infrastructures by maintaining a list of trust anchors, for
 accredited authorities. The distribution contains root certificates,
 certificate revocation list (CRL) locations, contact information, and
 signing policies.
 .
 This package contains the trust anchors for the SLCS (Short Lived
 Credential Services) profile.

Package: igtf-policy-unaccredited
Architecture: all
Depends: ${misc:Depends}
Recommends: openssl
Suggests: ca-certificates
Description: IGTF unaccredited Authority Root Certificates
 The International Grid Trust Federation (IGTF) maintains a common
 trust base for the benefit of distributed science and research
 computing infrastructures by maintaining a list of trust anchors, for
 accredited authorities. The distribution contains root certificates,
 certificate revocation list (CRL) locations, contact information, and
 signing policies.
 .
 This package contains several unaccredited trust anchors. Use with
 caution, as they come without any guarantees.

Package: igtf-policy-experimental
Architecture: all
Depends: ${misc:Depends}
Recommends: openssl
Suggests: ca-certificates
Description: IGTF experimental Authority Root Certificates
 The International Grid Trust Federation (IGTF) maintains a common
 trust base for the benefit of distributed science and research
 computing infrastructures by maintaining a list of trust anchors, for
 accredited authorities. The distribution contains root certificates,
 certificate revocation list (CRL) locations, contact information, and
 signing policies.
 .
 This package contains several experimental trust anchors. Use with
 caution, as they come without any guarantees.

Attachment: signature.asc
Description: Digital signature


Reply to: