[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://wims-moodle/{templates}



Christian PERRIER wrote:
> --- wims-moodle.old/debian/templates	2014-03-08 18:00:45.151242468 +0100
> +++ wims-moodle/debian/templates	2014-03-12 19:09:29.285610765 +0100
> @@ -1,12 +1,13 @@
>  Template: wims-moodle/remoteurl
>  Type: string
>  Default: https://wims.domain
> -_Description: Please type the base address to access Wims from remote machines:
> - The base address to access Wims will be needed to enable users to access
> - their Wims assignments from Moodle.
> +_Description: URL to access Wims from remote machines:
> + Please enter the URL that should be used to access Wims, so that
> + users can get their Wims assignments from Moodle.

Perhaps the standard styling for Wims should be WIMS, as it is in the
description for wims itself.  (I was assuming wims had passed through
d-l-e before, but no, I'm thinking of bug #678745.)

On the other hand, upstream for this package do clearly say "Wims",
given that the control file has 

 Homepage: http://wiki.ofset.org/index.php/Access_a_Wims_server_through_a_CMS

But on the third hand, that's a 404.

Also, the way "so that" fits in here is slightly ambiguous.  Maybe:

   _Description: URL to access Wims from remote machines:
    Please specify the URL that will allow users to access WIMS assignments
    from Moodle.

>   .
> - If you can access Wims at https://wims.example.org/wims/, you should
> - answer https://wims.example.org
> + Do not specify the path, but only the protocol and domain name. For
> + instance, if Wims is accessed from https://wims.example.org/wims/, then
> + you should enter https://wims.example.org only.

I would suggest leading with what's right instead of what's wrong:

    Specify the protocol and domain name, but not the path.

Except that I'm repeating the instruction to "specify".  And I'm not
sure if it's "domain name" or "host(name)" (and maybe even "scheme"
instead of "protocol").

>   .
>   Please notice that the protocol should be https. Apache must be configured
> - to be able to answer https requests.
> + to be able to answer HTTPS requests.

Does it have to be Apache?  I don't see anything in the dependencies
to stop me using nginx.

Wait, why do I have to type in the protocol if you already know it
must be https://?  I'm effectively just being asked for the server
name, not the URL.  But since I don't get to rewrite the postinst, how
about:

   _Description: URL to access Wims from remote machines:
    Please specify the URL that will allow users to access Wims assignments
    from Moodle.
    .
    It should include the server hostname, but not the path, and must use the
    HTTPS protocol (with the web server configured to answer HTTPS requests).
    For instance, if Wims is accessed from https://wims.example.org/wims/
    then you should enter https://wims.example.org here.

Then in the control file:
> Package: wims-moodle
...
> Description: module for Moodle featuring Wims mini-classes
>  Moodle (Modular Object-Oriented Dynamic Learning Environment) is a course
>  management system - a software package designed to help educators create
>  quality online courses.
>  .
>  Wims is an educational platform originally developed for mathematics
>  but now also supporting subjects such as physics, chemistry, biology,
>  and languages. Its more striking feature is to provide a huge quantity

"More" implies it has a total of two features.  I'd suggest:

   and languages. Its most striking feature is providing a huge quantity

>  of interactive exercises with randomly assigned data, allowing the
>  learners to work on the same type of exercise but with different
>  data and as often as they want.

Should this be "allowing learners to work as as often as they want on
the same type of exercise but with different data"?  Then again if
I've understood it correctly then it's probably okay as it is.

>  .
>  This module adds the possibility to define Wims classes as special
>  assignments in Moodle. Wims classes come in two flavors: one is
>  meant to contain a set of worksheets (interactive randomly generated
>  exercices for the students), and the other one is meant to contain
         ^
Typo: exercises.

>  exams. The content of exams are based on previously published
>  worksheets.

Content is singular, so "is".

>  .
>  The students already logged in Moodle are automatically logged into Wims,
>  and as they close the Wims session they entered, their scores in Moodle are
>  updated.

Are the students being "logged" or is this talking about logins?  It
should probably be:

   Logging into Moodle automatically logs students into Wims, and as they
   close their Wims session, their scores in Moodle are updated.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru wims-moodle-4.0.pristine/debian/control wims-moodle-4.0/debian/control
--- wims-moodle-4.0.pristine/debian/control	2014-01-04 21:41:13.000000000 +0000
+++ wims-moodle-4.0/debian/control	2014-03-12 19:20:50.608200042 +0000
@@ -17,7 +17,7 @@
  .
  Wims is an educational platform originally developed for mathematics
  but now also supporting subjects such as physics, chemistry, biology,
- and languages. Its more striking feature is to provide a huge quantity
+ and languages. Its most striking feature is providing a huge quantity
  of interactive exercises with randomly assigned data, allowing the
  learners to work on the same type of exercise but with different
  data and as often as they want.
@@ -25,11 +25,9 @@
  This module adds the possibility to define Wims classes as special
  assignments in Moodle. Wims classes come in two flavors: one is
  meant to contain a set of worksheets (interactive randomly generated
- exercices for the students), and the other one is meant to contain
- exams. The content of exams are based on previously published
- worksheets.
+ exercises for the students), and the other one is meant to contain
+ exams. The content of exams is based on previously published worksheets.
  .
- The students already logged in Moodle are automatically logged into Wims,
- and as they close the Wims session they entered, their scores in Moodle are
- updated.
+ Logging into Moodle automatically logs students into Wims, and as they
+ close their Wims session, their scores in Moodle are updated.
 
diff -ru wims-moodle-4.0.pristine/debian/templates wims-moodle-4.0/debian/templates
--- wims-moodle-4.0.pristine/debian/templates	2014-03-06 17:12:00.000000000 +0000
+++ wims-moodle-4.0/debian/templates	2014-03-12 19:32:54.648246701 +0000
@@ -1,12 +1,11 @@
 Template: wims-moodle/remoteurl
 Type: string
 Default: https://wims.domain
-_Description: Please type the base address to access Wims from remote machines:
- The base address to access Wims will be needed to enable users to access
- their Wims assignments from Moodle.
+_Description: URL to access Wims from remote machines:
+ Please specify the URL that will allow users to access Wims assignments
+ from Moodle.
  .
- If you can access Wims at https://wims.example.org/wims/, you should
- answer https://wims.example.org
- .
- Please notice that the protocol should be https. Apache must be configured
- to be able to answer https requests.
+ It should include the server hostname, but not the path, and must use the
+ HTTPS protocol (with the web server configured to answer HTTPS requests).
+ For instance, if Wims is accessed from https://wims.example.org/wims/
+ then you should enter https://wims.example.org here.
Template: wims-moodle/remoteurl
Type: string
Default: https://wims.domain
_Description: URL to access Wims from remote machines:
 Please specify the URL that will allow users to access Wims assignments
 from Moodle.
 .
 It should include the server hostname, but not the path, and must use the
 HTTPS protocol (with the web server configured to answer HTTPS requests).
 For instance, if Wims is accessed from https://wims.example.org/wims/
 then you should enter https://wims.example.org here.
Source: wims-moodle
Section: web
Priority: extra
Maintainer: Georges Khaznadar <georgesk@debian.org>
Build-Depends: debhelper (>= 9), po-debconf
Standards-Version: 3.9.5
Homepage: http://wiki.ofset.org/index.php/Access_a_Wims_server_through_a_CMS

Package: wims-moodle
Architecture: all
Depends: ${misc:Depends}, wims (>= 4.00)|wims-installed-manually, pwgen
Suggests: moodle (>= 2.2.1)|moodle-installed-manually
Description: module for Moodle featuring Wims mini-classes
 Moodle (Modular Object-Oriented Dynamic Learning Environment) is a course
 management system - a software package designed to help educators create
 quality online courses.
 .
 Wims is an educational platform originally developed for mathematics
 but now also supporting subjects such as physics, chemistry, biology,
 and languages. Its most striking feature is providing a huge quantity
 of interactive exercises with randomly assigned data, allowing the
 learners to work on the same type of exercise but with different
 data and as often as they want.
 .
 This module adds the possibility to define Wims classes as special
 assignments in Moodle. Wims classes come in two flavors: one is
 meant to contain a set of worksheets (interactive randomly generated
 exercises for the students), and the other one is meant to contain
 exams. The content of exams is based on previously published worksheets.
 .
 Logging into Moodle automatically logs students into Wims, and as they
 close their Wims session, their scores in Moodle are updated.


Reply to: