[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://apt-listdifferences/{templates}



Christian PERRIER wrote:
>  Template: apt-listdifferences/initialize

This all looks good.
  
>  Template: apt-listdifferences/purge
>  Type: boolean
>  Default: false
> -_Description: Would you like to remove the apt-listdifferences database?
> - The apt-listdifferences database is currently still on disk.  You can save
> +_Description: Remove the apt-listdifferences database?
> + The apt-listdifferences database is currently still present on disk.  You can save
>   a lot of space by removing it now, but if you ever plan to reinstall
>   apt-listdifferences, the database will need to be fully downloaded again.

Well, strictly speaking that last clause isn't true, is it?  If you
answered "no" to the question above then the database will just be
gradually getting more useful as it gets closer to being complete, and
you're free to stop using it before it's "fully downloaded".  So make
it:
    apt-listdifferences, the data will need to be downloaded again.

>  Description: source differences notification tool
> - apt-listdifferences will show the differences, or patch, between the sources
> + apt-listdifferences will show the differences, or patches, between the sources
>   for all packages as they get updated.  This makes it possible to easily
> - review source changes that have been included in new Debian package updates.
> + review source changes that have been included in new package updates.

"Makes it possible to easily X" is just a roundabout way of saying
"makes it easy to X" (or possibly even "eases Xing").

Is there a danger that people might install this just on the principle
that apt-listbugs and apt-listchanges are handy so this sounds good?
If so it might be a good idea to warn them that the diffs aren't
computed on the server side - they require multi-gigabyte downloads.
Maybe there should be an extra paragraph:

   .
   Those with limited bandwidth or disk space should be aware that
   reference copies of the sources are downloaded and stored locally.

But that's only a suggestion, not in my patch (but I've rewrapped it).
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru apt-listdifferences-1.20130824.pristine/debian/control apt-listdifferences-1.20130824/debian/control
--- apt-listdifferences-1.20130824.pristine/debian/control	2013-08-15 04:08:54.000000000 +0100
+++ apt-listdifferences-1.20130824/debian/control	2013-09-14 13:16:49.235076081 +0100
@@ -22,6 +22,6 @@
  python-debian,
  debian-keyring,
 Description: source differences notification tool
- apt-listdifferences will show the differences, or patch, between the sources
- for all packages as they get updated.  This makes it possible to easily
- review source changes that have been included in new Debian package updates.
+ apt-listdifferences will show the differences, or patches, between the
+ sources for all packages as they get updated. This makes it easy to
+ review source changes that have been included in new package updates.
diff -ru apt-listdifferences-1.20130824.pristine/debian/templates apt-listdifferences-1.20130824/debian/templates
--- apt-listdifferences-1.20130824.pristine/debian/templates	2013-08-15 00:50:03.000000000 +0100
+++ apt-listdifferences-1.20130824/debian/templates	2013-09-14 13:14:32.059006944 +0100
@@ -1,19 +1,19 @@
 Template: apt-listdifferences/initialize
 Type: boolean
 Default: true
-_Description: Would you like to initialize the apt-listdifferences database now?
- apt-listdifferences can initialize its database of source packages now.
- Depending on your internet connection, this may take a while, but it will also
+_Description: Initialize the apt-listdifferences database now?
+ The source packages database for apt-listdifferences can be initialized now.
+ Depending on your Internet connection, this may take a while, but it will also
  provide immediate functionality for the tool.
  .
- If you select No, apt-list-differences will instead become functional slowly
+ If you do not choose this option, apt-list-differences will instead become functional slowly
  over time as more and more reference source packages get added to its database
  when they are first seen.
 
 Template: apt-listdifferences/purge
 Type: boolean
 Default: false
-_Description: Would you like to remove the apt-listdifferences database?
- The apt-listdifferences database is currently still on disk.  You can save
+_Description: Remove the apt-listdifferences database?
+ The apt-listdifferences database is currently still present on disk.  You can save
  a lot of space by removing it now, but if you ever plan to reinstall
- apt-listdifferences, the database will need to be fully downloaded again.
+ apt-listdifferences, the data will need to be downloaded again.
Template: apt-listdifferences/initialize
Type: boolean
Default: true
_Description: Initialize the apt-listdifferences database now?
 The source packages database for apt-listdifferences can be initialized now.
 Depending on your Internet connection, this may take a while, but it will also
 provide immediate functionality for the tool.
 .
 If you do not choose this option, apt-list-differences will instead become functional slowly
 over time as more and more reference source packages get added to its database
 when they are first seen.

Template: apt-listdifferences/purge
Type: boolean
Default: false
_Description: Remove the apt-listdifferences database?
 The apt-listdifferences database is currently still present on disk.  You can save
 a lot of space by removing it now, but if you ever plan to reinstall
 apt-listdifferences, the data will need to be downloaded again.
Source: apt-listdifferences
Section: utils
Priority: extra
Maintainer: Michael Gilbert <mgilbert@debian.org>
Build-Depends:
 debhelper (>= 9),
 po-debconf,
 colordiff,
 python3,
 patch,
Built-Using:
 colordiff,
Standards-Version: 3.9.4

Package: apt-listdifferences
Architecture: all
Depends:
 ${misc:Depends},
 ${python3:Depends},
 devscripts,
 python-apt,
 python-debian,
 debian-keyring,
Description: source differences notification tool
 apt-listdifferences will show the differences, or patches, between the
 sources for all packages as they get updated. This makes it easy to
 review source changes that have been included in new package updates.

Reply to: