[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://squid-deb-proxy/{squid-deb-proxy.templates}



Please find, for review, the debconf templates and packages descriptions for the squid-deb-proxy source package.

This review will last from Sunday, April 28, 2013 to Wednesday, May 08, 2013.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- squid-deb-proxy.old/debian/squid-deb-proxy.templates	2013-04-20 08:32:42.653002140 +0200
+++ squid-deb-proxy/debian/squid-deb-proxy.templates	2013-04-24 07:30:14.255455324 +0200
@@ -1,16 +1,17 @@
 Template: squid-deb-proxy/ppa-enable
 Type: boolean
 Default: false
-_Description: Allow PPA (Personal Package Archive) access?
- Squid-deb-proxy by default will not allow PPA repositories from launchpad.
- Selecting Y in this option will activate PPA repo access.
+_Description: Allow PPA access?
+ By default, squid-deb-proxy does not allow to access Personal Packages
+ Archive (PPA) repositories from Launchpad.
+ .
+ Choosing this option will allow this.

As PPA is explained in the long description, it's maybe not needed to
explain it again in the short one.

Avoid "Selecting Y" as the "true" choice in a boolean template is not
always translated as a Yes/No choice. Hence using our standard wording.
 
 Template: squid-deb-proxy/acl-disable
 Type: boolean
 Default: false
 _Description: Allow unrestricted network access?
- Squid-deb-proxy restricts access to the cache to private networks
- only by default.
- Selecting Y in this option will allow unrestricted access of all IPs
- to access the cache. Selecting N will only allow private networks
- (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16) to access the cache.
+ By default, squid-deb-proxy restricts access to the cache to private
+ networks (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16).
+ .
+ Choosing this option will allow other IP addresses to access the cache.

Reformulation to make things clearer (?).


--- squid-deb-proxy.old/debian/control	2013-04-20 08:32:42.653002140 +0200
+++ squid-deb-proxy/debian/control	2013-04-28 14:37:16.233346451 +0200
@@ -18,18 +18,15 @@
 	 squid3
 Recommends: avahi-utils
 Description: Squid proxy configuration optimized for deb packages
- This package contains a squid proxy configuration that is optimized
+ This package contains a Squid proxy configuration that is optimized
  for downloading deb packages. It defaults to a different cache 
- directory and port than the regular squid cache.
- .
- The config default to allowing cached access from a local network
- to *.archive.ubuntu.com.
+ directory and port than the regular Squid cache.

Capitalize "Squid".

 
 Package: squid-deb-proxy-client
 Architecture: all
 Depends: ${misc:Depends}, avahi-utils, apt (>= 0.7.25.3ubuntu1), python
-Description: Automatic proxy discovery for apt based on avahi
- This package contains a helper for the apt http method to discover
+Description: automatic proxy discovery for APT based on avahi
+ This package contains a helper for the APT HTTP method to discover
  proxies that publish their service as _apt_proxy._tcp.
  .
  It was written to be installed on clients that should use 

uncapitalize the short description...and capitalize "http" as this is
an acronym.

@@ -41,12 +38,12 @@
 Section: debian-installer
 Architecture: all
 Depends: ${shlibs:Depends}, ${misc:Depends}, configured-network,
-Description: Automatic proxy discovery for apt based on avahi (udeb)
- This package contains a helper for the apt http method to discover
+Description: automatic proxy discovery for apt based on avahi (udeb)
+ This package contains a helper for the apt HTTP method to discover
  proxies that publish their service as _apt_proxy._tcp.
  .
  It was written to be installed on clients that should use 
  squid-deb-proxy automatically, but it will work with any proxy
  that publishes the service as _apt_proxy._tcp.
  .
- This package contains the udeb only
+ This package contains the udeb for use with the Debian Installer.

Standard "udeb" paragraph.


-- 


Template: squid-deb-proxy/ppa-enable
Type: boolean
Default: false
_Description: Allow PPA access?
 By default, squid-deb-proxy does not allow to access Personal Packages
 Archive (PPA) repositories from Launchpad.
 .
 Choosing this option will allow this.

Template: squid-deb-proxy/acl-disable
Type: boolean
Default: false
_Description: Allow unrestricted network access?
 By default, squid-deb-proxy restricts access to the cache to private
 networks (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16).
 .
 Choosing this option will allow other IP addresses to access the cache.
--- squid-deb-proxy.old/debian/squid-deb-proxy.templates	2013-04-20 08:32:42.653002140 +0200
+++ squid-deb-proxy/debian/squid-deb-proxy.templates	2013-04-24 07:30:14.255455324 +0200
@@ -1,16 +1,17 @@
 Template: squid-deb-proxy/ppa-enable
 Type: boolean
 Default: false
-_Description: Allow PPA (Personal Package Archive) access?
- Squid-deb-proxy by default will not allow PPA repositories from launchpad.
- Selecting Y in this option will activate PPA repo access.
+_Description: Allow PPA access?
+ By default, squid-deb-proxy does not allow to access Personal Packages
+ Archive (PPA) repositories from Launchpad.
+ .
+ Choosing this option will allow this.
 
 Template: squid-deb-proxy/acl-disable
 Type: boolean
 Default: false
 _Description: Allow unrestricted network access?
- Squid-deb-proxy restricts access to the cache to private networks
- only by default.
- Selecting Y in this option will allow unrestricted access of all IPs
- to access the cache. Selecting N will only allow private networks
- (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16) to access the cache.
+ By default, squid-deb-proxy restricts access to the cache to private
+ networks (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16).
+ .
+ Choosing this option will allow other IP addresses to access the cache.
--- squid-deb-proxy.old/debian/control	2013-04-20 08:32:42.653002140 +0200
+++ squid-deb-proxy/debian/control	2013-04-28 14:37:16.233346451 +0200
@@ -18,18 +18,15 @@
 	 squid3
 Recommends: avahi-utils
 Description: Squid proxy configuration optimized for deb packages
- This package contains a squid proxy configuration that is optimized
+ This package contains a Squid proxy configuration that is optimized
  for downloading deb packages. It defaults to a different cache 
- directory and port than the regular squid cache.
- .
- The config default to allowing cached access from a local network
- to *.archive.ubuntu.com.
+ directory and port than the regular Squid cache.
 
 Package: squid-deb-proxy-client
 Architecture: all
 Depends: ${misc:Depends}, avahi-utils, apt (>= 0.7.25.3ubuntu1), python
-Description: Automatic proxy discovery for apt based on avahi
- This package contains a helper for the apt http method to discover
+Description: automatic proxy discovery for APT based on avahi
+ This package contains a helper for the APT HTTP method to discover
  proxies that publish their service as _apt_proxy._tcp.
  .
  It was written to be installed on clients that should use 
@@ -41,12 +38,12 @@
 Section: debian-installer
 Architecture: all
 Depends: ${shlibs:Depends}, ${misc:Depends}, configured-network,
-Description: Automatic proxy discovery for apt based on avahi (udeb)
- This package contains a helper for the apt http method to discover
+Description: automatic proxy discovery for apt based on avahi (udeb)
+ This package contains a helper for the apt HTTP method to discover
  proxies that publish their service as _apt_proxy._tcp.
  .
  It was written to be installed on clients that should use 
  squid-deb-proxy automatically, but it will work with any proxy
  that publishes the service as _apt_proxy._tcp.
  .
- This package contains the udeb only
+ This package contains the udeb for use with the Debian Installer.
Source: squid-deb-proxy
Section: net
Priority: extra
Maintainer: Michael Vogt <mvo@debian.org>
Build-Depends: debhelper (>= 7.0.50),
               gettext,
               intltool,
               pkg-config,
               po-debconf
Standards-Version: 3.9.4
Vcs-Bzr: https://code.launchpad.net/~squid-deb-proxy-developers/squid-deb-proxy/trunk
Homepage: https://launchpad.net/squid-deb-proxy

Package: squid-deb-proxy
Architecture: all
Depends: ${python:Depends},
         ${misc:Depends},
	 squid3
Recommends: avahi-utils
Description: Squid proxy configuration optimized for deb packages
 This package contains a Squid proxy configuration that is optimized
 for downloading deb packages. It defaults to a different cache 
 directory and port than the regular Squid cache.

Package: squid-deb-proxy-client
Architecture: all
Depends: ${misc:Depends}, avahi-utils, apt (>= 0.7.25.3ubuntu1), python
Description: automatic proxy discovery for APT based on avahi
 This package contains a helper for the APT HTTP method to discover
 proxies that publish their service as _apt_proxy._tcp.
 .
 It was written to be installed on clients that should use 
 squid-deb-proxy automatically, but it will work with any proxy
 that publishes the service as _apt_proxy._tcp.

Package: squid-deb-proxy-client-udeb
XC-Package-Type: udeb
Section: debian-installer
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}, configured-network,
Description: automatic proxy discovery for apt based on avahi (udeb)
 This package contains a helper for the apt HTTP method to discover
 proxies that publish their service as _apt_proxy._tcp.
 .
 It was written to be installed on clients that should use 
 squid-deb-proxy automatically, but it will work with any proxy
 that publishes the service as _apt_proxy._tcp.
 .
 This package contains the udeb for use with the Debian Installer.

Attachment: signature.asc
Description: Digital signature


Reply to: