Please find, for review, the debconf templates and packages descriptions for the fheroes2-pkg source package.
This review will last from Friday, October 18, 2013 to Monday, October 28, 2013.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- fheroes2-pkg.old/debian/templates 2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/templates 2013-10-18 07:09:00.742374650 +0200
@@ -1,34 +1,39 @@
Template: fheroes2-pkg/build
Type: boolean
Default: true
-_Description: Continue?
- This application is about to download, compile from source code and
- install "${PKGG}${VER}" as Debian package (source files will be
- downloaded from SourceForge).
- .
+_Description: Process with downloading and compiling fheroes2?
fheroes2 AI is non-free due to not-for-sale restriction.
Also some images may be non-free.
+ .
+ As a consequence, the software has to be downloaded and compiled at
+ install time.
+ .
+ The installation process is therefore about to download, compile from source code and
+ install "${PKGG}${VER}" as a binary deb package (source files will be
+ downloaded from SourceForge).
+ .
+ Please confirm whether you accept this to happen.
Template: fheroes2-pkg/first-install
Type: note
_Description:
- This application automates download, compile from source code and
- install "${PKGG}${VER}" as Debian package (source files will be
- downloaded from SourceForge).
- .
fheroes2 AI is non-free due to not-for-sale restriction.
Also some images may be non-free.
.
- Please remember to run `sudo dpkg-reconfigure ${PKGI}`
+ The installation process is therefore about to download, compile from source code and
+ install "${PKGG}${VER}" as a binary deb package (source files will be
+ downloaded from SourceForge).
+ .
+ Please remember to run "sudo dpkg-reconfigure ${PKGI}"
to build and install guest package(s) for the first time.
Template: fheroes2-pkg/title_b-i
Type: title
-_Description: Build and install ${PKGG}${VER}.
+_Description: Build and install ${PKGG}${VER}
Template: fheroes2-pkg/title_u
Type: title
-_Description: Guest package(s) upgrade note.
+_Description: Guest package(s) upgrade note
Template: fheroes2-pkg/upgrade
Type: note
@@ -36,39 +41,33 @@
An update to guest package(s) [${PKGG_ALL}] version ${VER} is available
but automatic upgrade is disabled.
.
- Please remember to run `sudo dpkg-reconfigure ${PKGI}` to build and
- install guest package(s) or consider installing APT post-invoke hook.
+ Please remember to run "sudo dpkg-reconfigure ${PKGI}" to build and
+ install guest package(s) or consider installing the APT post-invoke hook.
Template: fheroes2-pkg/post-invoke_hook-install
Type: boolean
Default: true
_Description: Install APT post-invoke hook?
APT post-invoke hook takes care of future automatic upgrades of guest
- package(s) on host package upgrade. After end of batch of APT
+ package(s) on host package upgrade. If activated, the APT
operations hook will check whenever guest package(s) can be updated.
- If upgrade detected then hook will attempt to download/build and
- install package(s) using `dpkg -i` but only if `apt-get check` reported
+ The hook will then attempt to download, build and
+ install package(s) using "dpkg -i" but only if "apt-get check" reported
no errors.
.
- At the moment there are no known problems associated with APT
- post-invoke hook which maintainer recommends to use with this package.
- .
- Alternatively guest package(s) can be built by manual invocation of
- `dpkg-reconfigure ${PKGI}`.
+ Alternatively, guest package(s) can be built by manual invocation of
+ "dpkg-reconfigure ${PKGI}".
Template: fheroes2-pkg/post-invoke_hook-remove
Type: boolean
Default: false
_Description: Remove APT post-invoke hook?
APT post-invoke hook takes care of future automatic upgrades of guest
- package(s) on host package upgrade. After end of batch of APT
+ package(s) on host package upgrade. If activated, the APT
operations hook will check whenever guest package(s) can be updated.
- If upgrade detected then hook will attempt to download/build and
- install package(s) using `dpkg -i` but only if `apt-get check` reported
+ The hook will then attempt to download, build and
+ install package(s) using "dpkg -i" but only if "apt-get check" reported
no errors.
.
- At the moment there are no known problems associated with APT
- post-invoke hook which maintainer recommends to use with this package.
- .
- Alternatively guest package(s) can be built on manual invocation of
- `dpkg-reconfigure ${PKGI}`.
+ Alternatively, guest package(s) can be built by manual invocation of
+ "dpkg-reconfigure ${PKGI}".
--- fheroes2-pkg.old/debian/control 2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/control 2013-10-18 07:10:50.481367234 +0200
@@ -15,9 +15,9 @@
Recommends: ${guest:Recommends} ,libcap2-bin
Suggests: ${guest:Suggests}
,vrms
-Description: download, build and install fheroes2 package
- This package automatically download, build ${guest} from source code
- and install the resulting package.
+Description: fheroes2 package downloader and builder
+ This package automatically downloads and builds ${guest} from source code
+ and installs the resulting package.
.
Fheroes2 binaries are not distributable if built with AI due to
licensing conflict between GPL-2 code and not-for-sale AI.
--
Template: fheroes2-pkg/build
Type: boolean
Default: true
_Description: Process with downloading and compiling fheroes2?
fheroes2 AI is non-free due to not-for-sale restriction.
Also some images may be non-free.
.
As a consequence, the software has to be downloaded and compiled at
install time.
.
The installation process is therefore about to download, compile from source code and
install "${PKGG}${VER}" as a binary deb package (source files will be
downloaded from SourceForge).
.
Please confirm whether you accept this to happen.
Template: fheroes2-pkg/first-install
Type: note
_Description:
fheroes2 AI is non-free due to not-for-sale restriction.
Also some images may be non-free.
.
The installation process is therefore about to download, compile from source code and
install "${PKGG}${VER}" as a binary deb package (source files will be
downloaded from SourceForge).
.
Please remember to run "sudo dpkg-reconfigure ${PKGI}"
to build and install guest package(s) for the first time.
Template: fheroes2-pkg/title_b-i
Type: title
_Description: Build and install ${PKGG}${VER}
Template: fheroes2-pkg/title_u
Type: title
_Description: Guest package(s) upgrade note
Template: fheroes2-pkg/upgrade
Type: note
_Description:
An update to guest package(s) [${PKGG_ALL}] version ${VER} is available
but automatic upgrade is disabled.
.
Please remember to run "sudo dpkg-reconfigure ${PKGI}" to build and
install guest package(s) or consider installing the APT post-invoke hook.
Template: fheroes2-pkg/post-invoke_hook-install
Type: boolean
Default: true
_Description: Install APT post-invoke hook?
APT post-invoke hook takes care of future automatic upgrades of guest
package(s) on host package upgrade. If activated, the APT
operations hook will check whenever guest package(s) can be updated.
The hook will then attempt to download, build and
install package(s) using "dpkg -i" but only if "apt-get check" reported
no errors.
.
Alternatively, guest package(s) can be built by manual invocation of
"dpkg-reconfigure ${PKGI}".
Template: fheroes2-pkg/post-invoke_hook-remove
Type: boolean
Default: false
_Description: Remove APT post-invoke hook?
APT post-invoke hook takes care of future automatic upgrades of guest
package(s) on host package upgrade. If activated, the APT
operations hook will check whenever guest package(s) can be updated.
The hook will then attempt to download, build and
install package(s) using "dpkg -i" but only if "apt-get check" reported
no errors.
.
Alternatively, guest package(s) can be built by manual invocation of
"dpkg-reconfigure ${PKGI}".
--- fheroes2-pkg.old/debian/templates 2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/templates 2013-10-18 07:09:00.742374650 +0200
@@ -1,34 +1,39 @@
Template: fheroes2-pkg/build
Type: boolean
Default: true
-_Description: Continue?
- This application is about to download, compile from source code and
- install "${PKGG}${VER}" as Debian package (source files will be
- downloaded from SourceForge).
- .
+_Description: Process with downloading and compiling fheroes2?
fheroes2 AI is non-free due to not-for-sale restriction.
Also some images may be non-free.
+ .
+ As a consequence, the software has to be downloaded and compiled at
+ install time.
+ .
+ The installation process is therefore about to download, compile from source code and
+ install "${PKGG}${VER}" as a binary deb package (source files will be
+ downloaded from SourceForge).
+ .
+ Please confirm whether you accept this to happen.
Template: fheroes2-pkg/first-install
Type: note
_Description:
- This application automates download, compile from source code and
- install "${PKGG}${VER}" as Debian package (source files will be
- downloaded from SourceForge).
- .
fheroes2 AI is non-free due to not-for-sale restriction.
Also some images may be non-free.
.
- Please remember to run `sudo dpkg-reconfigure ${PKGI}`
+ The installation process is therefore about to download, compile from source code and
+ install "${PKGG}${VER}" as a binary deb package (source files will be
+ downloaded from SourceForge).
+ .
+ Please remember to run "sudo dpkg-reconfigure ${PKGI}"
to build and install guest package(s) for the first time.
Template: fheroes2-pkg/title_b-i
Type: title
-_Description: Build and install ${PKGG}${VER}.
+_Description: Build and install ${PKGG}${VER}
Template: fheroes2-pkg/title_u
Type: title
-_Description: Guest package(s) upgrade note.
+_Description: Guest package(s) upgrade note
Template: fheroes2-pkg/upgrade
Type: note
@@ -36,39 +41,33 @@
An update to guest package(s) [${PKGG_ALL}] version ${VER} is available
but automatic upgrade is disabled.
.
- Please remember to run `sudo dpkg-reconfigure ${PKGI}` to build and
- install guest package(s) or consider installing APT post-invoke hook.
+ Please remember to run "sudo dpkg-reconfigure ${PKGI}" to build and
+ install guest package(s) or consider installing the APT post-invoke hook.
Template: fheroes2-pkg/post-invoke_hook-install
Type: boolean
Default: true
_Description: Install APT post-invoke hook?
APT post-invoke hook takes care of future automatic upgrades of guest
- package(s) on host package upgrade. After end of batch of APT
+ package(s) on host package upgrade. If activated, the APT
operations hook will check whenever guest package(s) can be updated.
- If upgrade detected then hook will attempt to download/build and
- install package(s) using `dpkg -i` but only if `apt-get check` reported
+ The hook will then attempt to download, build and
+ install package(s) using "dpkg -i" but only if "apt-get check" reported
no errors.
.
- At the moment there are no known problems associated with APT
- post-invoke hook which maintainer recommends to use with this package.
- .
- Alternatively guest package(s) can be built by manual invocation of
- `dpkg-reconfigure ${PKGI}`.
+ Alternatively, guest package(s) can be built by manual invocation of
+ "dpkg-reconfigure ${PKGI}".
Template: fheroes2-pkg/post-invoke_hook-remove
Type: boolean
Default: false
_Description: Remove APT post-invoke hook?
APT post-invoke hook takes care of future automatic upgrades of guest
- package(s) on host package upgrade. After end of batch of APT
+ package(s) on host package upgrade. If activated, the APT
operations hook will check whenever guest package(s) can be updated.
- If upgrade detected then hook will attempt to download/build and
- install package(s) using `dpkg -i` but only if `apt-get check` reported
+ The hook will then attempt to download, build and
+ install package(s) using "dpkg -i" but only if "apt-get check" reported
no errors.
.
- At the moment there are no known problems associated with APT
- post-invoke hook which maintainer recommends to use with this package.
- .
- Alternatively guest package(s) can be built on manual invocation of
- `dpkg-reconfigure ${PKGI}`.
+ Alternatively, guest package(s) can be built by manual invocation of
+ "dpkg-reconfigure ${PKGI}".
--- fheroes2-pkg.old/debian/control 2013-10-06 08:22:44.592797348 +0200
+++ fheroes2-pkg/debian/control 2013-10-18 07:10:50.481367234 +0200
@@ -15,9 +15,9 @@
Recommends: ${guest:Recommends} ,libcap2-bin
Suggests: ${guest:Suggests}
,vrms
-Description: download, build and install fheroes2 package
- This package automatically download, build ${guest} from source code
- and install the resulting package.
+Description: fheroes2 package downloader and builder
+ This package automatically downloads and builds ${guest} from source code
+ and installs the resulting package.
.
Fheroes2 binaries are not distributable if built with AI due to
licensing conflict between GPL-2 code and not-for-sale AI.
Source: fheroes2-pkg
Section: contrib/games
Priority: optional
Maintainer: Dmitry Smirnov <onlyjob@debian.org>
Standards-Version: 3.9.4
Build-Depends: debhelper (>= 9)
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=users/onlyjob/fheroes2-pkg.git
Vcs-Git: git://anonscm.debian.org/users/onlyjob/fheroes2-pkg.git
Package: fheroes2-pkg
Architecture: all
Provides: ${guest:Provides}
Depends: ${misc:Depends}, build-essential
,${guest:Build-Depends}
Recommends: ${guest:Recommends} ,libcap2-bin
Suggests: ${guest:Suggests}
,vrms
Description: fheroes2 package downloader and builder
This package automatically downloads and builds ${guest} from source code
and installs the resulting package.
.
Fheroes2 binaries are not distributable if built with AI due to
licensing conflict between GPL-2 code and not-for-sale AI.
Also Fheroes2 may contain some non-free images.
.
${guest}: ${guest:Description}
Attachment:
signature.asc
Description: Digital signature