Please find, for review, the debconf templates and packages descriptions for the b43-fwcutter source package.
This review will last from Sunday, May 19, 2013 to Wednesday, May 29, 2013.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.
Rationale:
--- b43-fwcutter.old/debian/b43-fwcutter.templates 2013-05-09 14:31:25.992368240 +0200
+++ b43-fwcutter/debian/b43-fwcutter.templates 2013-05-19 12:29:12.728910663 +0200
@@ -1,8 +1,13 @@
Template: b43-fwcutter/install-unconditional
Type: boolean
Default: true
-_Description: Install firmware for hardware not present on this system?
- Should the installer package download and install firmware for hardware
- that is not currently present on the system. This is useful if you plan to
+_Description: Install firmware even if Broadcom 43xx is not present
on this system?
"Hardware? What hardware?" would be the question in case this question
comes in the middle of a bunch of other debconf prompts..:-)
So, this is an attempt to explain what all this is about.
+ The b43-fwcutter package aims at installing firmware for some Broadcom wireless
+ network cards.
+ .
+ Please chosse whether you want the installer package to download and install
+ firmware even if the relevant hardware is not currently present on the system.
+ .
+ This might be useful if you plan to
move this installation to different hardware or share the same
installation on different systems.
The remaining rewrite is mostly aimed at bringing more readability by
splitting sentences in paragraphs. Also avoid a partial sentence in
the long description ("Should the installer package"....)
--- b43-fwcutter.old/debian/control 2013-05-09 14:31:25.992368240 +0200
+++ b43-fwcutter/debian/control 2013-05-19 12:31:52.893369975 +0200
@@ -11,8 +11,8 @@
Package: b43-fwcutter
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: Utility for extracting Broadcom 43xx firmware
- fwcutter is a tool which can extract firmware from various source files.
+Description: utility for extracting Broadcom 43xx firmware
Uncapitalize as package synopsis should not start with a capital letter
+ This package provides a tool which can extract firmware from various source files.
It's written for BCM43xx driver files. It grabs firmware for BCM43xx
from a website and installs it.
On the other hand, *capitalize* the first paragraph by using the
classic trick "This package provides".
@@ -23,28 +23,28 @@
Recommends: linux-image
Replaces: firmware-b43-lpphy-installer (<= 1:015-14)
Breaks: firmware-b43-lpphy-installer (<= 1:015-14)
-Description: Installer package for firmware for the b43 driver
+Description: installer package for firmware for the b43 driver
This package installs the firmware required for the use of the b43
- kernel driver.
+ kernel driver for some Broadcom 43xx wireless network cards.
"a kernel driver for what" would be the question I'd have if I read
this description without context. So, we need to explain what this
mysterious "b43" stands for (after all, it could be a Boeing aircraft,
after all).
.
Supported chipsets:
- - BCM4306/3
- - BCM4311
- - BCM4318
- - BCM4321
- - BCM4322 (only 14e4:432b)
- - BCM4312 (with Low-Power aka LP-PHY)
+ * BCM4306/3;
+ * BCM4311;
+ * BCM4318;
+ * BCM4321;
+ * BCM4322 (only 14e4:432b);
+ * BCM4312 (with Low-Power aka LP-PHY).
Standardive on our usual bulleted list style.
Package: firmware-b43legacy-installer
Section: contrib/kernel
Architecture: all
Recommends: linux-image
Depends: b43-fwcutter (>= ${source:Version}), wget, ${misc:Depends}
-Description: Installer package for firmware for the b43legacy driver
+Description: installer package for firmware for the b43legacy driver
This package installs the firmware needed for the use of the
- b43legacy kernel driver.
+ b43legacy kernel driver for some Broadcom 43xx wireless network cards.
.
Supported chipsets:
- - BCM4301
- - BCM4306/2
- - BCM4306
+ * BCM4301;
+ * BCM4306/2;
+ * BCM4306.
Same changes.
--
Template: b43-fwcutter/install-unconditional Type: boolean Default: true _Description: Install firmware even if Broadcom 43xx is not present on this system? The b43-fwcutter package aims at installing firmware for some Broadcom wireless network cards. . Please chosse whether you want the installer package to download and install firmware even if the relevant hardware is not currently present on the system. . This might be useful if you plan to move this installation to different hardware or share the same installation on different systems.
--- b43-fwcutter.old/debian/b43-fwcutter.templates 2013-05-09 14:31:25.992368240 +0200
+++ b43-fwcutter/debian/b43-fwcutter.templates 2013-05-19 12:35:18.223127819 +0200
@@ -1,8 +1,13 @@
Template: b43-fwcutter/install-unconditional
Type: boolean
Default: true
-_Description: Install firmware for hardware not present on this system?
- Should the installer package download and install firmware for hardware
- that is not currently present on the system. This is useful if you plan to
+_Description: Install firmware even if Broadcom 43xx is not present on this system?
+ The b43-fwcutter package aims at installing firmware for some Broadcom wireless
+ network cards.
+ .
+ Please chosse whether you want the installer package to download and install
+ firmware even if the relevant hardware is not currently present on the system.
+ .
+ This might be useful if you plan to
move this installation to different hardware or share the same
installation on different systems.
--- b43-fwcutter.old/debian/control 2013-05-09 14:31:25.992368240 +0200
+++ b43-fwcutter/debian/control 2013-05-19 12:31:52.893369975 +0200
@@ -11,8 +11,8 @@
Package: b43-fwcutter
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: Utility for extracting Broadcom 43xx firmware
- fwcutter is a tool which can extract firmware from various source files.
+Description: utility for extracting Broadcom 43xx firmware
+ This package provides a tool which can extract firmware from various source files.
It's written for BCM43xx driver files. It grabs firmware for BCM43xx
from a website and installs it.
@@ -23,28 +23,28 @@
Recommends: linux-image
Replaces: firmware-b43-lpphy-installer (<= 1:015-14)
Breaks: firmware-b43-lpphy-installer (<= 1:015-14)
-Description: Installer package for firmware for the b43 driver
+Description: installer package for firmware for the b43 driver
This package installs the firmware required for the use of the b43
- kernel driver.
+ kernel driver for some Broadcom 43xx wireless network cards.
.
Supported chipsets:
- - BCM4306/3
- - BCM4311
- - BCM4318
- - BCM4321
- - BCM4322 (only 14e4:432b)
- - BCM4312 (with Low-Power aka LP-PHY)
+ * BCM4306/3;
+ * BCM4311;
+ * BCM4318;
+ * BCM4321;
+ * BCM4322 (only 14e4:432b);
+ * BCM4312 (with Low-Power aka LP-PHY).
Package: firmware-b43legacy-installer
Section: contrib/kernel
Architecture: all
Recommends: linux-image
Depends: b43-fwcutter (>= ${source:Version}), wget, ${misc:Depends}
-Description: Installer package for firmware for the b43legacy driver
+Description: installer package for firmware for the b43legacy driver
This package installs the firmware needed for the use of the
- b43legacy kernel driver.
+ b43legacy kernel driver for some Broadcom 43xx wireless network cards.
.
Supported chipsets:
- - BCM4301
- - BCM4306/2
- - BCM4306
+ * BCM4301;
+ * BCM4306/2;
+ * BCM4306.
--- b43-fwcutter.old/debian/changelog 2013-05-09 14:31:25.992368240 +0200
+++ b43-fwcutter/debian/changelog 2013-05-10 11:58:26.733273553 +0200
@@ -1,3 +1,11 @@
+b43-fwcutter (1:017-2) UNRELEASED; urgency=low
+
+ * Debconf templates and debian/control reviewed by the debian-l10n-
+ english team as part of the Smith review project. Closes: #707562
+ * [Debconf translation updates]
+
+ -- Christian Perrier <bubulle@debian.org> Fri, 10 May 2013 11:58:26 +0200
+
b43-fwcutter (1:017-1) unstable; urgency=low
* Release from experimental to unstable
Source: b43-fwcutter
Section: contrib/utils
Priority: optional
Maintainer: Daniel Echeverry <epsilon77@gmail.com>
Build-Depends: debhelper (>= 9), po-debconf, debconf
Standards-Version: 3.9.4
Homepage: http://wireless.kernel.org/en/users/Drivers/b43
Vcs-Git: git://git.debian.org/collab-maint/b43-fwcutter.git
Vcs-Browser: http://git.debian.org/?p=collab-maint/b43-fwcutter.git
Package: b43-fwcutter
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: utility for extracting Broadcom 43xx firmware
This package provides a tool which can extract firmware from various source files.
It's written for BCM43xx driver files. It grabs firmware for BCM43xx
from a website and installs it.
Package: firmware-b43-installer
Section: contrib/kernel
Architecture: all
Depends: b43-fwcutter (>= ${source:Version}), bzip2, wget, ${misc:Depends}
Recommends: linux-image
Replaces: firmware-b43-lpphy-installer (<= 1:015-14)
Breaks: firmware-b43-lpphy-installer (<= 1:015-14)
Description: installer package for firmware for the b43 driver
This package installs the firmware required for the use of the b43
kernel driver for some Broadcom 43xx wireless network cards.
.
Supported chipsets:
* BCM4306/3;
* BCM4311;
* BCM4318;
* BCM4321;
* BCM4322 (only 14e4:432b);
* BCM4312 (with Low-Power aka LP-PHY).
Package: firmware-b43legacy-installer
Section: contrib/kernel
Architecture: all
Recommends: linux-image
Depends: b43-fwcutter (>= ${source:Version}), wget, ${misc:Depends}
Description: installer package for firmware for the b43legacy driver
This package installs the firmware needed for the use of the
b43legacy kernel driver for some Broadcom 43xx wireless network cards.
.
Supported chipsets:
* BCM4301;
* BCM4306/2;
* BCM4306.
Attachment:
signature.asc
Description: Digital signature