[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://pleiades/{pleiades.templates}



Please find, for review, the debconf templates and packages descriptions for the pleiades source package.

This review will last from Thursday, June 07, 2012 to Sunday, June 17, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- pleiades.old/debian/pleiades.templates	2012-06-06 07:25:00.803153497 +0200
+++ pleiades/debian/pleiades.templates	2012-06-07 07:45:11.480038915 +0200
@@ -1,5 +1,9 @@
 Template: pleiades/eclipse
 Type: boolean
 Default: false
-_Description: Enable pleiades for your Eclipse configuration?
- If you want to use pleiades, you should enable it in /etc/eclpse.ini.
+_Description: Enable Pleiades in Eclipse configuration?
+ Using Pleiades, the Japanese language package for Eclipse, requires it
+ to be activated in Eclipse configuration.
+ .
+ Please choose whether you want this to be done in Eclipse
+ configuration file (/etc/eclipse.ini).

I tried to make the template a bit more complete.

Capitalize "Pleiades". Unpersonnalize the template (dropping "your").

Justing, I don't know is using a verb as subject in a sentence is good
writing style in English ("Using <foo> requires <bar>"). Maybe sounds
too French..:-)

Fixed a typo in the name of the Eclipse configuration file.


--- pleiades.old/debian/control	2012-06-06 07:25:00.803153497 +0200
+++ pleiades/debian/control	2012-06-07 07:48:20.705306795 +0200
@@ -12,7 +12,10 @@
 Pre-Depends: debconf, dpkg (>= 1.15.6~)
 Depends: eclipse, libcommons-lang-java, libcommons-io-java, libjavassist-java,
  ${misc:Depends}
-Description: Japanese Language package for Eclipse using Dynamic AOP, Pleiades
- The Pleiades is a dynamic AOP translation container, it provides dynamic 
- Japanese localization to the Eclipse Platform and a large number of plug-ins.
- Some of its resources has contributed to the Eclipse.org.
+Description: Japanese language package for Eclipse using dynamic AOP
+ Pleiades is a dynamic AOP (aspect-oriented programming) translation
+ container.
+ .
+ It provides dynamic Japanese localization to the Eclipse
+ platform and a large number of plug-ins. Some of its resources have been
+ contributed in upstream Eclipse.

Let's "unjapanese" the description a little bit..:-).

I hope that I properly understand what AOP means.

-- 


Template: pleiades/eclipse
Type: boolean
Default: false
_Description: Enable Pleiades in Eclipse configuration?
 Using Pleiades, the Japanese language package for Eclipse, requires it
 to be activated in Eclipse configuration.
 .
 Please choose whether you want this to be done in Eclipse
 configuration file (/etc/eclipse.ini).
--- pleiades.old/debian/pleiades.templates	2012-06-06 07:25:00.803153497 +0200
+++ pleiades/debian/pleiades.templates	2012-06-07 07:45:11.480038915 +0200
@@ -1,5 +1,9 @@
 Template: pleiades/eclipse
 Type: boolean
 Default: false
-_Description: Enable pleiades for your Eclipse configuration?
- If you want to use pleiades, you should enable it in /etc/eclpse.ini.
+_Description: Enable Pleiades in Eclipse configuration?
+ Using Pleiades, the Japanese language package for Eclipse, requires it
+ to be activated in Eclipse configuration.
+ .
+ Please choose whether you want this to be done in Eclipse
+ configuration file (/etc/eclipse.ini).
--- pleiades.old/debian/control	2012-06-06 07:25:00.803153497 +0200
+++ pleiades/debian/control	2012-06-07 07:48:20.705306795 +0200
@@ -12,7 +12,10 @@
 Pre-Depends: debconf, dpkg (>= 1.15.6~)
 Depends: eclipse, libcommons-lang-java, libcommons-io-java, libjavassist-java,
  ${misc:Depends}
-Description: Japanese Language package for Eclipse using Dynamic AOP, Pleiades
- The Pleiades is a dynamic AOP translation container, it provides dynamic 
- Japanese localization to the Eclipse Platform and a large number of plug-ins.
- Some of its resources has contributed to the Eclipse.org.
+Description: Japanese language package for Eclipse using dynamic AOP
+ Pleiades is a dynamic AOP (aspect-oriented programming) translation
+ container.
+ .
+ It provides dynamic Japanese localization to the Eclipse
+ platform and a large number of plug-ins. Some of its resources have been
+ contributed in upstream Eclipse.
Source: pleiades
Section: devel
Priority: extra
Maintainer: Hideki Yamane <henrich@debian.org>
Build-Depends: debhelper (>= 7.0.50~), ant, default-jdk, po-debconf
Build-Depends-Indep: libcommons-lang-java, libcommons-io-java, libjavassist-java, zip, unzip
Standards-Version: 3.9.3
Homepage: http://mergedoc.sourceforge.jp/

Package: pleiades
Architecture: all
Pre-Depends: debconf, dpkg (>= 1.15.6~)
Depends: eclipse, libcommons-lang-java, libcommons-io-java, libjavassist-java,
 ${misc:Depends}
Description: Japanese language package for Eclipse using dynamic AOP
 Pleiades is a dynamic AOP (aspect-oriented programming) translation
 container.
 .
 It provides dynamic Japanese localization to the Eclipse
 platform and a large number of plug-ins. Some of its resources have been
 contributed in upstream Eclipse.

Attachment: signature.asc
Description: Digital signature


Reply to: