Hi,
Le 31/07/2012 15:32, Justin B Rye a écrit :
> Christian PERRIER wrote:
>> + Once configured, HotelDruid can be accessed locally at
>> + http://localhost/hoteldruid.
Maybe the URL should be enclosed in angle brackets, as advised in
uri(7), so the last dot won't hurt.
> _Description: Restrict HotelDruid access to this computer?
Looks like the intent is actually s/to/from/.
> The Apache web server can be configured to forbid HotelDruid
> connections from other computers.
Maybe s/computer/machine/ (seems like there are many browser embedded in
toys we can hardly call “computers” nowadays). Changed in three places
in the included patch.
>> + HotelDruid administrator password from the "users management"
^
Spurious space.
> (I would have expected "user management", but if the page title says
> "users" I suppose we'd better keep it.)
It's indeed to fix in the program first:
./includes/lang/en/personalizza.php:case "Gestione utenti":
$messaggio = "Users management"; break;
Question to the maintainer:
> _Description: Restart the web server after HotelDruid configuration?
Why restarting the web server when a reload is enough?
> In order to activate the new configuration for HotelDruid,
> the web server has to be restarted.
That's not true, cf. supra.
> HotelDruid stores its data in /var/lib/hoteldruid.
As advised in uri(7), maybe <file:///var/lib/hoteldruid> (yes, three
slashes), but it's not very important.
>> + You should deny this option if you have operational information which
>> + you wish to keep after HotelDruid is removed.
>
> I would also suggest s/deny/refuse/, since "deny" makes it sound
> vaguely as if you're lying about which option you accepted...
Try to remove the useless “you have”:
You should refuse this option if you wish to keep operational
information after HotelDruid is removed.
Regards
David
diff --git a/hoteldruid.templates b/hoteldruid.templates index 30e376c..fc07ace 100644 --- a/hoteldruid.templates +++ b/hoteldruid.templates @@ -6,22 +6,22 @@ _Description: Automatically configure the Apache web server for HotelDruid? configuration can only be performed for Apache. . Once configured, HotelDruid can be accessed locally at - http://localhost/hoteldruid. + <http://localhost/hoteldruid>. . Please choose whether automatic configuration should be performed now. Template: hoteldruid/restrict-localhost Type: boolean Default: true -_Description: Restrict HotelDruid access to this computer? +_Description: Restrict HotelDruid access from this machine? The Apache web server can be configured to forbid HotelDruid - connections from other computers. + connections from other machine. . It is recommended to activate this setting if HotelDruid is - going to be used from this computer. + going to be used from this machine. . Additional access control can be enabled by setting the - HotelDruid administrator password from the "users management" + HotelDruid administrator password from the "users management" page. User logins will then become mandatory. Template: hoteldruid/restart-webserver @@ -35,11 +35,11 @@ Template: hoteldruid/purgedata Type: boolean Default: false _Description: Purge HotelDuid data when purging the package? - HotelDruid stores its data in /var/lib/hoteldruid. + HotelDruid stores its data in <file:///var/lib/hoteldruid>. . If you choose this option, these data files will be removed when the package is purged. . - You should refuse this option if you have operational information which - you wish to keep after HotelDruid is removed. + You should refuse this option if you wish to keep operational + information after HotelDruid is removed.
Attachment:
signature.asc
Description: OpenPGP digital signature