[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fw: Bug#674569: please improve package description of poppler-data



Hideki Yamane wrote:
> Hi list,

I hope you don't mind being CCed.
 
>  I got a BTS to improve poppler-data pacakge's description.
>  I know my English is not good (of course ;), so I need YOUR help to do it.
>  Could you review it give suggestion for it, please?
> 
> -----------
> Package: poppler-data
> Version: 0.4.5-5
> Severity: wishlist
> 
> The current package description is:
> >>>>>
> Description-en: Encoding data for the poppler PDF rendering library
                  ^
Good except that DevRef prefers not capitalising the first word.

>  This package contains the encoding data needed to view some PDF documents
>  with libpoppler, and also that was provided by cmap-adobe-{gb1,cns1,korea1,
>  japan1,japan2} and gs-cjk-resource pacakges.
>  .
>  If CJK users want to view/create PDF files that contains their language,
>  this package will help you.
> <<<<<
> 
> Beside of the typo 'pacakges' the "and also that was" sounds strange.

Indeed; I think it was aiming for "which was also".  But perhaps it
would be better to split it into two sentences.

> It also immediately raises the question: What did these packages provide?
> (But it is good that you say that this package replaces them!)

Doing a bit of research (maybe not enough) it seems that the "encoding
data" it's talking about is CMap tables.  The "some PDF documents"
should be less evasive, too: it's "PDF documents containing CJK
characters".

> "PDF files that contains" is a plural vs. singular issue and the
> sentence itself sounds again a bit strange to my ears,
> but I am not a native speaker.

If anybody who ever needs to view a PDF file that contains
non-romanised Japanese is going to need this package, that could
surely include a lot of people who have no idea that they're "CJK
users" (or what CJK stands for).

PDF files do not contain languages (unless they're very small
languages, I suppose!) - they contain material in the scripts
traditionally used for those languages.

Apparently, no matter who I am, this package will help me on the sole
condition that CJK users want to do something that they'll probably
want to do.  I don't think this is necessarily true!

Finally, alphabeticise those alternatives: {c,g,j1,j2,k}.

So maybe

 Description: encoding data for the poppler PDF rendering library
  This package provides the CMap tables required to display PDF documents
  containing CJK characters with libpoppler. They were previously provided
  by the packages cmap-adobe-{cns1,gb1,japan1,japan2,korea1} and
  gs-cjk-resource.
  .
  Users who want to view or create PDF files in Chinese, Japanese, or
  Korean will need this package.

-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
diff -ru poppler-data-0.4.5.pristine/debian/control poppler-data-0.4.5/debian/control
--- poppler-data-0.4.5.pristine/debian/control	2012-03-10 10:10:08.000000000 +0000
+++ poppler-data-0.4.5/debian/control	2012-07-22 23:20:49.219393467 +0100
@@ -19,10 +19,11 @@
           cmap-adobe-korea1, cmap-adobe-cns1, cmap-adobe-japan1, 
           cmap-adobe-japan2, cmap-adobe-gb1
 Suggests: poppler-utils
-Description: Encoding data for the poppler PDF rendering library
- This package contains the encoding data needed to view some PDF documents 
- with libpoppler, and also that was provided by cmap-adobe-{gb1,cns1,korea1,
- japan1,japan2} and gs-cjk-resource pacakges.
+Description: encoding data for the poppler PDF rendering library
+ This package provides the CMap tables required to display PDF documents
+ containing CJK characters with libpoppler. They were previously provided
+ by the packages cmap-adobe-{cns1,gb1,japan1,japan2,korea1} and
+ gs-cjk-resource.
  .
- If CJK users want to view/create PDF files that contains their language, 
- this package will help you.
+ Users who want to view or create PDF files in Chinese, Japanese, or
+ Korean will need this package.

Reply to: