[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://tomoyo-tools/{tomoyo-tools.templates}



Please find, for review, the debconf templates for the tomoyo-tools
source package. As usual recently, I've been lazy and left the package
descriptions to Justin..:-)

This review will last from Tuesday, July 03, 2012 to Friday, July 13, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- tomoyo-tools.old/debian/tomoyo-tools.templates	2012-07-03 07:37:57.824148057 -0600
+++ tomoyo-tools/debian/tomoyo-tools.templates	2012-07-03 14:01:15.289389439 -0600
@@ -2,8 +2,9 @@
 Type: boolean
 Default: false
 _Description: Enable Tomoyo Linux in boot time?
- To enable Tomoyo, you should set GRUB_CMDLINE_LINUX="security=tomoyo" in
- /etc/default/grub and run grub-update to use it with your Linux kernel in
- next boot time. This config will enable it automatically.
+ Enabling Tomoyo requires setting GRUB_CMDLINE_LINUX="security=tomoyo" in
+ /etc/default/grub and running grub-update to use it with the installed
+ Linux kernel.
  .
- If you would not accept it, you should set it by your own hand later.
+ If you accept here, these actions will be performed automatically and
+ Tomoyo Linux will be ebabled at next boot.

I actually wonder about "in boot time". Shouldn't it be "at boot", or
"at next boot"...or even just "Enable Tomoyo Linux" (as it will be
enabled not only at next boot!).

My other changes involve changing the structure of the sentence. I'm
not exactly sure whether making a verb the subject of another verb is
something common in English, so that sentence might be Frenglish.

I changed the last paragraph to explain what happens if one answers
"yes" to the question....with the consequence that having to do things
manually if one answers "no" is implicit. I think it makes more sense
but your mileage may vary.

-- 



Template: tomoyo-tools/grub
Type: boolean
Default: false
_Description: Enable Tomoyo Linux in boot time?
 Enabling Tomoyo requires setting GRUB_CMDLINE_LINUX="security=tomoyo" in
 /etc/default/grub and running grub-update to use it with the installed
 Linux kernel.
 .
 If you accept here, these actions will be performed automatically and
 Tomoyo Linux will be ebabled at next boot.
--- tomoyo-tools.old/debian/tomoyo-tools.templates	2012-07-03 07:37:57.824148057 -0600
+++ tomoyo-tools/debian/tomoyo-tools.templates	2012-07-03 14:01:15.289389439 -0600
@@ -2,8 +2,9 @@
 Type: boolean
 Default: false
 _Description: Enable Tomoyo Linux in boot time?
- To enable Tomoyo, you should set GRUB_CMDLINE_LINUX="security=tomoyo" in
- /etc/default/grub and run grub-update to use it with your Linux kernel in
- next boot time. This config will enable it automatically.
+ Enabling Tomoyo requires setting GRUB_CMDLINE_LINUX="security=tomoyo" in
+ /etc/default/grub and running grub-update to use it with the installed
+ Linux kernel.
  .
- If you would not accept it, you should set it by your own hand later.
+ If you accept here, these actions will be performed automatically and
+ Tomoyo Linux will be ebabled at next boot.
Source: tomoyo-tools
Section: admin
Priority: extra
Maintainer: Hideki Yamane <henrich@debian.org>
Homepage: http://tomoyo.sourceforge.jp/
Build-Depends: debhelper (>= 9), libncurses5-dev, libreadline-dev, po-debconf
Standards-Version: 3.9.3
Vcs-Git: git://git.debian.org/collab-maint/tomoyo-tools.git
Vcs-Browser: http://git.debian.org/?p=collab-maint/tomoyo-tools.git

Package: tomoyo-tools
Architecture: linux-any
Pre-Depends: debconf
Depends: ${misc:Depends}, ${shlibs:Depends}
Conflicts: tomoyo-ccstools, tomoyo-ccstools1.7
Replaces: tomoyo-ccstools, tomoyo-ccstools1.7
Description: Lightweight and easy-use Mandatory Access Control for Linux
 TOMOYO Linux is Lightweight and Usable Mandatory Access Control with
  - "automatic policy configuring" feature by "LEARNING mode"
  - administrators friendly policy language
  - no need libselinux nor userland program modifications
 .
 TOMOYO Linux consists of patches to Linux kernel and administrative 
 utilities, and this package contains its audit daemon and tools.

Package: libtomoyotools3
Section: libs
Depends: ${shlibs:Depends}, ${misc:Depends}
Conflicts: libtomoyotools1, libtomoyotools2
Architecture: linux-any
Recommends: tomoyo-tools
Description: Lightweight and easy-use Mandatory Access Control for Linux (shared libraries)
 TOMOYO Linux is Lightweight and Usable Mandatory Access Control with
  - "automatic policy configuring" feature by "LEARNING mode"
  - administrators friendly policy language
  - no need libselinux nor userland program modifications
 .
 TOMOYO Linux consists of patches to Linux kernel and administrative 
 utilities, and this package contains its audit daemon and tools.
 .
 Shared library used by the utilities in the tomoyo-tools package.

Attachment: signature.asc
Description: Digital signature


Reply to: