[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://ipsec-tools/{racoon.templates}



Please find, for review, the debconf templates and packages descriptions for the ipsec-tools source package.

This review will last from Saturday, June 16, 2012 to Tuesday, June 26, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- ipsec-tools.old/debian/racoon.templates	2012-06-16 13:01:04.066652712 +0200
+++ ipsec-tools/debian/racoon.templates	2012-06-16 15:37:42.975451785 +0200
@@ -1,22 +1,19 @@
 Template: racoon/config_mode
 Type: select
 __Choices: direct, racoon-tool
-# The above choices have to be left as they are as the values are used directly
-# in the postinst script.  They do not need translation.
-# Please explain what they are in any rewritten description.

Well, but no..:-)

Choices can perfectly be translated. debconf will anyway get the
original version and not the translated one when you db_get the value.

There is even a way to only mark the first choice as translatable but
I think there can be benefit to make "racoon-tool" translatable (for
instance, in French, I would "translate" it to "Outil racoon-tool".


 Default: direct
-_Description: Configuration mode for racoon IKE daemon.
+_Description: Configuration mode for racoon IKE daemon:

A prompt should end up with a colon.

  Racoon can be configured two ways, either by directly editing
  /etc/racoon/racoon.conf or using the racoon-tool administrative front end.
  .
  Use of the "direct" method is strongly recommended if you want to use all
- the racoon examples on the Net, and if you want to use the fuul racoon feature
- set.  You will have to directly edit /etc/racoon/racoon.conf and possibly
+ the racoon examples on the Net, and if you want to use the full
+ racoon features set. You will have to directly edit /etc/racoon/racoon.conf and possibly
  manually set up the SPD via setkey.

Drop double space. I wonder whether we should capitalize "Racoon".

"feature" or "features"?

  .
  Racoon-tool has been refreshed for racoon 0.8.0, and is for use in basic
  configuration setups. It gives the benefit of managing the SPD along with the
  IKE that Strongswan offers. IPv6, transport/tunnel mode (ESP/AH), PSK/X509
- auth and basic 'anonymous' VPN server are supported.
+ auth and basic "anonymous" VPN server are supported.
  .
- More information is available in /usr/share/doc/racoon/README.Debian
+ More information is available in /usr/share/doc/racoon/README.Debian.

Standard quoting and final sentence dot.

I also wonder whether it would make sense to explain the "SPD" acronym....:)


-- 


Template: racoon/config_mode
Type: select
__Choices: direct, racoon-tool
Default: direct
_Description: Configuration mode for racoon IKE daemon:
 Racoon can be configured two ways, either by directly editing
 /etc/racoon/racoon.conf or using the racoon-tool administrative front end.
 .
 Use of the "direct" method is strongly recommended if you want to use all
 the racoon examples on the Net, and if you want to use the full
 racoon features set. You will have to directly edit /etc/racoon/racoon.conf and possibly
 manually set up the SPD via setkey.
 .
 Racoon-tool has been refreshed for racoon 0.8.0, and is for use in basic
 configuration setups. It gives the benefit of managing the SPD along with the
 IKE that Strongswan offers. IPv6, transport/tunnel mode (ESP/AH), PSK/X509
 auth and basic "anonymous" VPN server are supported.
 .
 More information is available in /usr/share/doc/racoon/README.Debian.
--- ipsec-tools.old/debian/racoon.templates	2012-06-16 13:01:04.066652712 +0200
+++ ipsec-tools/debian/racoon.templates	2012-06-16 15:37:42.975451785 +0200
@@ -1,22 +1,19 @@
 Template: racoon/config_mode
 Type: select
 __Choices: direct, racoon-tool
-# The above choices have to be left as they are as the values are used directly
-# in the postinst script.  They do not need translation.
-# Please explain what they are in any rewritten description.
 Default: direct
-_Description: Configuration mode for racoon IKE daemon.
+_Description: Configuration mode for racoon IKE daemon:
  Racoon can be configured two ways, either by directly editing
  /etc/racoon/racoon.conf or using the racoon-tool administrative front end.
  .
  Use of the "direct" method is strongly recommended if you want to use all
- the racoon examples on the Net, and if you want to use the fuul racoon feature
- set.  You will have to directly edit /etc/racoon/racoon.conf and possibly
+ the racoon examples on the Net, and if you want to use the full
+ racoon features set. You will have to directly edit /etc/racoon/racoon.conf and possibly
  manually set up the SPD via setkey.
  .
  Racoon-tool has been refreshed for racoon 0.8.0, and is for use in basic
  configuration setups. It gives the benefit of managing the SPD along with the
  IKE that Strongswan offers. IPv6, transport/tunnel mode (ESP/AH), PSK/X509
- auth and basic 'anonymous' VPN server are supported.
+ auth and basic "anonymous" VPN server are supported.
  .
- More information is available in /usr/share/doc/racoon/README.Debian
+ More information is available in /usr/share/doc/racoon/README.Debian.
Source: ipsec-tools
Section: net
Priority: extra
Maintainer: Matthew Grant <matthewgrant5@gmail.com>
Build-Depends: debhelper (>=7.0.50~), flex, bison, libkrb5-dev, libssl-dev (>= 0.9.6), libpam0g-dev, po-debconf, chrpath, hardening-wrapper, libldap2-dev
Standards-Version: 3.9.3
Vcs-Git: git://anonscm.debian.org/collab-maint/ipsec-tools.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/ipsec-tools.git
Homepage: http://ipsec-tools.sourceforge.net/

Package: ipsec-tools
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: IPsec tools for Linux
 IPsec-Tools is a port of the KAME IPsec utilities for Linux. It can be
 used with the ipsec implementation in 2.6 and later kernels or with
 the 2.4 backport of the ipsec changes.

Package: racoon
Architecture: any
Provides: ike-server
Conflicts: ike-server
Depends: ${misc:Depends}, ${shlibs:Depends}, ipsec-tools (= ${binary:Version}), debconf (>= 0.2.26) | debconf-2.0, adduser, ${perl:Depends}
Description: IPsec IKE keying daemon
 racoon is the KAME IKE (ipsec key exchange) server. It can be used with
 the Linux ipsec implementation in 2.6 and later kernels or with
 the 2.4 backport of the ipsec changes.

Attachment: signature.asc
Description: Digital signature


Reply to: