[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#675237: [RFR] templates://nginx/{nginx-naxsi-ui.templates}



Quoting Justin B Rye (jbr@edlug.org.uk):
> Christian PERRIER wrote:
> > Your review should be sent as an answer to this mail.
> 
> Hmm, this smells familiar.  Aha, yes -
>  http://lists.debian.org/debian-l10n-english/2012/05/msg00002.html
> (You'd think a name like nginx-naxsi-ui would be harder to forget.)

Oh, doh, forgot about that!

Then, apparently, the maintainer forgot about doing a proper call for
translations, then, which is what made me discover these "new"
templates (because they had no translations....except in French : and
French needs some improvements anyway).

> 
> >  _Description: Database host for naxsi:
> > - Please specify the hostname of the server where the naxsi Web Application
> > - Firewall's database should be located.
> > + Please specify the hostname of the server that will host the database
> > + for the naxsi web application firewall.
> > 
> > Rephrase to avoid the possessive form that (imho) looks weird.
> 
> As a matter of fact that does look like an improvement!
> 
> > I didn't review the package descriptions in debian/control.
> 
> Been there, done that!

OK, then we consider it reviewed.

What about the templates file? Shall we go with the current version in
the package (that has been reviewed by us) or what I proposed
(reviewed by us, then by me..:-))?

Attachment: signature.asc
Description: Digital signature


Reply to: