Please find, for review, the debconf templates and packages descriptions for the graphite-carbon source package.
This review will last from Wednesday, April 18, 2012 to Saturday, April 28, 2012.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
(I had hard times understading what the package is exactly about as I
was working offline. It often is a proof that more information is
needed....What is "Graphite"? What is a "Twisted daemon"? etc.
Still, several of my proposal do not depend on such information. I
still feel that the package description needs to be completed, though.
--- graphite-carbon.old/debian/graphite-carbon.templates 2012-04-14 07:31:47.490447027 +0200
+++ graphite-carbon/debian/graphite-carbon.templates 2012-04-18 07:21:03.580285407 +0200
@@ -1,9 +1,10 @@
Template: graphite-carbon/postrm_remove_databases
Type: boolean
Default: false
-_Description: Should whisper database files removed then package is purged?
- The directory /var/lib/graphite/whisper contains the whisper database
+_Description: Remove whisper database files when purging the package?
+ The /var/lib/graphite/whisper directory contains the whisper database
files.
.
- If you are removing Carbon package in order to later install a more
- recent version the data should be kept.
+ You may want to keep these database files even if you completely
+ remove the Carbon package, in case you plan to install another version
+ later on.
Drop the "should" which is a common trick in such case. Change the
synopsis into something at least grammatically correct..:-)
Change "The directory foo" into "the foo directory".....
Reword the second paagraph.
--- graphite-carbon.old/debian/control 2012-04-14 07:31:47.490447027 +0200
+++ graphite-carbon/debian/control 2012-04-18 07:21:47.777289722 +0200
@@ -15,7 +15,8 @@
${misc:Depends},
${python:Depends}
Description: backend data caching and persistence daemon for Graphite
- Carbon is an Twisted daemon that process incoming time-series
+ Carbon is an daemon that processes incoming time-series
data and saves that data as Whisper database files on disc.
.
- Carbon daemon is needed for an fully functional graphite-web app.
+ The Carbon daemon is mandatory for an fully functional Graphite
+ web application.
As I had no idea of what is a "twisted" daemon, I just dropped that
information. AFter all, this is not really vital.....unless some more
contexte is given.
Avoid "web-app" that is jargon. Still it woul db einteresting to
mention what is Graphite, here....
--
Template: graphite-carbon/postrm_remove_databases Type: boolean Default: false _Description: Remove whisper database files when purging the package? The /var/lib/graphite/whisper directory contains the whisper database files. . You may want to keep these database files even if you completely remove the Carbon package, in case you plan to install another version later on.
--- graphite-carbon.old/debian/graphite-carbon.templates 2012-04-14 07:31:47.490447027 +0200
+++ graphite-carbon/debian/graphite-carbon.templates 2012-04-18 07:21:03.580285407 +0200
@@ -1,9 +1,10 @@
Template: graphite-carbon/postrm_remove_databases
Type: boolean
Default: false
-_Description: Should whisper database files removed then package is purged?
- The directory /var/lib/graphite/whisper contains the whisper database
+_Description: Remove whisper database files when purging the package?
+ The /var/lib/graphite/whisper directory contains the whisper database
files.
.
- If you are removing Carbon package in order to later install a more
- recent version the data should be kept.
+ You may want to keep these database files even if you completely
+ remove the Carbon package, in case you plan to install another version
+ later on.
--- graphite-carbon.old/debian/control 2012-04-14 07:31:47.490447027 +0200
+++ graphite-carbon/debian/control 2012-04-18 07:21:47.777289722 +0200
@@ -15,7 +15,8 @@
${misc:Depends},
${python:Depends}
Description: backend data caching and persistence daemon for Graphite
- Carbon is an Twisted daemon that process incoming time-series
+ Carbon is an daemon that processes incoming time-series
data and saves that data as Whisper database files on disc.
.
- Carbon daemon is needed for an fully functional graphite-web app.
+ The Carbon daemon is mandatory for an fully functional Graphite
+ web application.
Source: graphite-carbon
Section: utils
Priority: optional
Maintainer: Jonas Genannt <jonas.genannt@capi2name.de>
Build-Depends: debhelper (>= 8), python-all (>= 2.6.6-3~)
Standards-Version: 3.9.3
DM-Upload-Allowed: yes
Homepage: https://launchpad.net/graphite
Package: graphite-carbon
Architecture: all
Depends: adduser,
python-twisted-core,
python-whisper,
${misc:Depends},
${python:Depends}
Description: backend data caching and persistence daemon for Graphite
Carbon is an daemon that processes incoming time-series
data and saves that data as Whisper database files on disc.
.
The Carbon daemon is mandatory for an fully functional Graphite
web application.
Attachment:
signature.asc
Description: Digital signature