Please find, for review, the debconf templates and packages descriptions for the xfonts-traditional source package.
This review will last from Thursday, February 09, 2012 to Sunday, February 19, 2012.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- xfonts-traditional.old/debian/xfonts-traditional.templates 2012-02-02 22:26:54.913955741 +0100
+++ xfonts-traditional/debian/xfonts-traditional.templates 2012-02-09 08:11:49.279050419 +0100
@@ -2,27 +2,27 @@
Type: boolean
Default: true
_Description: Generate traditional versions of fonts?
- xfonts-traditional can automatically generate traditional versions
- (with foundry "Trad" instead of "Misc" of all fonts for which it has
- an idea about the glyphs. (Currently this is versions of 6x13, aka
- "fixed").
+ It is possible to generate traditional versions
+ (with foundry "Trad" instead of "Misc") of all fonts when it is
+ possible to figure out what has to be done for glyphs.
+ This can be done currently for 6x13, aka "fixed".
.
- But you may prefer not to do this automatically, and would rather
+ You may prefer not to do this automatically, and would rather
just have the tool installed.
Here, I tried to avoid the leading lowercase implied by using the
package name as first sentence word. I'm not entirely happy with the
result as it involves passive form....but I prefer this over a version
where it seems that packages do things or can "have an idea" about things,
while this is indeed the maintainer scripts...or the maintainer himself..:-)
Template: xfonts-traditional/reconfigure-xterm
Type: boolean
Default: false
-_Description: Configure xterm to use traditional font?
+_Description: Configure xterm to use a traditional font?
You can have the xterm default UTF-8 font changed to the traditional
version.
.
- If you approve, I will edit /etc/X11/app-default/XTerm for you, and
- save your old file as XTerm.backup.not-trad. (Note that this is a
- conffile so you may get prompts from dpkg about it in the future.)
+ If you choose this option, /etc/X11/app-default/XTerm will be modified
+ and the old file will be kept as XTerm.backup.not-trad. As this file is a
+ configuration file, you may get prompts from dpkg about it in the future.
.
- Alternatively, if you do not want me to change the default, I will
- generate XTerm.trad for you to do what you like with.
+ Alternatively, if you do not want to change the default, XTerm.trad
+ will be created but not used.
.
To revert the change, simply change the key "*VT100.utf8Fonts.font"
back from "-trad-..." to "-misc-...", or rename the old file back
Synopsis: article or not article? I'm balanced. As a french person, I
tend to ass an article. Would this package maintainer be Japanese, I
would say he's wrong by not using an article..:-).... But he is a
native speaker, so he might be right. We need another native speaker
to give an advice.
Other changes are trying to avoid a very lengthy parenthesis and first
person use.
@@ -32,28 +32,26 @@
Type: boolean
Default: false
_Description: Configure system to use traditional "fixed"?
- You can have the font alias "fixed" remapped to the traditional version.
+ The "fixed" font alias can be remapped to the traditional version.
.
- If you approve, I will edit /etc/X11/fonts/misc/xfonts-base.alias for
- you, and save your old file as xfonts-base.alias.backup.not-trad.
- (Note that this is a conffile so you may get prompts from dpkg about
- it in the future.)
+ If you choose this option, /etc/X11/fonts/misc/xfonts-base.alias
+ will be modified and the old file will be kept as xfonts-base.alias.backup.not-trad.
+ As this file is a configuration file, you may get prompts from dpkg about it in the future.
.
- Alternatively, if you do not want me to change the default, I will
- generate xfonts-base-alias.trad for you to do what you like with.
+ Alternatively, if you do not want to change the default, xfonts-base-alias.trad
+ will be created but not used.
.
- To revert the change to the default, simply change the alias "fixed"
+ To revert the change, simply change the alias "fixed"
back from "-trad-..." to "-misc-...", or rename the old file back
into place.
Mostly style changes or avoiding first person use.
Template: xfonts-traditional/confirm-break-remove
Type: boolean
Default: false
-_Description: Remove anyway, breaking "fixed" and your X server?
- Removing xfonts-traditional would break your X server by removing "fixed".
+_Description: Remove xfonts-traditional, breaking "fixed" and the X server?
+ Removing xfonts-traditional would break the X server by removing "fixed".
.
You should not remove xfonts-traditional while "fixed" refers to one
- of its fonts. You probably want to check the differences between the
+ of its fonts. You first need to check the differences between the
various /etc/X11/fonts/misc/xfonts-base.alias*, reconcile any changes,
- and then run "update-fonts-alias misc". After that you can retry the
- removal.
+ and then run "update-fonts-alias misc".
Remind the package name in synopsis, in case the removal question
happens to show up among other debconf questions, if the removal
happens during a b ig purge of many packages?
Dropping the last sentence that sems useless to me.
--- xfonts-traditional.old/debian/control 2012-02-02 22:26:54.913955741 +0100
+++ xfonts-traditional/debian/control 2012-02-04 14:36:33.292666888 +0100
@@ -8,8 +8,8 @@
Package: xfonts-traditional
Architecture: all
Depends: xfonts-utils, pcf2bdf, libsys-cpu-perl, ${misc:Depends}, ${perl:Depends}
-Description: Traditional fixed-width fonts for X
- Provides "traditional" versions of fixed-width fonts.
+Description: traditional fixed-width fonts for X
+ This package provides "traditional" versions of fixed-width fonts.
.
These are a set of 6x13 fonts (including "fixed"), with foundry name
"trad" instead of "misc", with several glyphs replaced with earlier
uncapitalization
Use a "This package <blabla>" style.
@@ -22,14 +22,14 @@
- traditional appearance of W a
.
These changes make the fonts compatible with the US-ASCII character
- set. (UTF-8 is not compatible with ASCII in its usage of the
- backquote and some other characters.) With these fonts, pre-2000
+ set, as UTF-8 is not compatible with ASCII in its usage of the
+ backquote and some other characters. With these fonts, pre-2000
documents (including ASCII art and GNU manuals) will render
correctly.
.
- Optionally, this package will edit your system configuration to make
+ Optionally, this package will edit the system's configuration to make
the default fonts used by xterm refer to the traditional font.
Unpersonnalize.
.
- (This package does not actually contain the bulk of the font data;
+ This package does not actually contain the bulk of the font data;
rather, it automatically generates the required modified fonts for
- each relevant font you have installed.)
+ each installed relevant font.
Avoid a full paragraph inside parenthesis
--
Template: xfonts-traditional/generate Type: boolean Default: true _Description: Generate traditional versions of fonts? It is possible to generate traditional versions (with foundry "Trad" instead of "Misc") of all fonts when it is possible to figure out what has to be done for glyphs. This can be done currently for 6x13, aka "fixed". . You may prefer not to do this automatically, and would rather just have the tool installed. Template: xfonts-traditional/reconfigure-xterm Type: boolean Default: false _Description: Configure xterm to use a traditional font? You can have the xterm default UTF-8 font changed to the traditional version. . If you choose this option, /etc/X11/app-default/XTerm will be modified and the old file will be kept as XTerm.backup.not-trad. As this file is a configuration file, you may get prompts from dpkg about it in the future. . Alternatively, if you do not want to change the default, XTerm.trad will be created but not used. . To revert the change, simply change the key "*VT100.utf8Fonts.font" back from "-trad-..." to "-misc-...", or rename the old file back into place. Template: xfonts-traditional/remap-fixed Type: boolean Default: false _Description: Configure system to use traditional "fixed"? The "fixed" font alias can be remapped to the traditional version. . If you choose this option, /etc/X11/fonts/misc/xfonts-base.alias will be modified and the old file will be kept as xfonts-base.alias.backup.not-trad. As this file is a configuration file, you may get prompts from dpkg about it in the future. . Alternatively, if you do not want to change the default, xfonts-base-alias.trad will be created but not used. . To revert the change, simply change the alias "fixed" back from "-trad-..." to "-misc-...", or rename the old file back into place. Template: xfonts-traditional/confirm-break-remove Type: boolean Default: false _Description: Remove xfonts-traditional, breaking "fixed" and the X server? Removing xfonts-traditional would break the X server by removing "fixed". . You should not remove xfonts-traditional while "fixed" refers to one of its fonts. You first need to check the differences between the various /etc/X11/fonts/misc/xfonts-base.alias*, reconcile any changes, and then run "update-fonts-alias misc".
--- xfonts-traditional.old/debian/xfonts-traditional.templates 2012-02-02 22:26:54.913955741 +0100
+++ xfonts-traditional/debian/xfonts-traditional.templates 2012-02-09 08:11:49.279050419 +0100
@@ -2,27 +2,27 @@
Type: boolean
Default: true
_Description: Generate traditional versions of fonts?
- xfonts-traditional can automatically generate traditional versions
- (with foundry "Trad" instead of "Misc" of all fonts for which it has
- an idea about the glyphs. (Currently this is versions of 6x13, aka
- "fixed").
+ It is possible to generate traditional versions
+ (with foundry "Trad" instead of "Misc") of all fonts when it is
+ possible to figure out what has to be done for glyphs.
+ This can be done currently for 6x13, aka "fixed".
.
- But you may prefer not to do this automatically, and would rather
+ You may prefer not to do this automatically, and would rather
just have the tool installed.
Template: xfonts-traditional/reconfigure-xterm
Type: boolean
Default: false
-_Description: Configure xterm to use traditional font?
+_Description: Configure xterm to use a traditional font?
You can have the xterm default UTF-8 font changed to the traditional
version.
.
- If you approve, I will edit /etc/X11/app-default/XTerm for you, and
- save your old file as XTerm.backup.not-trad. (Note that this is a
- conffile so you may get prompts from dpkg about it in the future.)
+ If you choose this option, /etc/X11/app-default/XTerm will be modified
+ and the old file will be kept as XTerm.backup.not-trad. As this file is a
+ configuration file, you may get prompts from dpkg about it in the future.
.
- Alternatively, if you do not want me to change the default, I will
- generate XTerm.trad for you to do what you like with.
+ Alternatively, if you do not want to change the default, XTerm.trad
+ will be created but not used.
.
To revert the change, simply change the key "*VT100.utf8Fonts.font"
back from "-trad-..." to "-misc-...", or rename the old file back
@@ -32,28 +32,26 @@
Type: boolean
Default: false
_Description: Configure system to use traditional "fixed"?
- You can have the font alias "fixed" remapped to the traditional version.
+ The "fixed" font alias can be remapped to the traditional version.
.
- If you approve, I will edit /etc/X11/fonts/misc/xfonts-base.alias for
- you, and save your old file as xfonts-base.alias.backup.not-trad.
- (Note that this is a conffile so you may get prompts from dpkg about
- it in the future.)
+ If you choose this option, /etc/X11/fonts/misc/xfonts-base.alias
+ will be modified and the old file will be kept as xfonts-base.alias.backup.not-trad.
+ As this file is a configuration file, you may get prompts from dpkg about it in the future.
.
- Alternatively, if you do not want me to change the default, I will
- generate xfonts-base-alias.trad for you to do what you like with.
+ Alternatively, if you do not want to change the default, xfonts-base-alias.trad
+ will be created but not used.
.
- To revert the change to the default, simply change the alias "fixed"
+ To revert the change, simply change the alias "fixed"
back from "-trad-..." to "-misc-...", or rename the old file back
into place.
Template: xfonts-traditional/confirm-break-remove
Type: boolean
Default: false
-_Description: Remove anyway, breaking "fixed" and your X server?
- Removing xfonts-traditional would break your X server by removing "fixed".
+_Description: Remove xfonts-traditional, breaking "fixed" and the X server?
+ Removing xfonts-traditional would break the X server by removing "fixed".
.
You should not remove xfonts-traditional while "fixed" refers to one
- of its fonts. You probably want to check the differences between the
+ of its fonts. You first need to check the differences between the
various /etc/X11/fonts/misc/xfonts-base.alias*, reconcile any changes,
- and then run "update-fonts-alias misc". After that you can retry the
- removal.
+ and then run "update-fonts-alias misc".
--- xfonts-traditional.old/debian/control 2012-02-02 22:26:54.913955741 +0100
+++ xfonts-traditional/debian/control 2012-02-04 14:36:33.292666888 +0100
@@ -8,8 +8,8 @@
Package: xfonts-traditional
Architecture: all
Depends: xfonts-utils, pcf2bdf, libsys-cpu-perl, ${misc:Depends}, ${perl:Depends}
-Description: Traditional fixed-width fonts for X
- Provides "traditional" versions of fixed-width fonts.
+Description: traditional fixed-width fonts for X
+ This package provides "traditional" versions of fixed-width fonts.
.
These are a set of 6x13 fonts (including "fixed"), with foundry name
"trad" instead of "misc", with several glyphs replaced with earlier
@@ -22,14 +22,14 @@
- traditional appearance of W a
.
These changes make the fonts compatible with the US-ASCII character
- set. (UTF-8 is not compatible with ASCII in its usage of the
- backquote and some other characters.) With these fonts, pre-2000
+ set, as UTF-8 is not compatible with ASCII in its usage of the
+ backquote and some other characters. With these fonts, pre-2000
documents (including ASCII art and GNU manuals) will render
correctly.
.
- Optionally, this package will edit your system configuration to make
+ Optionally, this package will edit the system's configuration to make
the default fonts used by xterm refer to the traditional font.
.
- (This package does not actually contain the bulk of the font data;
+ This package does not actually contain the bulk of the font data;
rather, it automatically generates the required modified fonts for
- each relevant font you have installed.)
+ each installed relevant font.
Source: xfonts-traditional
Maintainer: Ian Jackson <ijackson@chiark.greenend.org.uk>
Section: x11
Priority: optional
Standards-Version: 3.9.2.0
Build-Depends: xfonts-utils, pcf2bdf, debhelper (>=8), po-debconf
Package: xfonts-traditional
Architecture: all
Depends: xfonts-utils, pcf2bdf, libsys-cpu-perl, ${misc:Depends}, ${perl:Depends}
Description: traditional fixed-width fonts for X
This package provides "traditional" versions of fixed-width fonts.
.
These are a set of 6x13 fonts (including "fixed"), with foundry name
"trad" instead of "misc", with several glyphs replaced with earlier
versions from before Markus Kuhn's changes:
- balanced ` '
- less tall [ ] ( ) { }
- centred *
- high ~
- slightly higher &
- traditional appearance of W a
.
These changes make the fonts compatible with the US-ASCII character
set, as UTF-8 is not compatible with ASCII in its usage of the
backquote and some other characters. With these fonts, pre-2000
documents (including ASCII art and GNU manuals) will render
correctly.
.
Optionally, this package will edit the system's configuration to make
the default fonts used by xterm refer to the traditional font.
.
This package does not actually contain the bulk of the font data;
rather, it automatically generates the required modified fonts for
each installed relevant font.
Attachment:
signature.asc
Description: Digital signature