[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://lxc/{lxc.templates}



Please find, for review, the debconf templates and packages descriptions for the lxc source package.

This review will last from Sunday, October 02, 2011 to Wednesday, October 12, 2011.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- lxc.old/debian/lxc.templates	2011-09-23 08:11:28.366526682 +0200
+++ lxc/debian/lxc.templates	2011-09-28 07:18:51.307192316 +0200
@@ -1,13 +1,22 @@
+# These templates have been reviewed by the debian-l10n-english
+# team
+#
+# If modifications/additions/rewording are needed, please ask
+# debian-l10n-english@lists.debian.org for advice.
+#
+# Even minor modifications require translation updates and such
+# changes should be coordinated with translators and reviewers.
+
 Template: lxc/title
 Type: title
-_Description: Linux Container (LXC)
+_Description: Linux Containers (LXC) setup

As this is the dialogs' title, let's be explicit
 
 Template: lxc/auto
 Type: boolean
 Default: true
-_Description: Linux Container: Automatic start and stop
- Linux Containers that have their configuration files copied or symlinked
- to the /etc/lxc/auto directory can be automatically started during system
- boot and shutdown on reboot/halt.
+_Description: Automatically start Linux Containers on boot?
+ Linux Containers can be automatically started during system
+ boot and shut down on reboot/halt.

This should be a question.

"on boot" or "at boot"? I have a doubt.

I don't think that gory details (symlinks, etc.) are really important,
so moving them at second paragraph. What's asked is whether one wants
to lxc to be started on boot, that's all.

  .
- If unsure, choose yes (default).
+ If you choose this option, the needed symlinks will be created in
+ the /etc/lxc/auto directory.

Never tell what's the default. You never know. This is the default at
first run, but if "false" was previously chosen, then it's the
default.

Never use "yes/no" references. Some interfaces do not use Yes/No choices.

We usually discourage the "if in doubt" suggestions. It's obvious this
is what defaults are for..:-)

--- lxc.old/debian/control	2011-09-23 08:11:28.366526682 +0200
+++ lxc/debian/control	2011-09-28 07:22:04.487862302 +0200
@@ -12,13 +12,13 @@
 Architecture: linux-any
 Depends: ${misc:Depends}, ${shlibs:Depends}
 Recommends: debootstrap, libcap2-bin
-Description: Linux containers userspace tools
+Description: Linux Containers userspace tools

Consistency for capitalization

  Containers are insulated areas inside a system, which have their own namespace
- for filesystem, network, pids, ipc, cpu and memory allocation and which can be
- created using the Control Group and Namespace features included in recent Linux
+ for file systems, network, PID, ipc, CPU and memory allocation and which can be
+ created using the Control Group and Namespace features included in Linux
  Kernels.

s/filesystem/file system

Capitalize acronyms.

I have a doubt for "control group" and "namespace" to be capitalized.

  .
- This package contains the lxc-* tools which can be used to start a single
+ This package provides the lxc-* tools which can be used to start a single
  daemon in a container, or to boot an entire "containerized" system, and to
  successively manage and debug your containers.

s/contains/provides is a common change we suggest
 

Other changes are similar...

# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# debian-l10n-english@lists.debian.org for advice.
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: lxc/title
Type: title
_Description: Linux Containers (LXC) setup

Template: lxc/auto
Type: boolean
Default: true
_Description: Automatically start Linux Containers on boot?
 Linux Containers can be automatically started during system
 boot and shut down on reboot/halt.
 .
 If you choose this option, the needed symlinks will be created in
 the /etc/lxc/auto directory.
--- lxc.old/debian/lxc.templates	2011-09-23 08:11:28.366526682 +0200
+++ lxc/debian/lxc.templates	2011-10-02 11:40:04.820991375 +0200
@@ -1,13 +1,22 @@
+# These templates have been reviewed by the debian-l10n-english
+# team
+#
+# If modifications/additions/rewording are needed, please ask
+# debian-l10n-english@lists.debian.org for advice.
+#
+# Even minor modifications require translation updates and such
+# changes should be coordinated with translators and reviewers.
+
 Template: lxc/title
 Type: title
-_Description: Linux Container (LXC)
+_Description: Linux Containers (LXC) setup
 
 Template: lxc/auto
 Type: boolean
 Default: true
-_Description: Linux Container: Automatic start and stop
- Linux Containers that have their configuration files copied or symlinked
- to the /etc/lxc/auto directory can be automatically started during system
- boot and shutdown on reboot/halt.
+_Description: Automatically start Linux Containers on boot?
+ Linux Containers can be automatically started during system
+ boot and shut down on reboot/halt.
  .
- If unsure, choose yes (default).
+ If you choose this option, the needed symlinks will be created in
+ the /etc/lxc/auto directory.
--- lxc.old/debian/control	2011-09-23 08:11:28.366526682 +0200
+++ lxc/debian/control	2011-09-28 07:22:04.487862302 +0200
@@ -12,13 +12,13 @@
 Architecture: linux-any
 Depends: ${misc:Depends}, ${shlibs:Depends}
 Recommends: debootstrap, libcap2-bin
-Description: Linux containers userspace tools
+Description: Linux Containers userspace tools
  Containers are insulated areas inside a system, which have their own namespace
- for filesystem, network, pids, ipc, cpu and memory allocation and which can be
- created using the Control Group and Namespace features included in recent Linux
+ for file systems, network, PID, ipc, CPU and memory allocation and which can be
+ created using the Control Group and Namespace features included in Linux
  Kernels.
  .
- This package contains the lxc-* tools which can be used to start a single
+ This package provides the lxc-* tools which can be used to start a single
  daemon in a container, or to boot an entire "containerized" system, and to
  successively manage and debug your containers.
 
@@ -28,22 +28,22 @@
 Architecture: linux-any
 Depends:
  ${misc:Depends}, lxc (= ${binary:Version}), lxc-dev (= ${binary:Version})
-Description: Linux containers userspace tools (debug)
+Description: Linux containers userspace tools - debug
  Containers are insulated areas inside a system, which have their own namespace
- for filesystem, network, pids, ipc, cpu and memory allocation and which can be
- created using the Control Group and Namespace features included in recent Linux
+ for file systems, network, PID, ipc, CPU and memory allocation and which can be
+ created using the Control Group and Namespace features included in Linux
  Kernels.
  .
- This package contains the debugging symbols.
+ This package provides the debugging symbols for userspace tools.
 
 Package: lxc-dev
 Section: libdevel
 Architecture: linux-any
 Depends: ${misc:Depends}, lxc (= ${binary:Version})
-Description: Linux containers userspace tools (development)
+Description: Linux containers userspace tools - development files
  Containers are insulated areas inside a system, which have their own namespace
- for filesystem, network, pids, ipc, cpu and memory allocation and which can be
- created using the Control Group and Namespace features included in recent Linux
+ for file systems, network, PID, ipc, CPU and memory allocation and which can be
+ created using the Control Group and Namespace features included in Linux
  Kernels.
  .
- This package contains the development files.
+ This package provides the development files.
Source: lxc
Section: admin
Priority: optional
Maintainer: Daniel Baumann <daniel.baumann@progress-technologies.net>
Uploaders: Jonas Genannt <jonas.genannt@capi2name.de>
Build-Depends:
 debhelper (>= 8), autotools-dev, docbook-utils, libcap-dev, linux-libc-dev
Standards-Version: 3.9.2
Homepage: http://lxc.sourceforge.net/

Package: lxc
Architecture: linux-any
Depends: ${misc:Depends}, ${shlibs:Depends}
Recommends: debootstrap, libcap2-bin
Description: Linux Containers userspace tools
 Containers are insulated areas inside a system, which have their own namespace
 for file systems, network, PID, ipc, CPU and memory allocation and which can be
 created using the Control Group and Namespace features included in Linux
 Kernels.
 .
 This package provides the lxc-* tools which can be used to start a single
 daemon in a container, or to boot an entire "containerized" system, and to
 successively manage and debug your containers.

Package: lxc-dbg
Section: debug
Priority: extra
Architecture: linux-any
Depends:
 ${misc:Depends}, lxc (= ${binary:Version}), lxc-dev (= ${binary:Version})
Description: Linux containers userspace tools - debug
 Containers are insulated areas inside a system, which have their own namespace
 for file systems, network, PID, ipc, CPU and memory allocation and which can be
 created using the Control Group and Namespace features included in Linux
 Kernels.
 .
 This package provides the debugging symbols for userspace tools.

Package: lxc-dev
Section: libdevel
Architecture: linux-any
Depends: ${misc:Depends}, lxc (= ${binary:Version})
Description: Linux containers userspace tools - development files
 Containers are insulated areas inside a system, which have their own namespace
 for file systems, network, PID, ipc, CPU and memory allocation and which can be
 created using the Control Group and Namespace features included in Linux
 Kernels.
 .
 This package provides the development files.

Attachment: signature.asc
Description: Digital signature


Reply to: