On Tue, Aug 02, 2011 at 12:53:49PM +0100, Justin B Rye wrote: > > - Warning: enabled gravatar support will leak your git > > - repositories, directries and filenames in your git repro > > - via browser referrer to gravatar. > > + Enabling Gravatar support can reveal information about repositories, > > + directories and files via browser referrals to Gravatar. > > It's not immediately obvious that revealing information is a bad > thing; perhaps that should keep the word "leak"? Hum. I'd like the maintainer's opinion here - Jonas? For now, left the patch as it was. > [...] > > Description: modern Git web viewer > > Obviously there aren't any Git web viewers more than a few years old, > but "modern" is always a risky word to fossilise into a synopsis. > Can't we identify the features that distinguish it from less modern > ones and explicitly mention them? It looks like the big selling point > is that it's based on Catalyst, hence (FX: penny dropping) the name, > but I've no idea why that's a good thing... so I'll leave it for now. > > [...] > > Description: FastCGI / fcgi support for gitalist > > What's the difference between FastCGI and fcgi? Sometimes they are synonymous (as in Perl) and sometimes they are different implementations (as in Cherokee modules). I think in this case we can safely call it FastCGI since they really refer to the same technique. > Normally I'd suggest s/frontend/front-end/ as a compromise to the > version that's in the dictionaries (front end), but gitalist is > targeted at the kind of users likely to prefer the one-word spelling. Ack. Templates, control and patch attached with changes folded. -- Jonathan Wiltshire jmw@debian.org Debian Developer http://people.debian.org/~jmw 4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
--- /home/jona/debian/rewrite/gitalist/gitalist.old/debian/gitalist-common.templates 2011-07-28 08:38:05.000000000 +0100
+++ /home/jona/debian/rewrite/gitalist/gitalist/debian/gitalist-common.templates 2011-08-05 22:15:40.000000000 +0100
@@ -1,18 +1,19 @@
Template: gitalist/directory
Type: string
Default: /srv/git
-_Description: Directory where git repositories are stored:
- Please specify the directory where gitalist will serve the git
- repositories.
+_Description: Path to Git repositories:
+ Please specify the path from which gitalist should serve Git repositories.
.
- These git repositories have to be bare repositories.
+ These should be "bare" repositories.
Template: gitalist/gravatar
Type: boolean
Default: false
-_Description: Should gravatar support in gitalist enabled?
- Gravatar support in gitalist is disabled by default.
+_Description: Enable Gravatar support?
+ Gravatar is a web service associating user email addresses with "avatars".
+ It is independent of the gitalist upstream authors. The pages generated by
+ gitalist can show these "avatars" for users who have registered with Gravatar.
.
- Warning: enabled gravatar support will leak your git
- repositories, directries and filenames in your git repro
- via browser referrer to gravatar.
+ Gravatar support in gitalist is disabled by default because it can reveal
+ information about repositories, directories, and files via browser referrals
+ to the Gravatar service.
--- /home/jona/debian/rewrite/gitalist/gitalist.old/debian/control 2011-07-28 08:38:05.000000000 +0100
+++ /home/jona/debian/rewrite/gitalist/gitalist/debian/control 2011-08-05 22:18:25.000000000 +0100
@@ -92,8 +92,8 @@
libtry-tiny-perl
Description: modern Git web viewer
Gitalist is a web frontend for Git repositories based on code from gitweb.cgi
- and powered by Catalyst (see the libcatalyst-perl package). It extends gitweb
- with many advanced features, including:
+ and powered by Catalyst (see the libcatalyst-perl package). It extends
+ gitweb.cgi with many advanced features, including:
.
* Multiple repository support
* Multiple branch support
@@ -104,6 +104,9 @@
Package: gitalist-fastcgi
Architecture: all
Depends: ${misc:Depends}, ${perl:Depends}, gitalist-common (= ${binary:Version}), libfcgi-perl, libapache2-mod-fcgid | httpd
-Description: FastCGI / fcgi support for gitalist
+Description: modern Git web viewer - FastCGI support
+ Gitalist is a web frontend for Git repositories based on code from gitweb.cgi
+ and powered by Catalyst.
+ .
This package contains all necessary files for running gitalist
- as FastCGI module within an webserver like Apache.
+ as a FastCGI module within a webserver like Apache.
Source: gitalist
Section: perl
Priority: optional
Build-Depends: debhelper (>= 8)
Build-Depends-Indep: perl (>= 5.10),
git,
libjs-jquery,
libaliased-perl,
libcatalyst-action-rest-perl,
libcatalyst-controller-actionrole-perl,
libcatalyst-modules-perl (>= 0.15),
libcatalyst-perl (>= 5.80014),
libcatalyst-plugin-unicode-encoding-perl,
libcatalyst-view-component-subinclude-perl (>= 0.07),
libcatalyst-view-tt-perl (>= 0.34),
libconfig-general-perl,
libdatetime-perl,
libfile-copy-recursive-perl,
libfile-type-perl,
libfile-type-webimages-perl,
libfile-which-perl,
libgit-pure-perl (>= 0.47),
libhtml-parser-perl,
libipc-run-perl,
libjson-perl,
libjson-xs-perl,
liblist-moreutils-perl,
libmoose-perl,
libmoose-autobox-perl,
libmoosex-declare-perl (>= 0.32),
libmoosex-storage-perl,
libmoosex-types-common-perl,
libmoosex-types-iso8601-perl,
libmoosex-types-path-class-perl,
libmoosex-types-perl,
libnamespace-autoclean-perl,
libpath-class-perl (>= 0.17),
libsyntax-highlight-engine-kate-perl,
libtemplate-perl (>= 2.22),
libtemplate-plugin-cycle-perl,
libtemplate-plugin-utf8decode-perl,
libtest-utf8-perl,
libtest-deep-perl,
libtest-www-mechanize-catalyst-perl,
libwww-mechanize-treebuilder-perl,
libtry-tiny-perl,
perl (>= 5.10.1) | libtest-simple-perl (>= 0.88)
Maintainer: Jonas Genannt <jonas.genannt@capi2name.de>
Uploaders: Jonathan Yu <jawnsy@cpan.org>
Standards-Version: 3.9.2
Homepage: http://search.cpan.org/dist/Gitalist/
Package: gitalist-common
Architecture: all
Depends: ${misc:Depends}, ${perl:Depends},
git,
libjs-jquery,
libaliased-perl,
libcatalyst-perl (>= 5.80014),
libcatalyst-action-rest-perl,
libcatalyst-controller-actionrole-perl,
libcatalyst-modules-perl (>= 0.15),
libcatalyst-plugin-unicode-encoding-perl,
libcatalyst-view-component-subinclude-perl (>= 0.07),
libcatalyst-view-tt-perl (>= 0.34),
libconfig-general-perl,
libdatetime-perl,
libfile-copy-recursive-perl,
libfile-type-perl,
libfile-type-webimages-perl,
libfile-which-perl,
libgit-pure-perl (>= 0.47),
libhtml-parser-perl,
libipc-run-perl,
libjson-perl,
libjson-xs-perl,
liblist-moreutils-perl,
libmoose-autobox-perl,
libmoose-perl,
libmoosex-declare-perl (>= 0.32),
libmoosex-storage-perl,
libmoosex-types-common-perl,
libmoosex-types-iso8601-perl,
libmoosex-types-path-class-perl,
libmoosex-types-perl,
libnamespace-autoclean-perl,
libpath-class-perl (>= 0.17),
libsyntax-highlight-engine-kate-perl,
libtemplate-perl (>= 2.22),
libtemplate-plugin-utf8decode-perl,
libtemplate-plugin-cycle-perl,
libtry-tiny-perl
Description: modern Git web viewer
Gitalist is a web frontend for Git repositories based on code from gitweb.cgi
and powered by Catalyst (see the libcatalyst-perl package). It extends
gitweb.cgi with many advanced features, including:
.
* Multiple repository support
* Multiple branch support
* Commit comparisons
* Atom feeds
* Color coded commit history
Package: gitalist-fastcgi
Architecture: all
Depends: ${misc:Depends}, ${perl:Depends}, gitalist-common (= ${binary:Version}), libfcgi-perl, libapache2-mod-fcgid | httpd
Description: modern Git web viewer - FastCGI support
Gitalist is a web frontend for Git repositories based on code from gitweb.cgi
and powered by Catalyst.
.
This package contains all necessary files for running gitalist
as a FastCGI module within a webserver like Apache.
Template: gitalist/directory Type: string Default: /srv/git _Description: Path to Git repositories: Please specify the path from which gitalist should serve Git repositories. . These should be "bare" repositories. Template: gitalist/gravatar Type: boolean Default: false _Description: Enable Gravatar support? Gravatar is a web service associating user email addresses with "avatars". It is independent of the gitalist upstream authors. The pages generated by gitalist can show these "avatars" for users who have registered with Gravatar. . Gravatar support in gitalist is disabled by default because it can reveal information about repositories, directories, and files via browser referrals to the Gravatar service.
Attachment:
signature.asc
Description: Digital signature