[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://kumofs/{templates}



Please find, for review, the debconf templates and packages descriptions for the kumofs source package.

This review will last from Wednesday, October 20, 2010 to Saturday, October 30, 2010.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- kumofs.old/debian/templates	2010-10-20 06:09:02.066645587 +0200
+++ kumofs/debian/templates	2010-10-20 06:46:44.418606580 +0200
@@ -1,26 +1,30 @@
 Template: kumofs/select_components
 Type: multiselect
 Choices: kumo-manager, kumo-server, kumo-gateway
-_Description: Execute components you want
- Components you want to run at this host.
+_Description: Kumofs components to run on this host:
+ Please choose which of kumofs components you want to run on this
+ host.

Use standard synopsis style with a colon. Consequently use our usual
"Please choose" style for the long description.

Please note that I (as a user) have no bloody idea of what are these 3
components. A short explanation might help those who are not already
experienced users of Kumofs.

 
 Template: kumofs/manager_options
 Type: string
 Default: -l localhost
-_Description: kumo-manager command-line options:
- Specify kumo-manager command-line options.
- The default value is for single node environment.
+_Description: Command-line options for kumo-manager:
+ Please specify the command-line options to use with kumo-manager.
+ .
+ The default value is well adapted for a single-node setup.

Consistency with other packages writing style, mostly. This also helps
having a paragraph that will be common to the three similar templates.
 
--- kumofs.old/debian/control	2010-10-20 06:09:02.062645076 +0200
+++ kumofs/debian/control	2010-10-20 06:55:31.881675341 +0200
@@ -14,16 +14,16 @@
 Description: simple and fast distributed key-value store
  Kumofs is a simple and fast distributed key-value store. You can use
  a memcached client library to set, get, CAS or delete values from/into
- kumofs. Backend storage is Tokyo Cabinet and it will give you great
- performance.
+ kumofs. The backend storage is Tokyo Cabinet, which is targeted to improve
+ the performance.
  .
-  * Data is partitioned and replicated over multiple servers.
-  * Extreme single node performance; comparable with memcached.
-  * Both read and write performance got improved as servers added.
-  * Servers can be added without stopping the system.
-  * Servers can be added without modifying any configuration files.
-  * The system does not stop even if one or two servers crashed.
-  * The system does not stop to recover crashed servers.
-  * Automatic rebalancing support with a consistency control algorithm.
-  * Safe CAS operation support.
-  * memcached protocol support.
+ Main features of kumofs:
+  * data is partitioned and replicated over multiple servers;
+  * very high performance on single node systems; comparable with memcached;
+  * read and write performance improve when servers are added;
+  * servers can be added, restarted or removed on the fly without any
+    configuration change;
+  * includes an automatic rebalancing support with a consistency
+    control algorithm;
+  * includes safe CAS operation support;
+  * includes memcached protocol support.

Frankly speaking, even after reading that description, I have so real
idea of what this thing is about..:-)

OK, this is a "store" for "key-value" data. Fine.

But why is it good to have it on my system? Dunno. I looked around
briefly in the source, but couldn't get much more clue.

Also, I have no idea of what "to CAS" is as one is supposed to be able
to set, to get and....."to CAS".

So, indeed, my "improved" description is not really that improved. a
paragraph about what a "key-value store" is could help...

Anyway, other changes I propose are mostly  consistency of enumeration
with the established standard for this and a few style change, as an
attempt to make the enumeration style consistent (my result is not
perfect, though). I dropped a few repetitions, particularly about the
various on-the-fly features.


-- 



--- kumofs.old/debian/templates	2010-10-20 06:09:02.066645587 +0200
+++ kumofs/debian/templates	2010-10-20 06:46:44.418606580 +0200
@@ -1,26 +1,30 @@
 Template: kumofs/select_components
 Type: multiselect
 Choices: kumo-manager, kumo-server, kumo-gateway
-_Description: Execute components you want
- Components you want to run at this host.
+_Description: Kumofs components to run on this host:
+ Please choose which of kumofs components you want to run on this
+ host.
 
 Template: kumofs/manager_options
 Type: string
 Default: -l localhost
-_Description: kumo-manager command-line options:
- Specify kumo-manager command-line options.
- The default value is for single node environment.
+_Description: Command-line options for kumo-manager:
+ Please specify the command-line options to use with kumo-manager.
+ .
+ The default value is well adapted for a single-node setup.
 
 Template: kumofs/server_options
 Type: string
 Default: -m localhost -l localhost -s /var/lib/kumofs/kumofs.tch
-_Description: kumo-server command-line options:
- Specify kumo-server command-line options.
- The default value is for single node environment.
+_Description: Command-line options for kumo-server:
+ Please specify the command-line options to use with kumo-server.
+ .
+ The default value is well adapted for a single-node setup.
 
 Template: kumofs/gateway_options
 Type: string
 Default: -m localhost -t 11211
-_Description: kumo-gateway command-line options:
- Specify kumo-gateway command-line options.
- The default value is for single node environment.
+_Description: Command-line options for kumo-gateway:
+ Please specify the command-line options to use with kumo-gateway.
+ .
+ The default value is well adapted for a single-node setup.
--- kumofs.old/debian/control	2010-10-20 06:09:02.062645076 +0200
+++ kumofs/debian/control	2010-10-20 07:04:04.035576994 +0200
@@ -14,16 +14,16 @@
 Description: simple and fast distributed key-value store
  Kumofs is a simple and fast distributed key-value store. You can use
  a memcached client library to set, get, CAS or delete values from/into
- kumofs. Backend storage is Tokyo Cabinet and it will give you great
- performance.
+ kumofs. The backend storage is Tokyo Cabinet, which is targeted to improve
+ the performance.
  .
-  * Data is partitioned and replicated over multiple servers.
-  * Extreme single node performance; comparable with memcached.
-  * Both read and write performance got improved as servers added.
-  * Servers can be added without stopping the system.
-  * Servers can be added without modifying any configuration files.
-  * The system does not stop even if one or two servers crashed.
-  * The system does not stop to recover crashed servers.
-  * Automatic rebalancing support with a consistency control algorithm.
-  * Safe CAS operation support.
-  * memcached protocol support.
+ Main features of kumofs:
+  * data is partitioned and replicated over multiple servers;
+  * very high performance on single node systems; comparable with memcached;
+  * read and write performance improve when servers are added;
+  * servers can be added, restarted or removed on the fly without any
+    configuration change;
+  * includes an automatic rebalancing support with a consistency
+    control algorithm;
+  * includes safe CAS operation support;
+  * includes memcached protocol support.
Template: kumofs/select_components
Type: multiselect
Choices: kumo-manager, kumo-server, kumo-gateway
_Description: Kumofs components to run on this host:
 Please choose which of kumofs components you want to run on this
 host.

Template: kumofs/manager_options
Type: string
Default: -l localhost
_Description: Command-line options for kumo-manager:
 Please specify the command-line options to use with kumo-manager.
 .
 The default value is well adapted for a single-node setup.

Template: kumofs/server_options
Type: string
Default: -m localhost -l localhost -s /var/lib/kumofs/kumofs.tch
_Description: Command-line options for kumo-server:
 Please specify the command-line options to use with kumo-server.
 .
 The default value is well adapted for a single-node setup.

Template: kumofs/gateway_options
Type: string
Default: -m localhost -t 11211
_Description: Command-line options for kumo-gateway:
 Please specify the command-line options to use with kumo-gateway.
 .
 The default value is well adapted for a single-node setup.
Source: kumofs
Section: misc
Priority: extra
Maintainer: Taku YASUI <tach@debian.org>
Build-Depends: cdbs, debhelper (>= 7.0.50~), dpatch, po-debconf, autotools-dev, chrpath
Standards-Version: 3.9.1
Homepage: http://kumofs.sourceforge.net/
#Vcs-Git: git://git.debian.org/collab-maint/kumofs.git
#Vcs-Browser: http://git.debian.org/?p=collab-maint/kumofs.git;a=summary

Package: kumofs
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, ruby, libmsgpack-ruby1.8, adduser
Description: simple and fast distributed key-value store
 Kumofs is a simple and fast distributed key-value store. You can use
 a memcached client library to set, get, CAS or delete values from/into
 kumofs. The backend storage is Tokyo Cabinet, which is targeted to improve
 the performance.
 .
 Main features of kumofs:
  * data is partitioned and replicated over multiple servers;
  * very high performance on single node systems; comparable with memcached;
  * read and write performance improve when servers are added;
  * servers can be added, restarted or removed on the fly without any
    configuration change;
  * includes an automatic rebalancing support with a consistency
    control algorithm;
  * includes safe CAS operation support;
  * includes memcached protocol support.

Attachment: signature.asc
Description: Digital signature


Reply to: