Re: [RFR] templates://moodle/{templates}
Jonathan Wiltshire wrote:
> Your review should be sent as an answer to this mail.
You wait for weeks and then two come along at once.
> --- ../moodle.old/debian/templates 2010-06-23 12:22:47.000000000 +0100
> +++ debian/templates 2010-07-01 19:47:26.000000000 +0100
> @@ -1,7 +1,9 @@
> Template: moodle/www
> Type: string
> Default: http://localhost/moodle
> -_Description: Please enter the URL for the Moodle site:
> - Enter the URL you would like for your Moodle site. You will need to
> - configure Apache correctly, this package will only provide you with the
> - templates for Apache configs.
> +_Description: URL for the Moodle site:
> + Enter the URL that should be used to access the Moodle site.
>
> As usual, we don't refer to the second person in templates
It does seem a bit backwards that we're talking about what the user
doing the accessing "should" do (in the passive voice). Couldn't we
say something like:
Please enter the URL that Moodle should serve pages on.
(Or maybe "the URL on which Moodle should serve pages"?)
> + .
> + The installer will not configure your web server, but it
> + will provide a basic configuration template for the Apache
> + web server.
It's not necessarily "my" web server, and (thanks to
dpkg-reconfigure) the code may not be executing as an "installer".
.
Moodle does not perform any automatic web server configuration,
but does provide basic configuration templates for Apache.
> Package: moodle
> Architecture: all
> Depends: ${misc:Depends}, libapache2-mod-php5 | php5-cgi, php5-mysql | php5-pgsql, php5-gd, php5-curl, php5-cli, apache2-mpm-prefork | httpd, adduser, libdbi-perl, libdbd-mysql-perl, ucf, postgresql-client | mysql-client, unzip, zip, smarty, libjs-yui, libphp-magpierss (>= 0.72-8), dbconfig-common, php-fpdf, libphp-pclzip
> Pre-Depends: debconf (>= 0.5) | debconf-2.0
> Recommends: postgresql | mysql-server, php5-ldap, php5-xmlrpc, aspell, mimetex
> Suggests: clamav
> Description: Course Management System for Online Learning
c m s o l
But the long description looks fine (except that I seem to have
automatically trimmed some trailing whitespace).
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../moodle-1.9.8.pristine/debian/templates 2010-06-20 14:54:42.000000000 +0100
+++ debian/templates 2010-07-01 23:54:31.000000000 +0100
@@ -1,7 +1,8 @@
Template: moodle/www
Type: string
Default: http://localhost/moodle
-_Description: Please enter the URL for the Moodle site:
- Enter the URL you would like for your Moodle site. You will need to
- configure Apache correctly, this package will only provide you with the
- templates for Apache configs.
+_Description: URL for the Moodle site:
+ Please enter the URL that Moodle should serve pages on.
+ .
+ Moodle does not perform any automatic web server configuration,
+ but does provide basic configuration templates for Apache.
--- ../moodle-1.9.8.pristine/debian/control 2010-06-20 15:49:14.000000000 +0100
+++ debian/control 2010-07-01 23:55:14.000000000 +0100
@@ -15,8 +15,8 @@
Pre-Depends: debconf (>= 0.5) | debconf-2.0
Recommends: postgresql | mysql-server, php5-ldap, php5-xmlrpc, aspell, mimetex
Suggests: clamav
-Description: Course Management System for Online Learning
- Moodle (Modular Object-Oriented Dynamic Learning Environment) is a course
- management system - a software package designed to help educators create
- quality online courses. One of the main advantages of Moodle over other
+Description: course management system for online learning
+ Moodle (Modular Object-Oriented Dynamic Learning Environment) is a course
+ management system - a software package designed to help educators create
+ quality online courses. One of the main advantages of Moodle over other
systems is a strong grounding in social constructionist pedagogy.
Template: moodle/www
Type: string
Default: http://localhost/moodle
_Description: Moodle URL:
Please enter the URL that moodle should serve pages at. An
appropriate Apache configuration will need to be set up manually;
see README.Debian for details.
Source: moodle
Section: web
Priority: optional
Maintainer: Moodle Packaging Team <pkg-moodle-maintainers@lists.alioth.debian.org>
Uploaders: Penny Leach <penny@mjollnir.org>, Dan Poltawski <talktodan@gmail.com>, Xavier Oswald <xoswald@debian.org>, Tomasz Muras <nexor1984@gmail.com>
Build-Depends: debhelper (>= 7), quilt, po-debconf
Standards-Version: 3.8.4
Homepage: http://www.moodle.org/
Vcs-Git: git://git.debian.org/git/pkg-moodle/moodle.git
Vcs-Browser: http://git.debian.org/?p=pkg-moodle/moodle.git;a=summary
Package: moodle
Architecture: all
Depends: ${misc:Depends}, libapache2-mod-php5 | php5-cgi, php5-mysql | php5-pgsql, php5-gd, php5-curl, php5-cli, apache2-mpm-prefork | httpd, adduser, libdbi-perl, libdbd-mysql-perl, ucf, postgresql-client | mysql-client, unzip, zip, smarty, libjs-yui, libphp-magpierss (>= 0.72-8), dbconfig-common, php-fpdf, libphp-pclzip
Pre-Depends: debconf (>= 0.5) | debconf-2.0
Recommends: postgresql | mysql-server, php5-ldap, php5-xmlrpc, aspell, mimetex
Suggests: clamav
Description: course management system for online learning
Moodle (Modular Object-Oriented Dynamic Learning Environment) is a course
management system - a software package designed to help educators create
quality online courses. One of the main advantages of Moodle over other
systems is a strong grounding in social constructionist pedagogy.
Reply to: