[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://qmail/{qmail.templates}



Christian PERRIER wrote:
> Please find, for review, the debconf templates and packages descriptions for the qmail source package.

Here's a review of the control file (in annotated diff form).  As I
mentioned, there's also a control.real with further problems, but
that can wait. 

 --- control.pristine	2010-03-23 13:47:55.000000000 +0000
 +++ control.jbr	2010-03-23 13:47:06.000000000 +0000

 -Description: Source only package for building qmail binary package
 +Description: source for building the qmail binary package

It's not "source only"; it also contains an executable!  And
packages containing source need to be careful not to get too close
to saying they're "source packages".

 - qmail is a secure, reliable, efficient, simple mail transport system.
 + Qmail is a secure, reliable, efficient, simple mail transport system.

Using the canonical capitalisation for the upstream software project
as opposed to the Debian package.

   .
 - To build a binary deb package, first install the qmail-src package, then
 - type the command "build-qmail".  If you try "apt-get source --build qmail-src"
 - only the qmail-src package will be built.  You will need to install qmail-src
 - and type the command "build-qmail" to get a usable binary package of qmail.
 - Also be sure to build and install ucspi-tcp before installing the binary qmail
 - package.  Install the ucspi-tcp-src package to get ucspi-tcp.
 + To build a local binary package of qmail, first install this package, then
 + type the command "build-qmail". You will also need to use ucspi-tcp-src to
 + build ucspi-tcp, which is a dependency of qmail.

No need to give details of the wrong commandline!  And no need to
explain it twice.

   .
 - This package builds a binary .deb that is FHS compliant and conforms to the
 - Debian standards guidelines.  The resulting binary packages are not suitable
 - for re-distribution.
 + Packages built in this way are compliant with the FHS and Debian Policy,
 + but are not redistributable.

Just a bit less verbose.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Source: qmail
Maintainer: Jon Marler <jmarler@debian.org>
Section: non-free/mail
Priority: extra
Build-Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), fakeroot | sudo, groff-base, adduser, po-debconf
Standards-Version: 3.8.0

Package: qmail-src
Architecture: all
Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), build-essential, fakeroot | sudo, groff-base, adduser, libc6-dev
Conflicts: qmail-run, qmail-uids-gids
Recommends: ucspi-tcp-src, procmail
Description: source for building the qmail binary package
 Qmail is a secure, reliable, efficient, simple mail transport system.
 .
 To build a local binary package of qmail, first install this package, then
 type the command "build-qmail". You will also need to use ucspi-tcp-src to
 build ucspi-tcp, which is a dependency of qmail.
 .
 Packages built in this way are compliant with the FHS and Debian Policy,
 but are not redistributable.
--- control.pristine	2010-03-23 13:47:55.000000000 +0000
+++ control.jbr	2010-03-23 14:01:08.000000000 +0000
@@ -10,16 +10,12 @@
 Depends: dpkg-dev (>= 1.4.0.20), patch (>= 2.5-0bo1), build-essential, fakeroot | sudo, groff-base, adduser, libc6-dev
 Conflicts: qmail-run, qmail-uids-gids
 Recommends: ucspi-tcp-src, procmail
-Description: Source only package for building qmail binary package
- qmail is a secure, reliable, efficient, simple mail transport system.
+Description: source for building the qmail binary package
+ Qmail is a secure, reliable, efficient, simple mail transport system.
  .
- To build a binary deb package, first install the qmail-src package, then
- type the command "build-qmail".  If you try "apt-get source --build qmail-src"
- only the qmail-src package will be built.  You will need to install qmail-src
- and type the command "build-qmail" to get a usable binary package of qmail.
- Also be sure to build and install ucspi-tcp before installing the binary qmail
- package.  Install the ucspi-tcp-src package to get ucspi-tcp.
+ To build a local binary package of qmail, first install this package, then
+ type the command "build-qmail". You will also need to use ucspi-tcp-src to
+ build ucspi-tcp, which is a dependency of qmail.
  .
- This package builds a binary .deb that is FHS compliant and conforms to the
- Debian standards guidelines.  The resulting binary packages are not suitable
- for re-distribution.
+ Packages built in this way are compliant with the FHS and Debian Policy,
+ but are not redistributable.

Reply to: