[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://virtuoso-opensource/{virtuoso-opensource-6.1.templates,l ibvirtodbc0.templates}



Review of the control file to follow.

Christian PERRIER wrote:
> Rationale:
>  Template: virtuoso-opensource-6.1/dba-password         
[...]
>  _Description: Password for DBA and DAV users:
> - There are two default users (DBA and DAV) created with administrative
> - access to Virtuoso and you should now set secure passwords for these users
> + Two users (DBA and DAV) are created by default, with administrative
> + access to Virtuoso. Secure passwords must be chosen for these users
>   in order to complete the installation.

They're the DBA and DAV users, but apparently their usernames are
lowercase... so say
     Two users ("dba" and "dav") are created by default [...]

>  Template: virtuoso-opensource-6.1/error-setting-password
>  Type: error
> -_Description: Unable to set password for the Virtuoso 'dba' user
> +_Description: Unable to set password for the Virtuoso "dba" user

It's either the user "dba" or the DBA user (just as it's "the file
README.foo" when you're introducing its name but "the README file"
where you're identifying the file by its well-known name.)  Here I'd
go for:

   _Description: Unable to set password for the Virtuoso DBA user

[...]
> + It is recommended to check the passwords for
> + the "dba" and "dav" users immediately after installation.

This time,
    It is recommended to check the passwords for the users "dba" and "dav"
    immediately after installation.
  
>  Template: virtuoso-opensource-6.1/db-server-port
>  Type: string
>  Default: 1111
> -_Description: Default Database Server Port:
> +_Description: Default database server port:
>   You may change here the default port on which the Virtuoso database server
>   will listen for connections.
>   .
> - Sometimes it is better to use non-default ports to improve security on
> - servers that might be targets for unauthorised intrusion.

Wait... I see what the word "default" is doing in this sentence, but
it seems to have spread to the rest of the template (and the last
one) where it doesn't fit.  I'm not setting the _default_ port -
surely I'm setting the _only_ port it's allowed to use, until and
unless I reconfigure this configuration value?

So cut the word "[Dd]efault" all through the rest of the
http-server-port and db-server-port templates.

> + You may want to choose this option to improve security on
> + servers that might be targets for unauthorized intrusion.

Eliminate want.  "Choose this option"?

    Modifying this default value can improve security on servers that
    might be targets for unauthorized intrusion.
  
>  Template: virtuoso-opensource-6.1/register-odbc-dsn
>  Type: boolean
>  _Description: Do you want to register an ODBC System DSN for Virtuoso?
                                                 ^
   _Description: Register an ODBC system DSN for Virtuoso?

> - You appear to have an ODBC manager (unixodbc or iODBC) installed on your
> - system, and the Virtuoso ODBC driver is installed.

Given that the system may be a corporate asset, make that:
    An ODBC manager (unixodbc or iODBC) is already installed on this system,
    and the Virtuoso ODBC driver is installed.

>   If you wish, the default Virtuoso instance will be automatically added to
>   the list of available System Data Sources (and automatically deleted from
> + the list when this package is removed).

Debconf isn't powered by wishes.
    The default Virtuoso instance can be automatically added to the list of
    available System Data Sources (and automatically deleted from the list
    when this package is removed).
  
>  Template: virtuoso-opensource/primary-server
>  Type: select
>  Choices: ${choices}
> +_Description: Default Virtuoso server package:
>   Please choose the version of virtuoso-server that will be linked to by the
>   default (unversioned) names for init scripts and client tools.
                               ^,
Add a comma ("linked to by the default names, for the benefit of
init scripts", not "linked to by the default names _of_ the init
scripts").

Sounds like a job for /etc/alternatives, but I can see it might be
messy.

>  Template: libvirtodbc0/register-odbc-driver         
>  Type: boolean
>  Default: false
>  _Description: Do you want to register the Virtuoso ODBC driver?
> + An ODBC manager (unixodbc or iODBC) is apparently installed on this
>   system.
>   .
>   If you wish, the Virtuoso ODBC Driver will be automatically added to the
>   list of available ODBC drivers (and automatically deleted from the list
> + when this package is removed).

To match virtuoso-opensource-6.1/register-odbc-dsn:

   _Description: Register the Virtuoso ODBC driver?
    An ODBC manager (unixodbc or iODBC) is already installed on this system.
    .
    The Virtuoso ODBC driver can be automatically added to the list of
    available ODBC drivers (and automatically deleted from the list when
    this package is removed).

> PS: I didn't review debian/control

I'll look at that once I've had some coffee.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
Template: virtuoso-opensource-6.1/dba-password
Type: password
_Description: Password for DBA and DAV users:
 Following installation, users and passwords in Virtuoso can be managed
 using the command line tools (see the full documentation) or via
 the Conductor web application which is installed by default at
 http://localhost:8890/conductor.
 .
 Two users ("dba" and "dav") are created by default, with administrative
 access to Virtuoso. Secure passwords must be chosen for these users
 in order to complete the installation.
 .
 If you leave this blank, the daemon will be disabled
 unless a non-default password already exists.

Template: virtuoso-opensource-6.1/dba-password-again
Type: password
_Description: Administrative users password confirmation:

Template: virtuoso-opensource-6.1/password-mismatch
Type: error
_Description: Password mismatch
 The two passwords you entered were not the same. Please enter a
 password again.

Template: virtuoso-opensource-6.1/note-disabled
Type: note
_Description: No initial password set, daemon disabled
 For security reasons, the default Virtuoso instance is disabled because
 no administration password was provided.
 .
 You can enable the daemon manually by setting RUN to "yes" in
 /etc/default/virtuoso-opensource-6.1. The default DBA user
 password will then be "dba".

Template: virtuoso-opensource-6.1/error-setting-password
Type: error
_Description: Unable to set password for the Virtuoso DBA user
 An error occurred while setting the password for the Virtuoso
 administrative user. This may have happened because the account
 already has a password, or because of a communication problem with
 the Virtuoso server.
 .
 If the database already existed then it will have retained the original
 password. If there was some other problem then the default password
 ("dba") is used.
 .
 It is recommended to check the passwords for the users "dba" and "dav"
 immediately after installation. 

Template: virtuoso-opensource-6.1/check-remove-databases
Type: boolean
Default: false
_Description: Remove all Virtuoso databases?
 The /var/lib/virtuoso directory which contains the Virtuoso databases is
 about to be removed.
 .
 If you're removing the Virtuoso package in order to later install a more
 recent version, or if a different Virtuoso package is already using it,
 you can choose to keep databases.

Template: virtuoso-opensource-6.1/http-server-port
Type: string
Default: 8890
_Description: HTTP server port:
 Virtuoso provides a web server capable of hosting HTML and VSP pages
 (with optional support for other languages). If you are installing this
 instance as a public web server directly on the Internet, you probably want
 to choose 80 as web server port.
 .
 Please note that the default web server root directory is /var/lib/virtuoso/vsp and will be
 empty unless you also install the package containing the standard Virtuoso
 start page.

Template: virtuoso-opensource-6.1/db-server-port
Type: string
Default: 1111
_Description: Database server port:
 You may change here the port on which the Virtuoso database server will
 listen for connections.
 .
 Modifying this default value can improve security on servers that
 might be targets for unauthorized intrusion.         

Template: virtuoso-opensource-6.1/register-odbc-dsn
Type: boolean
Default: false
_Description: Register an ODBC system DSN for Virtuoso?
 An ODBC manager (unixodbc or iODBC) is already installed on this system,
 and the Virtuoso ODBC driver is installed.
 .
 The default Virtuoso instance can be automatically added to the list of
 available System Data Sources (and automatically deleted from the list
 when this package is removed).
 .
 If you choose this option, the DSN will be named "VOS". User and
 password details are omitted from the DSN for security reasons.

Template: virtuoso-opensource/primary-server
Type: select
Choices: ${choices}
_Description: Default Virtuoso server package:
 Please choose the version of virtuoso-server that will be linked to by the
 default (unversioned) names, for init scripts and client tools.
Template: libvirtodbc0/register-odbc-driver
Type: boolean
Default: false
_Description: Register the Virtuoso ODBC driver?
 An ODBC manager (unixodbc or iODBC)  is already installed on this system.
 .
 The Virtuoso ODBC driver can be automatically added to the list of
 available ODBC drivers (and automatically deleted from the list
 when this package is removed).
--- virtuoso-opensource-6.1.pristine/debian/virtuoso-opensource-6.1.templates	2010-02-27 11:37:08.000000000 +0000
+++ virtuoso-opensource-6.1/debian/virtuoso-opensource-6.1.templates	2010-03-01 09:53:48.000000000 +0000
@@ -3,39 +3,39 @@
 _Description: Password for DBA and DAV users:
  Following installation, users and passwords in Virtuoso can be managed
  using the command line tools (see the full documentation) or via
- the Conductor web application which is installed by default at:
+ the Conductor web application which is installed by default at
+ http://localhost:8890/conductor.
  .
- http://localhost:8890/conductor
+ Two users ("dba" and "dav") are created by default, with administrative
+ access to Virtuoso. Secure passwords must be chosen for these users
+ in order to complete the installation.
  .
- There are two default users (DBA and DAV) created with administrative
- access to Virtuoso and you should now set secure passwords for these users
- to complete the installation.
- .
- If you do not enter a new password the daemon will be disabled initially
- (unless a non-default password is found to already exist).
+ If you leave this blank, the daemon will be disabled
+ unless a non-default password already exists.
 
 Template: virtuoso-opensource-6.1/dba-password-again
 Type: password
-_Description: Repeat password for the admin users to confirm:
+_Description: Administrative users password confirmation:
 
 Template: virtuoso-opensource-6.1/password-mismatch
 Type: error
-_Description: Password confirmation error
- The two passwords you entered were not the same. Please try again.
+_Description: Password mismatch
+ The two passwords you entered were not the same. Please enter a
+ password again.
 
 Template: virtuoso-opensource-6.1/note-disabled
 Type: note
 _Description: No initial password set, daemon disabled
- For security reasons the default Virtuoso instance is disabled because
+ For security reasons, the default Virtuoso instance is disabled because
  no administration password was provided.
  .
- You can enable the daemon manually by setting RUN to 'yes' in the file
- /etc/default/virtuoso-opensource-6.1, in which case the default DBA user
- password will be 'dba'.
+ You can enable the daemon manually by setting RUN to "yes" in
+ /etc/default/virtuoso-opensource-6.1. The default DBA user
+ password will then be "dba".
 
 Template: virtuoso-opensource-6.1/error-setting-password
 Type: error
-_Description: Unable to set password for the Virtuoso 'dba' user
+_Description: Unable to set password for the Virtuoso DBA user
  An error occurred while setting the password for the Virtuoso
  administrative user. This may have happened because the account
  already has a password, or because of a communication problem with
@@ -43,10 +43,10 @@
  .
  If the database already existed then it will have retained the original
  password. If there was some other problem then the default password
- 'dba' (same as the username) will apply.
+ ("dba") is used.
  .
- You should check immediately following installation that both the
- 'dba' and 'dav' users have secure non-default passwords set.
+ It is recommended to check the passwords for the users "dba" and "dav"
+ immediately after installation. 
 
 Template: virtuoso-opensource-6.1/check-remove-databases
 Type: boolean
@@ -57,49 +57,48 @@
  .
  If you're removing the Virtuoso package in order to later install a more
  recent version, or if a different Virtuoso package is already using it,
- the data should be kept.
+ you can choose to keep databases.
 
 Template: virtuoso-opensource-6.1/http-server-port
 Type: string
 Default: 8890
-_Description: Default HTTP (Web) Server Port:
- Virtuoso incorporates a web server capable of hosting HTML and VSP pages
+_Description: HTTP server port:
+ Virtuoso provides a web server capable of hosting HTML and VSP pages
  (with optional support for other languages). If you are installing this
- instance as a public web server directly on the internet, you probably want
- to set the port here to the default 80 used for http:// addresses.
+ instance as a public web server directly on the Internet, you probably want
+ to choose 80 as web server port.
  .
- NB: The default web root is created at /var/lib/virtuoso/vsp and will be
+ Please note that the default web server root directory is /var/lib/virtuoso/vsp and will be
  empty unless you also install the package containing the standard Virtuoso
  start page.
 
 Template: virtuoso-opensource-6.1/db-server-port
 Type: string
 Default: 1111
-_Description: Default Database Server Port:
- You may change here the default port on which the Virtuoso database server
- will listen for connections.
+_Description: Database server port:
+ You may change here the port on which the Virtuoso database server will
+ listen for connections.
  .
- Sometimes it is better to use non-default ports to improve security on
- servers that might be targets for unauthorised intrusion.
+ Modifying this default value can improve security on servers that
+ might be targets for unauthorized intrusion.         
 
 Template: virtuoso-opensource-6.1/register-odbc-dsn
 Type: boolean
 Default: false
-_Description: Do you want to register an ODBC System DSN for Virtuoso?
- You appear to have an ODBC manager (unixodbc or iODBC) installed on your
- system, and the Virtuoso ODBC driver is installed.
- .
- If you wish, the default Virtuoso instance will be automatically added to
- the list of available System Data Sources (and automatically deleted from
- the list when you remove this package).
- .
- If you elect to register the DSN it will be named VOS and DSN list is
- maintained using the /usr/bin/odbcinst program from unixodbc. User and
- password details are omitted from the DSN for security.
+_Description: Register an ODBC system DSN for Virtuoso?
+ An ODBC manager (unixodbc or iODBC) is already installed on this system,
+ and the Virtuoso ODBC driver is installed.
+ .
+ The default Virtuoso instance can be automatically added to the list of
+ available System Data Sources (and automatically deleted from the list
+ when this package is removed).
+ .
+ If you choose this option, the DSN will be named "VOS". User and
+ password details are omitted from the DSN for security reasons.
 
 Template: virtuoso-opensource/primary-server
 Type: select
 Choices: ${choices}
-_Description: Default Virtuoso Server package:
+_Description: Default Virtuoso server package:
  Please choose the version of virtuoso-server that will be linked to by the
- default (unversioned) names for init scripts and client tools.
+ default (unversioned) names, for init scripts and client tools.
--- virtuoso-opensource-6.1.pristine/debian/libvirtodbc0.templates	2010-02-27 11:37:10.000000000 +0000
+++ virtuoso-opensource-6.1/debian/libvirtodbc0.templates	2010-03-01 09:41:13.000000000 +0000
@@ -1,13 +1,9 @@
 Template: libvirtodbc0/register-odbc-driver
 Type: boolean
 Default: false
-_Description: Do you want to register the Virtuoso ODBC driver?
- You appear to have an ODBC manager (unixodbc or iODBC) installed on your
- system.
+_Description: Register the Virtuoso ODBC driver?
+ An ODBC manager (unixodbc or iODBC)  is already installed on this system.
  .
- If you wish, the Virtuoso ODBC Driver will be automatically added to the
- list of available ODBC drivers (and automatically deleted from the list
- when you remove this package).
- .
- The driver list is maintained using the /usr/bin/odbcinst program from
- unixodbc.
+ The Virtuoso ODBC driver can be automatically added to the list of
+ available ODBC drivers (and automatically deleted from the list
+ when this package is removed).

Reply to: