Please find, for review, the debconf templates and packages descriptions for the wireshark source package.
This review will last from Thursday, September 03, 2009 to Sunday, September 13, 2009.
Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.
Your review should be sent as an answer to this mail.
When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.
When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.
Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.
Rationale:
--- wireshark.old/debian/templates 2009-08-25 19:25:57.682197462 +0200
+++ wireshark/debian/templates 2009-08-30 08:25:58.035658972 +0200
@@ -1,12 +1,12 @@
Template: wireshark-common/install-setuid
Type: boolean
Default: false
-_Description: Do you want dumpcap to be installed setuid root?
+_Description: Do you want dumpcap to be installed "setuid root"?
Quote jargon
Dumpcap can be installed with the set-user-id bit set, so members of
group wireshark will be able to run it with the permissions of the
- 'root' user. It is the preferred way of capturing packets using
+ "root" user. It is the preferred way of capturing packets using
Quotes standardization
Wireshark/Tshark over running Wireshark/Tshark as root, because that
- way most of the code will run with less priveges.
+ way most of the code will run with less privileges.
Typo
.
Enabling this feature may be a security risk, so it is disabled by
- default. If in doubt, it is suggested to leave it disabled.
+ default. If in doubt, it is suggested to leave it disabled.
Drop double spaces
--- wireshark.old/debian/control 2009-08-25 19:25:57.685525791 +0200
+++ wireshark/debian/control 2009-08-30 08:28:14.491660437 +0200
@@ -14,9 +14,8 @@
Recommends: wireshark (>= ${binary:Version}) | tshark (>= ${binary:Version})
Replaces: ethereal-common (<< 1.0.0-3)
Conflicts: ethereal-common (<< 1.0.0-3)
-Description: network traffic analyser (common files)
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyser - common files
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
Use the "standardized" way to separate the common part and the
specific part of package descriptions. Not that the method you were
using is bad....just more because we standardized on another method.:-)
Drop "for Unix and Unix-like" which is not relevant in the context of
a Debian package.
.
@@ -28,22 +27,20 @@
Depends: ${shlibs:Depends}, ${misc:Depends}, wireshark-common (= ${binary:Version})
Replaces: ethereal (<< 1.0.0-3)
Conflicts: ethereal (<< 1.0.0-3)
-Description: network traffic analyzer
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyzer - GTK+ version
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
- This package provides wireshark (the GTK+ version)
+ This package provides the GTK+ version of wireshark.
This seems better to me.
Other changes are similar to the above....
Package: tshark
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, wireshark-common (= ${binary:Version})
Replaces: tethereal (<< 1.0.0-3)
Conflicts: tethereal (<< 1.0.0-3)
-Description: network traffic analyzer (console)
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyzer - console version
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
@@ -57,9 +54,8 @@
Replaces: ethereal-dev (<< 1.0.0-3)
Conflicts: ethereal-dev (<< 1.0.0-3)
XB-Python-Version: ${python:Versions}
-Description: network traffic analyser (development tools)
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyser - development tools
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
--
Template: wireshark-common/install-setuid Type: boolean Default: false _Description: Do you want dumpcap to be installed "setuid root"? Dumpcap can be installed with the set-user-id bit set, so members of group wireshark will be able to run it with the permissions of the "root" user. It is the preferred way of capturing packets using Wireshark/Tshark over running Wireshark/Tshark as root, because that way most of the code will run with less privileges. . Enabling this feature may be a security risk, so it is disabled by default. If in doubt, it is suggested to leave it disabled.
--- wireshark.old/debian/templates 2009-08-25 19:25:57.682197462 +0200
+++ wireshark/debian/templates 2009-08-30 08:25:58.035658972 +0200
@@ -1,12 +1,12 @@
Template: wireshark-common/install-setuid
Type: boolean
Default: false
-_Description: Do you want dumpcap to be installed setuid root?
+_Description: Do you want dumpcap to be installed "setuid root"?
Dumpcap can be installed with the set-user-id bit set, so members of
group wireshark will be able to run it with the permissions of the
- 'root' user. It is the preferred way of capturing packets using
+ "root" user. It is the preferred way of capturing packets using
Wireshark/Tshark over running Wireshark/Tshark as root, because that
- way most of the code will run with less priveges.
+ way most of the code will run with less privileges.
.
Enabling this feature may be a security risk, so it is disabled by
- default. If in doubt, it is suggested to leave it disabled.
+ default. If in doubt, it is suggested to leave it disabled.
--- wireshark.old/debian/control 2009-08-25 19:25:57.685525791 +0200
+++ wireshark/debian/control 2009-08-30 08:28:14.491660437 +0200
@@ -14,9 +14,8 @@
Recommends: wireshark (>= ${binary:Version}) | tshark (>= ${binary:Version})
Replaces: ethereal-common (<< 1.0.0-3)
Conflicts: ethereal-common (<< 1.0.0-3)
-Description: network traffic analyser (common files)
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyser - common files
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
@@ -28,22 +27,20 @@
Depends: ${shlibs:Depends}, ${misc:Depends}, wireshark-common (= ${binary:Version})
Replaces: ethereal (<< 1.0.0-3)
Conflicts: ethereal (<< 1.0.0-3)
-Description: network traffic analyzer
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyzer - GTK+ version
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
- This package provides wireshark (the GTK+ version)
+ This package provides the GTK+ version of wireshark.
Package: tshark
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, wireshark-common (= ${binary:Version})
Replaces: tethereal (<< 1.0.0-3)
Conflicts: tethereal (<< 1.0.0-3)
-Description: network traffic analyzer (console)
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyzer - console version
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
@@ -57,9 +54,8 @@
Replaces: ethereal-dev (<< 1.0.0-3)
Conflicts: ethereal-dev (<< 1.0.0-3)
XB-Python-Version: ${python:Versions}
-Description: network traffic analyser (development tools)
- Wireshark is a network traffic analyzer, or "sniffer", for Unix and
- Unix-like operating systems. A sniffer is a tool used to capture
+Description: network traffic analyser - development tools
+ Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
Source: wireshark
Section: net
Priority: optional
Maintainer: Frederic Peters <fpeters@debian.org>
Uploaders: Joost Yervante Damad <andete@debian.org>
Standards-Version: 3.8.2
Build-Depends: libgtk2.0-dev (>=2.4.0-0), libpcap0.8-dev, flex, libz-dev, dpatch, debhelper (>= 6), po-debconf, libtool, python, automake1.9, autoconf, autotools-dev, libc-ares-dev, xsltproc, docbook-xsl (>= 1.64.1.0-0), libpcre3-dev, libcap2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386], bison, libgnutls-dev, python-support (>= 0.3), portaudio19-dev, libkrb5-dev, liblua5.1-0-dev, libsmi2-dev, libgeoip-dev
Build-Conflicts: libsnmp4.2-dev, libsnmp-dev
XS-Python-Version: all
Package: wireshark-common
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, libsmi2-common, debconf
Recommends: wireshark (>= ${binary:Version}) | tshark (>= ${binary:Version})
Replaces: ethereal-common (<< 1.0.0-3)
Conflicts: ethereal-common (<< 1.0.0-3)
Description: network traffic analyser - common files
Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
This package provides files common to both wireshark (the GTK+ version)
and tshark (the console version).
Package: wireshark
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, wireshark-common (= ${binary:Version})
Replaces: ethereal (<< 1.0.0-3)
Conflicts: ethereal (<< 1.0.0-3)
Description: network traffic analyzer - GTK+ version
Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
This package provides the GTK+ version of wireshark.
Package: tshark
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, wireshark-common (= ${binary:Version})
Replaces: tethereal (<< 1.0.0-3)
Conflicts: tethereal (<< 1.0.0-3)
Description: network traffic analyzer - console version
Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
This package provides the console version of wireshark, named
"tshark".
Package: wireshark-dev
Architecture: any
Section: devel
Depends: ${shlibs:Depends}, ${misc:Depends}, omniidl4 (>= 4.0.1-2), libpcap0.8-dev, libtool, libglib2.0-dev, ${python:Depends}, snacc, autotools-dev, debhelper, cdbs, automake1.9, autoconf
Replaces: ethereal-dev (<< 1.0.0-3)
Conflicts: ethereal-dev (<< 1.0.0-3)
XB-Python-Version: ${python:Versions}
Description: network traffic analyser - development tools
Wireshark is a network traffic analyzer, or "sniffer". A sniffer is a tool used to capture
packets off the wire. Wireshark decodes numerous protocols (too many
to list).
.
This package provides idl2wrs and other necessary files to develop
new packet dissectors.
Attachment:
signature.asc
Description: Digital signature