Re: [RFR] templates://nodm/{nodm.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
Just for once I've actually submitted my bugreport as a bugreport
(#523004).
> Rationale:
> _Description: Start nodm on boot?
[...]
> + Designed for embedded or kiosks systems, nodm starts an X session
^
> + for a user without asking for authentication. On regular
> + machines, this has security implications and is therefore disabled
> + by default.
> .
> + You should enable nodm only if you need autologin on this machine.
s/kiosks systems/kiosk systems/, another case where only the last
noun in the pile is pluralisable.
> Template: nodm/user
[...]
> _Description: User to start a session for:
> + Please enter the login name of the user that will automatically be logged into X by nodm.
^
Are people _logged_ into X or _logged in_ to X? That is, is "log
in" a verb plus preposition (like "cut into slices") or a phrasal
verb (like "handed in to the police")? Tricky... I suspect it's the
latter; you can "log in and log out" but you can't "log both ways" -
the verb doesn't work without the particle. Which would mean it's
"log in to". But then again maybe it's "logged in into X" and
people drop the first "in"? Oh well, I don't think there's an
answer right enough to impose as a standard.
> Template: nodm/x_options
[...]
> _Description: Options for the X server:
> + Please enter the options to pass to the X server when starting the session.
> + These options will be used in the NODM_X_OPTIONS variable in the command line used
> + by nodm to start the X session:
> + .
> + $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
>
> I'm unsure about "Please enter the options". Sounds too French for
> being good. Anyway, Justin will correct if needed..:-)
No, this is the one I can't fault.
> Template: nodm/xinit
[...]
> _Description: xinit program to use:
> + Please choose the name of the "xinit" program to use with nodm. That
^^
> + name will be stored in the NODM_XINIT variable in the command line used
> + by nodm to start the X session:
s/That name/This name/, and likewise in nodm/xsession.
Control file:
> Depends: xinit, x11-common, xterm | x-terminal-emulator, ${shlibs:Depends}, ${misc:Depends}
> Conflicts: gdm, xdm, kdm, x-display-manager, zhone-session
Shouldn't it conflict with wdm and slim as well, or something more
sophisticated like providing and conflicting with x-display-manager?
Oops, that's another one that should be a bugreport.
> +Description: automatic display manager
> This packages prepares the system to automatically start an X session at
> system boot. It is targeted for devices like smartphones, but can be used
> a regular computer as well, if the security implications are acceptable.
One preposition missing, one that doesn't really fit its verb:
system boot. It is meant for devices like smartphones, but can be used on
a regular computer as well, if the security implications are acceptable.
> + It should not be installed on a regular system, as it would interfere
> with an installed display manager.
If nodm declares a package conflict with my display manager I don't
need this warning; the only people who might need it are "irregular"
types (like me) who run startx. Once #523004 is fixed there's no
need even for that - there's already a security warning, and it
won't interfere with X unless you enable it.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../nodm-0.2.pristine/debian/nodm.templates 2009-02-23 20:56:34.000000000 +0000
+++ debian/nodm.templates 2009-04-08 13:23:47.000000000 +0100
@@ -2,23 +2,29 @@
Type: boolean
Default: false
_Description: Start nodm on boot?
- nodm starts an X session for a user without asking for authentication. While
- this is welcome for embedded or kiosks systems, it is a security problem in
- most other machines, so by default nodm is configured not to start.
+ Designed for embedded or kiosk systems, nodm starts an X session
+ for a user without asking for authentication. On regular
+ machines, this has security implications and is therefore disabled
+ by default.
.
- If you need autologin on this machine, enable nodm.
+ You should enable nodm only if you need autologin on this machine.
Template: nodm/user
Type: string
Default: root
_Description: User to start a session for:
- Name of the user that will automatically be logged into X by nodm.
+ Please enter the login name of the user that will automatically be logged into X by nodm.
Template: nodm/x_options
Type: string
Default: vt7 -nolisten tcp
+#flag:translate!:3
_Description: Options for the X server:
- Options to pass to the X server when starting the session.
+ Please enter the options to pass to the X server when starting the session.
+ These options will be used in the NODM_X_OPTIONS variable in the command line used
+ by nodm to start the X session:
+ .
+ $NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Template: nodm/min_session_time
Type: string
@@ -31,18 +37,22 @@
Template: nodm/xinit
Type: string
Default: /usr/bin/xinit
+#flag:translate!:3
_Description: xinit program to use:
- You can change this to use a different xinit program.
+ Please choose the name of the "xinit" program to use with nodm. This
+ name will be stored in the NODM_XINIT variable in the command line used
+ by nodm to start the X session:
.
- nodm will start the X session with the command:
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Template: nodm/xsession
Type: string
Default: /etc/X11/Xsession
+#flag:translate!:3
_Description: X session to use:
- You can change this to use a different X session script.
+ Please choose the name of the X session script to use with nodm. This
+ name will be stored in the NODM_XSESSION variable in the command line used
+ by nodm to start the X session:
.
- nodm will start the X session with the command:
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
--- ../nodm-0.2.pristine/debian/control 2009-02-23 20:51:05.000000000 +0000
+++ debian/control 2009-04-08 13:24:27.000000000 +0100
@@ -12,11 +12,7 @@
Architecture: any
Depends: xinit, x11-common, xterm | x-terminal-emulator, ${shlibs:Depends}, ${misc:Depends}
Conflicts: gdm, xdm, kdm, x-display-manager, zhone-session
-Description: Automatic Display Manager
+Description: automatic display manager
This packages prepares the system to automatically start an X session at
- system boot. It is targeted for devices like smartphones, but can be used
+ system boot. It is meant for devices like smartphones, but can be used on
a regular computer as well, if the security implications are acceptable.
- .
- It should not be installed on a regular Debian system, as it would interfere
- with an installed display manager.
-
Template: nodm/enabled
Type: boolean
Default: false
_Description: Start nodm on boot?
Designed for embedded or kiosk systems, nodm starts an X session
for a user without asking for authentication. On regular
machines, this has security implications and is therefore disabled
by default.
.
You should enable nodm only if you need autologin on this machine.
Template: nodm/user
Type: string
Default: root
_Description: User to start a session for:
Please enter the login name of the user that will automatically be logged into X by nodm.
Template: nodm/x_options
Type: string
Default: vt7 -nolisten tcp
#flag:translate!:3
_Description: Options for the X server:
Please enter the options to pass to the X server when starting the session.
These options will be used in the NODM_X_OPTIONS variable in the command line used
by nodm to start the X session:
.
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Template: nodm/min_session_time
Type: string
Default: 60
_Description: Minimum time (in seconds) for a session to be considered ok:
If an X session will run for less than this time in seconds, nodm will wait an
amount of time before restarting the session. The waiting time will grow
until a session lasts longer than this amount.
Template: nodm/xinit
Type: string
Default: /usr/bin/xinit
#flag:translate!:3
_Description: xinit program to use:
Please choose the name of the "xinit" program to use with nodm. This
name will be stored in the NODM_XINIT variable in the command line used
by nodm to start the X session:
.
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Template: nodm/xsession
Type: string
Default: /etc/X11/Xsession
#flag:translate!:3
_Description: X session to use:
Please choose the name of the X session script to use with nodm. This
name will be stored in the NODM_XSESSION variable in the command line used
by nodm to start the X session:
.
$NODM_XINIT $NODM_XSESSION -- $NODM_X_OPTIONS
Source: nodm
Section: misc
Priority: extra
Maintainer: Joachim Breitner <nomeata@debian.org>
Uploaders: Enrico Zini <enrico@debian.org>
Build-Depends: debhelper (>= 7), po-debconf, libpam0g-dev, help2man
Standards-Version: 3.8.0
Vcs-Git: http://git.debian.org/git/pkg-fso/nodm.git
Vcs-Browser: http://git.debian.org/?p=pkg-fso/nodm.git;a=summary
Package: nodm
Architecture: any
Depends: xinit, x11-common, xterm | x-terminal-emulator, ${shlibs:Depends}, ${misc:Depends}
Conflicts: gdm, xdm, kdm, x-display-manager, zhone-session
Description: automatic display manager
This packages prepares the system to automatically start an X session at
system boot. It is meant for devices like smartphones, but can be used on
a regular computer as well, if the security implications are acceptable.
Reply to: