[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://bugzilla/{bugzilla3.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

>  Template: bugzilla3/customized_values
>  Type: boolean
>  Default: true
> -_Description: Did you customized the Status/Resolutions values?
> +_Description: Did you customize the Status/Resolutions values?
> 
> Spelling error

Or a tense-marking error ("Have you customized..."); but it might
not have been "you", so maybe it should say: 

   _Description: Have Status/Resolutions values been customized?
 
>   If you customized values in the Status/Resolution field, you must
>   edit /usr/share/bugzilla3/lib/checksetup_nondebian.pl before
> + the installation can continue.

This claim that "you _must_ edit /this/particular/perlscript" is
contradicted in the following paragraph.  Instead say:

    If values in the Status/Resolution field have been customized, the
    checksetup procedure must be modified appropriately before installation
    can continue.

>   .
> + For each update of this package, a new version of the checksetup_nondebian.pl
> + script is installed; the /usr/share/bugzilla3/debian/pre-checksetup.d
> + directory can be used to automaticaly apply your modifications before
>   execution.

s/automaticaly/automatically/ (here and again later)

(I'm being told to put local customisations in a subdirectory of
/usr/share/<packagename>?  That sounds like an FHS policy bug for a
start.  And why is it asking me whether I remember modifying it,
instead of just going and looking?)
  
>  Template: bugzilla3/customized_values_ask_again
[...]
>   If you modified Status/Resolution fields and created a script within
>   /usr/share/bugzilla3/debian/pre-checksetup.pl to apply changes
                                              ^^^
> + on /usr/share/bugzilla3/lib/checksetup-nondebian.pl, you may want to
> + avoid being prompted at each package upgrade.

    If you modified Status/Resolution fields and created a script within
    /usr/share/bugzilla3/debian/pre-checksetup.d to apply changes to
    /usr/share/bugzilla3/lib/checksetup-nondebian.pl, you may want to avoid
    being prompted at each package upgrade.

In the control file:
>   Bugzilla is a Bug Tracking System available through a web interface. 

I'd suggest s/available/accessible/.

>   .
>   It supports the following features:

"The following [noun]s", followed by a list of verb phrases - change
the intro to match: 

    Bugzilla is a Bug Tracking System accessible through a web interface,
    with which you can:
> +  * report bugs;
> +  * assign bugs to the appropriate developers;
> +  * prioritize bugs;
> +  * set bug dependencies;
> +  * arrange bugs by product and component.
>   With these features, you can also use Bugzilla as a todo list manager.

Is that "with" in the sense of alongside or by-means-of?

    It can also be used as a todo list manager.

>   Bugzilla is a web application that lets users report and look up existing bugs.
>   Changes made to a bug's status are automatically sent to users concerned with
>   it.

A bit confusing.  For instance, if "existing bugs" means the filed
BTS entries that users can "look up", we don't _want_ users to
"report [...] existing bugs" again!

    This package provides a web application that lets users make and look
    up bug reports. Interested users are automatically informed about
    changes to a bug's status.

(This version is also a bit less repetitive, but it could probably
all be reduced to a couple of bulletpoints on the list above.)
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# debian-l10n-english@lists.debian.org for advice.
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: bugzilla3/pwd_check
Type: password
_Description: Password confirmation:

Template: bugzilla3/bugzilla_admin_name
Type: string
_Description: Email address of Bugzilla administrator:
 Please enter the email address of the Bugzilla administrator; all mail for
 the administrator will be sent to this address. This email
 address is also used as the administrator login for Bugzilla.
 .
 A valid address must contain exactly one '@', and at least one '.' after
 the @. You'll be able to change this setting through Bugzilla's
 web interface.

Template: bugzilla3/bugzilla_admin_real_name
Type: string
_Description: Real name of Bugzilla administrator:

Template: bugzilla3/bugzilla_admin_pwd
Type: password
_Description: Password for the Bugzilla administrator account:

Template: bugzilla3/customized_values
Type: boolean
Default: true
_Description: Have Status/Resolutions values been customized?
 If values in the Status/Resolution field have been customized, the
 checksetup procedure must be modified appropriately before installation
 can continue.
 .
 For each update of this package, a new version of the checksetup_nondebian.pl
 script is installed; the /usr/share/bugzilla3/debian/pre-checksetup.d
 directory can be used to automatically apply your modifications before
 execution.

Template: bugzilla3/customized_values_ask_again
Type: boolean
Default: false
_Description: Prompt about customized Status/Resolution at each update?
 If you modified Status/Resolution fields and created a script within
 /usr/share/bugzilla3/debian/pre-checksetup.d to apply changes to
 /usr/share/bugzilla3/lib/checksetup-nondebian.pl, you may want to avoid
 being prompted at each package upgrade.
 .
 If you accept being prompted, you will have to call
 /usr/share/bugzilla3/lib/checksetup.pl yourself, at each package
 upgrade, before using Bugzilla.
 .
 If you did not modify Status/Resolution, you should skip prompting as
 checksetup.pl will be started
 automaticaly (together with the {pre,post}-checksetup.d scripts).
Source: bugzilla
Section: web
Priority: optional
Maintainer: Raphael Bossek <bossekr@debian.org>
Build-Depends: po-debconf, debhelper (>= 5)
Build-Depends-Indep: debconf (>= 0.9.95) | debconf-2.0
Standards-Version: 3.8.2

Package: bugzilla3
Architecture: all
Section: web
Homepage: http://www.bugzilla.org
Depends: debconf (>= 0.9.95), 
         libtemplate-perl (>= 2.19-1),
         libappconfig-perl (>= 1.56-2),
         libtimedate-perl (>= 1.1600-9),
         libemail-send-perl (>= 2.192-1),
         libmail-sendmail-perl,
         libemail-mime-modifier-perl (>= 1.442-2),
         libemail-reply-perl (>= 1.202) | libemail-mime-creator-perl,
         libcgi-pm-perl (>= 3.33),
         libdbd-mysql-perl (>= 1.56-2) | libdbd-pg-perl, 
         apache2 | httpd,
         exim4 | mail-transport-agent,
         ucf (>= 0.08), patch, dbconfig-common (>= 1.8.27),
         mysql-client | postgresql-client,
         yui,
         ${misc:Depends}
Suggests: bugzilla3-doc,
          libnet-ldap-perl,
          libgd-text-perl,
          libgd-graph-perl, libgd-gd2-perl | libgd-noxpm-perl,
          libmailtools-perl (>= 1.77-1),
          libmime-tools-perl (>= 5.425-2),
          libhtml-parser-perl,
          libhtml-scrubber-perl,
          libxml-twig-perl,
          libauthen-radius-perl,
          graphviz,
          libsoap-lite-perl,
          patchutils,
          libwww-perl
Recommends: libchart-perl (>= 0.99c.pre3-0.1),
            libxml-parser-perl,
            perlmagick,
            mysql-server | postgresql,
            cvs,
            imagemagic
Conflicts: bugzilla (<< 3.0.0)
Replaces: bugzilla (<< 3.0.0)
Description: web-based bug tracking system
 Bugzilla is a Bug Tracking System accessible through a web interface,
 with which you can:
  * report bugs;
  * assign bugs to the appropriate developers;
  * prioritize bugs;
  * set bug dependencies;
  * arrange bugs by product and component.
 It can also be used as a todo list manager.
 .
 This package provides a web application that lets users make and look
 up bug reports. Interested users are automatically informed about
 changes to a bug's status.

Package: bugzilla3-doc
Section: doc
Architecture: all
Suggests: bugzilla3
Depends: ${misc:Depends}
Homepage: http://www.bugzilla.org
Description: comprehensive guide to Bugzilla
 The Bugzilla Guide is a document (in ASCII text, HTML, and SGML format)
 discussing Bugzilla administration, maintenance, and use.

--- bugzilla-3.2.4.0.pristine/debian/bugzilla3.templates	2009-07-23 20:27:27.000000000 +0100
+++ bugzilla-3.2.4.0/debian/bugzilla3.templates	2009-07-31 19:24:20.000000000 +0100
@@ -14,7 +14,7 @@
 Template: bugzilla3/bugzilla_admin_name
 Type: string
 _Description: Email address of Bugzilla administrator:
- Please enter the email address of Bugzilla administrator; all mail for
+ Please enter the email address of the Bugzilla administrator; all mail for
  the administrator will be sent to this address. This email
  address is also used as the administrator login for Bugzilla.
  .
@@ -33,27 +33,29 @@
 Template: bugzilla3/customized_values
 Type: boolean
 Default: true
-_Description: Did you customized the Status/Resolutions values?
- If you customized values in the Status/Resolution field, you must
- edit /usr/share/bugzilla3/lib/checksetup_nondebian.pl before
- installation can continue.
+_Description: Have Status/Resolutions values been customized?
+ If values in the Status/Resolution field have been customized, the
+ checksetup procedure must be modified appropriately before installation
+ can continue.
  .
- Because with each update a new version of the checksetup_nondebian.pl
- script is installed the /usr/share/bugzilla3/debian/pre-checksetup.d
- directory can be used to automaticaly apply your modification before
+ For each update of this package, a new version of the checksetup_nondebian.pl
+ script is installed; the /usr/share/bugzilla3/debian/pre-checksetup.d
+ directory can be used to automatically apply your modifications before
  execution.
 
 Template: bugzilla3/customized_values_ask_again
 Type: boolean
 Default: false
-_Description: Do you want to be asked for customized Status/Resolution again?
+_Description: Prompt about customized Status/Resolution at each update?
  If you modified Status/Resolution fields and created a script within
- /usr/share/bugzilla3/debian/pre-checksetup.pl to apply changes
- on /usr/share/bugzilla3/lib/checksetup-nondebian.pl you can negate this
- question. If you confirm to this question you have to call
- /usr/share/bugzilla3/lib/checksetup.pl yourself before using Bugzilla.
+ /usr/share/bugzilla3/debian/pre-checksetup.d to apply changes to
+ /usr/share/bugzilla3/lib/checksetup-nondebian.pl, you may want to avoid
+ being prompted at each package upgrade.
  .
- If you did not modified Status/Resolution and do not intent to do so
- in the near future disagree with this question. checksetup.pl will be started
- automaticaly (together with the {pre,post}-checksetup.d scripts). If you
- change someday your mind do not forget to dpkg-reconfigure -phigh bugzilla3.
+ If you accept being prompted, you will have to call
+ /usr/share/bugzilla3/lib/checksetup.pl yourself, at each package
+ upgrade, before using Bugzilla.
+ .
+ If you did not modify Status/Resolution, you should skip prompting as
+ checksetup.pl will be started
+ automaticaly (together with the {pre,post}-checksetup.d scripts).
--- bugzilla-3.2.4.0.pristine/debian/control	2009-07-23 20:27:27.000000000 +0100
+++ bugzilla-3.2.4.0/debian/control	2009-07-31 19:22:31.000000000 +0100
@@ -49,19 +49,18 @@
 Conflicts: bugzilla (<< 3.0.0)
 Replaces: bugzilla (<< 3.0.0)
 Description: web-based bug tracking system
- Bugzilla is a Bug Tracking System available through a web interface. 
+ Bugzilla is a Bug Tracking System accessible through a web interface,
+ with which you can:
+  * report bugs;
+  * assign bugs to the appropriate developers;
+  * prioritize bugs;
+  * set bug dependencies;
+  * arrange bugs by product and component.
+ It can also be used as a todo list manager.
  .
- It supports the following features:
-  - report bugs;
-  - assign bugs to the appropriate developers;
-  - prioritize bugs;
-  - set bug dependencies;
-  - arrange bugs by product and component.
- With these features, you can also use Bugzilla as a todo list manager.
- .
- Bugzilla is a web application that lets users report and look up existing bugs.
- Changes made to a bug's status are automatically sent to users concerned with
- it.
+ This package provides a web application that lets users make and look
+ up bug reports. Interested users are automatically informed about
+ changes to a bug's status.
 
 Package: bugzilla3-doc
 Section: doc

Reply to: