[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for review: New MySQL 5.1 upload



Christian Hammers wrote:
> Somewhere in my todo list was a note to ask you if you can review the
> template of mysql-server-5.1, which is already present in experimental
> and will soon be uploaded to unstable, before the other translator
> teams translate it.
> 
> The package source is already available from:
> http://packages.debian.org/sid/mysql-server-5.1

That was a bit tricky to get hold of, so I'll attach a copy of the
original as well as the patch and modified version.  More changes
may be needed - commented pseudopatch follows.

>  Template: mysql-server-5.1/really_downgrade
[...]
>  _Description: Really proceed with downgrade?
>   A file named /var/lib/mysql/debian-*.flag exists on this system.
>   .
> - Such file is an indication that a mysql-server package with a higher
> - version has been installed earlier.
> + Such a file is an indication that a mysql-server package with a higher
> + version has been installed previously.
>   .
>   There is no guarantee that the version you're currently installing
>   will be able to use the current databases.

Moving it slightly further away from the misinterpretation "has
already been installed (and still is)" towards "has ever been
installed (even if it has since been purged)".

>  Template: mysql-server-5.1/nis_warning
>  Type: note
>  #flag:translate!:3,5
>  _Description: Important note for NIS/YP users
> - To use MySQL, the following entries for users and groups should be added
> - to the system:

This gives the impression that it needs _exactly_ this entry in
/etc/passwd (and none in /etc/shadow). 

> + Using MySQL under NIS/YP requires a mysql user account to be added on
> + the local system:
>   .
> -  /etc/passwd   : mysql:x:100:101:MySQL Server:/var/lib/mysql:/bin/false
> -  /etc/group    : mysql:x:101:
> +  /etc/passwd: mysql:x:100:101:MySQL Server:/var/lib/mysql:/bin/false
> +  /etc/group:  mysql:x:101:

Just a punctuation fix.

Isn't this a job for adduser, which will pick different UID and GID
values if (as is likely) those are already in use?  So why specify
them at all, when you could be specifying the commandline?

     adduser --system --group --home /var/lib/mysql mysql

(I think...)

>   .
> - You should also check the permissions and the owner of the
> + You should also check the permissions and ownership of the
>   /var/lib/mysql directory:
>   .
>    /var/lib/mysql: drwxr-xr-x   mysql    mysql

(Just to make it absolutely clear that you don't need to "check" the
mysql user, which is "the owner of the directory".) 

>  Template: mysql-server/root_password
>  Type: password
>  _Description: New password for the MySQL "root" user:
>   While not mandatory, it is highly recommended that you set a password
>   for the MySQL administrative "root" user.
>   .
> - If that field is left blank, the password will not be changed.
> + If this field is left blank, the password will not be changed.

But talking about a "field" may be unclear with some debconf
front-ends (Christian Perrier would know), so perhaps it should be
"If you do not specify one, the default password will be used"?
  
>  Template: mysql-server/no_upgrade_when_using_ndb
>  Type: error
>  _Description: NDB Cluster seems to be in use
> - MySQL-5.1 has orphaned NDB Cluster support. Please migrate to the new
> + MySQL-5.1 no longer provides NDB Cluster support. Please migrate to the new
>   mysql-cluster package and remove all lines starting with "ndb" from
>   all config files below /etc/mysql/.
 
Avoiding developerese. 
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# for an advice to debian-l10n-english@lists.debian.org
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: mysql-server-5.1/really_downgrade
Type: boolean
Default: false
_Description: Really proceed with downgrade?
 A file named /var/lib/mysql/debian-*.flag exists on this system.
 .
 Such file is an indication that a mysql-server package with a higher
 version has been installed earlier.
 .
 There is no guarantee that the version you're currently installing
 will be able to use the current databases.

Template: mysql-server-5.1/nis_warning
Type: note
#flag:translate!:3,5
_Description: Important note for NIS/YP users
 To use MySQL, the following entries for users and groups should be added
 to the system:
 .
  /etc/passwd   : mysql:x:100:101:MySQL Server:/var/lib/mysql:/bin/false
  /etc/group    : mysql:x:101:
 .
 You should also check the permissions and the owner of the
 /var/lib/mysql directory:
 .
  /var/lib/mysql: drwxr-xr-x   mysql    mysql

Template: mysql-server-5.1/postrm_remove_databases
Type: boolean
Default: false
_Description: Remove all MySQL databases?
 The /var/lib/mysql directory which contains the MySQL databases is about
 to be removed.
 .
 If you're removing the MySQL package in order to later install a more
 recent version or if a different mysql-server package is already
 using it, the data should be kept.

Template: mysql-server-5.1/start_on_boot
Type: boolean
Default: true
_Description: Start the MySQL server on boot?
 The MySQL server can be launched automatically at boot time or manually
 with the '/etc/init.d/mysql start' command.

Template: mysql-server/root_password
Type: password
_Description: New password for the MySQL "root" user:
 While not mandatory, it is highly recommended that you set a password
 for the MySQL administrative "root" user.
 .
 If that field is left blank, the password will not be changed.

Template: mysql-server/root_password_again
Type: password
_Description: Repeat password for the MySQL "root" user:

Template: mysql-server/error_setting_password
Type: error
_Description: Unable to set password for the MySQL "root" user
 An error occurred while setting the password for the MySQL
 administrative user. This may have happened because the account
 already has a password, or because of a communication problem with
 the MySQL server.
 .
 You should check the account's password after the package installation.
 .
 Please read the /usr/share/doc/mysql-server-5.1/README.Debian file
 for more information.

Template: mysql-server/password_mismatch
Type: error
_Description: Password input error
 The two passwords you entered were not the same. Please try again.

Template: mysql-server/no_upgrade_when_using_ndb
Type: error
_Description: NDB Cluster seems to be in use
 MySQL-5.1 has orphaned NDB Cluster support. Please migrate to the new
 mysql-cluster package and remove all lines starting with "ndb" from
 all config files below /etc/mysql/.
# These templates have been reviewed by the debian-l10n-english
# team
#
# If modifications/additions/rewording are needed, please ask
# for an advice to debian-l10n-english@lists.debian.org
#
# Even minor modifications require translation updates and such
# changes should be coordinated with translators and reviewers.

Template: mysql-server-5.1/really_downgrade
Type: boolean
Default: false
_Description: Really proceed with downgrade?
 A file named /var/lib/mysql/debian-*.flag exists on this system.
 .
 Such a file is an indication that a mysql-server package with a higher
 version has been installed previously.
 .
 There is no guarantee that the version you're currently installing
 will be able to use the current databases.

Template: mysql-server-5.1/nis_warning
Type: note
#flag:translate!:3,5
_Description: Important note for NIS/YP users
 Using MySQL under NIS/YP requires a mysql user account to be added on
 the local system:
 .
  /etc/passwd: mysql:x:100:101:MySQL Server:/var/lib/mysql:/bin/false
  /etc/group:  mysql:x:101:
 .
 You should also check the permissions and ownership of the
 /var/lib/mysql directory:
 .
  /var/lib/mysql: drwxr-xr-x   mysql    mysql

Template: mysql-server-5.1/postrm_remove_databases
Type: boolean
Default: false
_Description: Remove all MySQL databases?
 The /var/lib/mysql directory which contains the MySQL databases is about
 to be removed.
 .
 If you're removing the MySQL package in order to later install a more
 recent version or if a different mysql-server package is already
 using it, the data should be kept.

Template: mysql-server-5.1/start_on_boot
Type: boolean
Default: true
_Description: Start the MySQL server on boot?
 The MySQL server can be launched automatically at boot time or manually
 with the '/etc/init.d/mysql start' command.

Template: mysql-server/root_password
Type: password
_Description: New password for the MySQL "root" user:
 While not mandatory, it is highly recommended that you set a password
 for the MySQL administrative "root" user.
 .
 If this field is left blank, the password will not be changed.

Template: mysql-server/root_password_again
Type: password
_Description: Repeat password for the MySQL "root" user:

Template: mysql-server/error_setting_password
Type: error
_Description: Unable to set password for the MySQL "root" user
 An error occurred while setting the password for the MySQL
 administrative user. This may have happened because the account
 already has a password, or because of a communication problem with
 the MySQL server.
 .
 You should check the account's password after the package installation.
 .
 Please read the /usr/share/doc/mysql-server-5.1/README.Debian file
 for more information.

Template: mysql-server/password_mismatch
Type: error
_Description: Password input error
 The two passwords you entered were not the same. Please try again.

Template: mysql-server/no_upgrade_when_using_ndb
Type: error
_Description: NDB Cluster seems to be in use
 MySQL-5.1 no longer provides NDB Cluster support. Please migrate to the new
 mysql-cluster package and remove all lines starting with "ndb" from
 all config files below /etc/mysql/.
--- mysql-server-5.1.templates.pristine	2009-07-26 14:50:03.000000000 +0100
+++ mysql-server-5.1.templates	2009-07-26 15:41:34.000000000 +0100
@@ -13,8 +13,8 @@
 _Description: Really proceed with downgrade?
  A file named /var/lib/mysql/debian-*.flag exists on this system.
  .
- Such file is an indication that a mysql-server package with a higher
- version has been installed earlier.
+ Such a file is an indication that a mysql-server package with a higher
+ version has been installed previously.
  .
  There is no guarantee that the version you're currently installing
  will be able to use the current databases.
@@ -23,13 +23,13 @@
 Type: note
 #flag:translate!:3,5
 _Description: Important note for NIS/YP users
- To use MySQL, the following entries for users and groups should be added
- to the system:
+ Using MySQL under NIS/YP requires a mysql user account to be added on
+ the local system:
  .
-  /etc/passwd   : mysql:x:100:101:MySQL Server:/var/lib/mysql:/bin/false
-  /etc/group    : mysql:x:101:
+  /etc/passwd: mysql:x:100:101:MySQL Server:/var/lib/mysql:/bin/false
+  /etc/group:  mysql:x:101:
  .
- You should also check the permissions and the owner of the
+ You should also check the permissions and ownership of the
  /var/lib/mysql directory:
  .
   /var/lib/mysql: drwxr-xr-x   mysql    mysql
@@ -58,7 +58,7 @@
  While not mandatory, it is highly recommended that you set a password
  for the MySQL administrative "root" user.
  .
- If that field is left blank, the password will not be changed.
+ If this field is left blank, the password will not be changed.
 
 Template: mysql-server/root_password_again
 Type: password
@@ -85,6 +85,6 @@
 Template: mysql-server/no_upgrade_when_using_ndb
 Type: error
 _Description: NDB Cluster seems to be in use
- MySQL-5.1 has orphaned NDB Cluster support. Please migrate to the new
+ MySQL-5.1 no longer provides NDB Cluster support. Please migrate to the new
  mysql-cluster package and remove all lines starting with "ndb" from
  all config files below /etc/mysql/.

Reply to: