[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://nbd/{nbd-client.templates,nbd-server.templates}

On Thu, Apr 30, 2009 at 10:30:02PM +0100, Justin B Rye wrote:
> Wouter Verhelst wrote:
> > On Wed, Apr 29, 2009 at 10:17:58PM +0100, Justin B Rye wrote:
> >>>  Template: nbd-client/killall
> >> [...]
> >>>  _Description: Kill all nbd devices on 'stop'?
> >> 
> >> "Killing" a device suggests smashing the hardware; as far as I can
> >> see there's not even any use of kill or killall here, just umount.
> > 
> > There's a disconnect too, actually.
> So how about always using the word "disconnect" for NBD devices,
> including in the first paragraph of text?

Er, good point :-)

> > The traditional behaviour was not configurable; it would *always*
> > disconnect all devices. I received a (valid, of course) bug report about
> > that, which is why this feature was added.
> So it definitely needs amending; maybe:
>  _Description: Disconnect all NBD devices on "stop"?
>   When the nbd-client initscript is called to stop the nbd-client service,
>   there are two things that can be done: either it can disconnect all
>   nbd-client devices (which are assumed not to be in use), or it can
>   disconnect only those nbd-client devices that it knows about in its
>   config file.
>   .
>   The default (and the traditional behavior) is to disconnect all
>   nbd-client devices. If the root device or other critical file systems
>   are on NBD this will cause data loss and should not be accepted.

Yeah, that looks good.

The biometric identification system at the gates of the CIA headquarters
works because there's a guard with a large gun making sure no one is
trying to fool the system.

Reply to: