Re: [RFR] templates://glide/{libglide2.templates,libglide3.templates}
On Mon, 2009-03-30 at 19:55:46 +0100, Justin B Rye wrote:
> Christian Perrier wrote:
> > Your review should be sent as an answer to this mail.
>
> As usual I've spotted something that belongs as a bugreport
> (assuming I haven't misunderstood). There are references throughout
> the debian/ directory to a package "glide3-bin", but I can find no
> evidence it has ever been built. Simply adding a glide3-bin stanza
> to the control file and rebuilding isn't enough to give an extra
> output .deb...
>
> Is this intentional? Or if it isn't but nobody has noticed in all
> the years since 3dfx Interactive existed, is there any point fixing
> it now?
I'm not sure about the previous maintainer, but I guess the idea has been
to add such package in the future, but it has never happened. Anyway once
I deprecate libglide2 then this will have to happen for sure.
> > Template: libglide3/card
>
> I notice this one checks for "the following 3Dfx chipsets: Voodoo 2,
> Voodoo Banshee, Voodoo 3, Voodoo 4, and Voodoo 5". Should the first
> three be on that list?
Yes, recent versions of libglide3 include support for those older
chipsets, which got forward ported from libglide2.
> > + You'll need the /dev/3dfx kernel driver to use this library.
>
> /dev/3dfx is a device; the driver is 3dfx(.ko)
Right, but I guess it'd be more helpful to mention either the package
containing the module sources (device3dfx-source) or the module itself
(device3dfx-module).
> > - NB: This package does NOT need device3dfx, as it is using DRI instead.
> > + This package does not need device3dfx, as it is using DRI instead.
>
> This looks like some sort of search-and-replace error for /dev/3dfx;
> fix as above.
device3dfx is the name of the project for the 3dfx kernel module and
the packages containing the sources and the module.
> --- ../glide-2002.04.10ds1.pristine/debian/control 2009-03-24 10:05:02.000000000 +0000
> +++ debian/control 2009-03-30 18:38:47.000000000 +0100
> @@ -1,46 +1,48 @@
> Source: glide
> Section: libs
> Priority: optional
> -Build-Depends: debhelper (>= 7), quilt (>= 0.40), autoconf, automake,
> +Build-Depends: dbs (>= 0.25), debhelper (>= 5), autoconf, automake,
> libtool (>= 1.5), libx11-dev, libxext-dev, libxxf86dga-dev, libxxf86vm-dev
> Build-Conflicts: automake1.4
> Maintainer: Guillem Jover <guillem@debian.org>
> Homepage: http://glide.sf.net/
> Vcs-Browser: http://git.hadrons.org/?p=debian/pkgs/glide.git
> Vcs-Git: git://git.hadrons.org/git/debian/pkgs/glide.git
> -Standards-Version: 3.8.0
> +Standards-Version: 3.7.3
It seems you'all have been diffing against an older version of the
packages, although I don't think I've changed descriptions or
templates in those.
thanks,
guillem
Reply to: