[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [LCFC] templates://nethack/{nethack-common.templates}



Hi, 

On Monday 09 March 2009, Christian Perrier wrote:
> This is the last call for comments for the review of debconf
> templates for nethack.

Some comments on the reviewed templates.

--- nethack-3.4.3.old/debian/control	2009-03-09 22:05:40.000000000 +0200
+++ nethack-3.4.3/debian/control	2009-03-09 22:37:48.000000000 +0200
@@ -35,7 +35,7 @@
  .
  It also provides a few utilities such as recover, for retrieving auto-save 
files in case
  of a power failure, and dgn_comp and lev_comp, two utilities for making
- your own NetHack levels and dungeons. The "recover" may be run every time 
the system
+ your own NetHack levels and dungeons. The "recover" will be run every time 
the system
  boots, if there are any auto-save files available.

Changing "may" to "will" because the recover will be run at the system boot 
(as also stated in the debconf templates).


--- nethack-3.4.3.old/debian/nethack-common.templates	2009-03-09 
22:05:34.000000000 +0200
+++ nethack-3.4.3/debian/nethack-common.templates	2009-03-09 
22:38:04.000000000 +0200
@@ -3,14 +3,14 @@
 Default: false
 _Description: Use setgid bit with NetHack's recover utility?
  The "recover" program is installed as part of the nethack-common package
- and exists to help the administrator recover broken save files, etc.
+ and exists to help the administrator recover broken save files, etc. It
+ is run automatically, as root, during the system boot.
  . 
  Recover is traditionally installed with the "setgid" bit (group "games").
- However, this package runs it automatically, as root, during the system
- boot. As a consequence, allowing the utility to use the "games" group
- privileges is only useful
- to let players recover their save
- files, should NetHack crash or their connection drop mid-game.
+ This allows players to recover their save files, should NetHack crash or
+ their connection drop mid-game. However, this leaves the Nethack's save
+ directory world-writable and makes possible both cheating and messing up
+ other players.
  .
  If you do not choose this option, recovers after a crash or a connection
  drop can only be run as root or by a user who is member of the "games"

I was first going to say that "allowing the utility to use the "games" group 
privileges" doesn't make sense as the recover is installed as root:games so 
it already has the games group privileges. What the setgid does is to let 
also users not in the games group to run recover with the games group 
privileges.

Then I started to think that maybe this whole paragraph should be changed as 
the word "only" doesn't make sense either. The only function of the recover 
program is to allow recovering games interrupted by some disaster so there is 
no point saying it only allows that. Hence, after reading the recover man 
page, the new version.

Cheers, 
Edu

-- 
Esko Arajärvi - edu@iki.fi - +358-50-5446844
"Only idiots quote signatures." -Antti Kuntsi (at his .sig)
--- nethack-3.4.3.old/debian/control	2009-03-09 22:05:40.000000000 +0200
+++ nethack-3.4.3/debian/control	2009-03-09 22:37:48.000000000 +0200
@@ -35,7 +35,7 @@
  .
  It also provides a few utilities such as recover, for retrieving auto-save files in case
  of a power failure, and dgn_comp and lev_comp, two utilities for making
- your own NetHack levels and dungeons. The "recover" may be run every time the system
+ your own NetHack levels and dungeons. The "recover" will be run every time the system
  boots, if there are any auto-save files available.
 
 Package: nethack-console
--- nethack-3.4.3.old/debian/nethack-common.templates	2009-03-09 22:05:34.000000000 +0200
+++ nethack-3.4.3/debian/nethack-common.templates	2009-03-09 22:38:04.000000000 +0200
@@ -3,14 +3,14 @@
 Default: false
 _Description: Use setgid bit with NetHack's recover utility?
  The "recover" program is installed as part of the nethack-common package
- and exists to help the administrator recover broken save files, etc.
+ and exists to help the administrator recover broken save files, etc. It
+ is run automatically, as root, during the system boot.
  . 
  Recover is traditionally installed with the "setgid" bit (group "games").
- However, this package runs it automatically, as root, during the system
- boot. As a consequence, allowing the utility to use the "games" group
- privileges is only useful
- to let players recover their save
- files, should NetHack crash or their connection drop mid-game.
+ This allows players to recover their save files, should NetHack crash or
+ their connection drop mid-game. However, this leaves the Nethack's save
+ directory world-writable and makes possible both cheating and messing up
+ other players.
  .
  If you do not choose this option, recovers after a crash or a connection
  drop can only be run as root or by a user who is member of the "games"

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: