[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://gitosis/{gitosis.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Another easy one.

>  Template: gitosis/username
[...]
> - By default this username is 'gitosis'. You can change this but make sure
> - that for security reasons you do use a dedicated account solely for
> - gitosis.
> + That account name can be customized but you should not use an existing
> + account.

I think s/That/the/

>  Template: gitosis/directory
[...]
>   If you choose an already existing directory, this installation process
> - will not touch it.
> + will not make modifications in it.

> Replace "touch" by something clearer. Maybe "will not modify it" would
> be better English?

Clearer, yes.  Maybe "will leave it unmodified".

>  Description: git repository hosting application
> - gitosis aims to make hosting git repos easier and safer. It manages multiple
> + This package aims to make hosting git repositories easier and safer. It manages multiple
>   repositories under one user account, using SSH keys to identify users. End
>   users do not need shell accounts on the server, they will talk to one shared
>   account that will not let them run arbitrary commands.

"Aims"... oh well, leave it.  There's a comma-splice near the end,
though, so s/,/;/

(There are three occurrences of "user" close together, but I can't
think of anything better.)
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../gitosis.old/debian/gitosis.templates	2009-02-03 20:15:21.000000000 +0000
+++ debian/gitosis.templates	2009-02-11 11:20:44.000000000 +0000
@@ -1,44 +1,37 @@
 Template: gitosis/username
 Type: string
-_Default: gitosis
-_Description: What system account should be created for gitosis?
- gitosis manages all git repositories under one system account, using SSH
- keys to identify users. The name of the system user is part of the clone
- URL when checking out over SSH, e.g. 'git clone
- gitosis@example.com:foo.git'.
+Default: gitosis
+_Description: Dedicated system account for gitosis:
+ Repositories are managed by gitosis under a single system account, using SSH
+ keys to identify users. This account name is part of the clone
+ URL when checking out over SSH, leading to commands such as "git clone
+ gitosis@example.com:foo.git".
  .
- By default this username is 'gitosis'. You can change this but make sure
- that for security reasons you do use a dedicated account solely for
- gitosis.
+ The account name can be customized but you should not use an existing
+ account.
 
 Template: gitosis/directory
 Type: string
-_Default: /srv/gitosis
-_Description: What directory should be used to store repositories?
- The directory where gitosis will manage the git repositories is set by
- default to /srv/gitosis. You can change this if you like.
+Default: /srv/gitosis
+_Description: Directory for git repositories?
+ Please specify the directory where gitosis will manage the git repositories.
  .
  If you choose an already existing directory, this installation process
- will not touch it.
+ will leave it unmodified.
 
 Template: gitosis/key
 Type: string
-_Default: 
-_Description: Enter the SSH public key for accessing the gitosis admin repository (either absolute filename or by pasting the actual key)
- gitosis is configured through gitosis.conf that is stored within the
- gitosis-admin repository. Access to this repository is controled through
- an SSH public key. In order to initialize this respository, you can enter
- such an SSH public key here and you will be able to clone it through 'git
- clone gitosis@example.com:gitosis-admin.git'. See ssh-keygen(1) for more
- information about generating SSH keys.
+Default: 
+_Description: SSH public key for the gitosis admin repository:
+ Configuration for gitosis is stored in a file named "gitosis.conf"
+ which is kept in the gitosis-admin repository.
  .
- If you don't want to initialize the gitosis-admin repository now, you can
- leave this question empty and read in /usr/share/doc/gitosis/README.Debian
- how to initialize it manually.
+ Access to this repository is controlled through an SSH public key.
  .
- If there is already an initialized gitosis-admin repository in your
- gitosis directory, this installation process will not touch it.
+ You can specify an existing key by entering the name of the key file
+ or by pasting the key content itself here. Alternatively, you can leave
+ that field empty and configure the key manually later after
+ reading the /usr/share/doc/gitosis/README.Debian file.
  .
- In order to add new project repositories, please read
- /usr/share/doc/gitosis/README.rst for more information about the format of
- gitosis.conf.
+ If there is already an initialized gitosis-admin repository in the
+ gitosis directory, this installation process will not touch it.
--- ../gitosis.old/debian/control	2009-02-03 20:15:21.000000000 +0000
+++ debian/control	2009-02-11 11:20:11.000000000 +0000
@@ -12,7 +12,7 @@
 Depends: ${misc:Depends}, ${python:Depends}, adduser, git-core (>= 1:1.5.0), openssh-server, python-setuptools (>= 0.6c5), sudo
 Suggests: git-daemon-run, gitweb
 Description: git repository hosting application
- gitosis aims to make hosting git repos easier and safer. It manages multiple
+ This package aims to make hosting git repositories easier and safer. It manages multiple
  repositories under one user account, using SSH keys to identify users. End
- users do not need shell accounts on the server, they will talk to one shared
+ users do not need shell accounts on the server; they will talk to one shared
  account that will not let them run arbitrary commands.
Template: gitosis/username
Type: string
Default: gitosis
_Description: Dedicated system account for gitosis:
 Repositories are managed by gitosis under a single system account, using SSH
 keys to identify users. This account name is part of the clone
 URL when checking out over SSH, leading to commands such as "git clone
 gitosis@example.com:foo.git".
 .
 The account name can be customized but you should not use an existing
 account.

Template: gitosis/directory
Type: string
Default: /srv/gitosis
_Description: Directory for git repositories?
 Please specify the directory where gitosis will manage the git repositories.
 .
 If you choose an already existing directory, this installation process
 will leave it unmodified.

Template: gitosis/key
Type: string
Default: 
_Description: SSH public key for the gitosis admin repository:
 Configuration for gitosis is stored in a file named "gitosis.conf"
 which is kept in the gitosis-admin repository.
 .
 Access to this repository is controlled through an SSH public key.
 .
 You can specify an existing key by entering the name of the key file
 or by pasting the key content itself here. Alternatively, you can leave
 that field empty and configure the key manually later after
 reading the /usr/share/doc/gitosis/README.Debian file.
 .
 If there is already an initialized gitosis-admin repository in the
 gitosis directory, this installation process will not touch it.
Source: gitosis
Section: admin
Priority: optional
Maintainer: Daniel Baumann <daniel@debian.org>
Build-Depends: debhelper (>= 7), quilt, po-debconf, python-dev, python-setuptools (>= 0.6c5), python-support
Standards-Version: 3.8.0
Vcs-Browser: http://git.debian.net/?p=debian/gitosis.git
Vcs-Git: git://git.debian.net/git/debian/gitosis.git

Package: gitosis
Architecture: all
Depends: ${misc:Depends}, ${python:Depends}, adduser, git-core (>= 1:1.5.0), openssh-server, python-setuptools (>= 0.6c5), sudo
Suggests: git-daemon-run, gitweb
Description: git repository hosting application
 This package aims to make hosting git repositories easier and safer. It manages multiple
 repositories under one user account, using SSH keys to identify users. End
 users do not need shell accounts on the server; they will talk to one shared
 account that will not let them run arbitrary commands.

Reply to: